Infrastructure/ipsilon-fedora
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Add infofasjson info plugin #1

Merged
ryanlerch merged 1 commit from staging-infofasjson into staging 2020-09-14 13:58:07 +00:00
Conversation 8 Commits 1 Files changed 1 +89
ryanlerch commented 2020-09-14 12:36:59 +00:00
Owner
Copy link

This adds the initial implementation of the infofasjson plugin, with
support for profile information and groups information. Agreemeents info
coming soon.

Signed-off-by: Ryan Lerch rlerch@redhat.com

This adds the initial implementation of the infofasjson plugin, with support for profile information and groups information. Agreemeents info coming soon. Signed-off-by: Ryan Lerch <rlerch@redhat.com>
abompard commented 2020-09-14 13:50:16 +00:00
First-time contributor
Copy link

Let's set a more relevant default for the final version.

Let's set a more relevant default for the final version.
abompard commented 2020-09-14 13:51:07 +00:00
First-time contributor
Copy link

For the final version, those debug lines can go

For the final version, those debug lines can go
abompard commented 2020-09-14 13:53:00 +00:00
First-time contributor
Copy link

I think catching fasjson_client.errors.ClientError would let us be smarter in our handling of the exception.

I think catching `fasjson_client.errors.ClientError` would let us be smarter in our handling of the exception.
abompard commented 2020-09-14 13:56:18 +00:00
First-time contributor
Copy link

The FAS plugin returns {} explicitely in case of errors, we should probably do that too. Also, the line above is duplicated.

The FAS plugin returns `{}` explicitely in case of errors, we should probably do that too. Also, the line above is duplicated.
abompard commented 2020-09-14 13:57:49 +00:00
First-time contributor
Copy link

I'll merge it so we can test it, on the next PR could you please open it on the dev branch? I was planning on using the staging branch only as a branch we merge into from dev, not from PRs (not a big deal at all ;-) )

I'll merge it so we can test it, on the next PR could you please open it on the `dev` branch? I was planning on using the `staging` branch only as a branch we merge into from `dev`, not from PRs (not a big deal at all ;-) )
abompard commented 2020-09-14 13:58:08 +00:00
First-time contributor
Copy link

Pull-Request has been merged by abompard

Pull-Request has been merged by abompard
nphilipp commented 2020-09-14 13:58:24 +00:00
First-time contributor
Copy link

Uhm, remove one of these? Or do we need the error reported twice?

Uhm, remove one of these? Or do we need the error reported twice?
nphilipp commented 2020-09-14 14:03:42 +00:00
First-time contributor
Copy link

Oops, missed that Aurélien caught this already. I'm late anyway. 😉

Oops, missed that Aurélien caught this already. I'm late anyway. :wink:
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Infrastructure/ipsilon-fedora#1
No description provided.
Delete branch "staging-infofasjson"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?