Infrastructure/fedora-infrastructure
1
0
Fork 0
Code Issues 70 Pull requests Projects Releases Packages Wiki Activity Actions

Add hitlist of bad reviewers.

Browse source
This commit is contained in:
Jason Tibbitts 2011-01-27 09:25:04 -06:00
parent 509f63a196
commit 8ba7b7364b
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
scripts/process-git-requests/process-git-requests
View file

@ -46,6 +46,9 @@ epel_ok = ['abompard', 'athimm', 'corsepiu', 'ecik', 'faucamp', 'konradm',
epel_ok_comaint = ['alexlan', 'guidograzioli', 'jwrdegoede', 'kkofler', epel_ok_comaint = ['alexlan', 'guidograzioli', 'jwrdegoede', 'kkofler',
'mebourne', 'overholt', 'pgordon', 'rishi', 'snirkel'] 'mebourne', 'overholt', 'pgordon', 'rishi', 'snirkel']
# A hand-maintained list of reviewers who have done poor reviews in the past
bad_reviewers = ['rnovacek@redhat.com']
PAGER = os.environ.get('PAGER') or '/usr/bin/less' PAGER = os.environ.get('PAGER') or '/usr/bin/less'
EDITOR = os.environ.get('EDITOR') or '/usr/bin/vi' EDITOR = os.environ.get('EDITOR') or '/usr/bin/vi'
@ -468,6 +471,8 @@ def process_new_request(bug, comment, allcomments, firstfound, pkgdb, fas, branc
if i not in branches: if i not in branches:
warnings.append("WARNING: Invalid branch %s requested" % i) warnings.append("WARNING: Invalid branch %s requested" % i)
warned = True warned = True
if bug.assigned_to in bad_reviewers:
warnings.append("WARNING: Reviewer %s has done poor reviews in the past; please check." % bug.assigned_to)
short_desc = bug.short_desc short_desc = bug.short_desc
m=re.search('Review Request:\s+([a-zA-Z0-9_+.-]+)\s+', short_desc, re.I) m=re.search('Review Request:\s+([a-zA-Z0-9_+.-]+)\s+', short_desc, re.I)