From 8ba7b7364b319ebc7a9c58fa3dda9641d56c66b7 Mon Sep 17 00:00:00 2001 From: Jason Tibbitts Date: Thu, 27 Jan 2011 09:25:04 -0600 Subject: [PATCH] Add hitlist of bad reviewers. --- scripts/process-git-requests/process-git-requests | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/process-git-requests/process-git-requests b/scripts/process-git-requests/process-git-requests index 25e8c0d..ca76a17 100755 --- a/scripts/process-git-requests/process-git-requests +++ b/scripts/process-git-requests/process-git-requests @@ -46,6 +46,9 @@ epel_ok = ['abompard', 'athimm', 'corsepiu', 'ecik', 'faucamp', 'konradm', epel_ok_comaint = ['alexlan', 'guidograzioli', 'jwrdegoede', 'kkofler', 'mebourne', 'overholt', 'pgordon', 'rishi', 'snirkel'] +# A hand-maintained list of reviewers who have done poor reviews in the past +bad_reviewers = ['rnovacek@redhat.com'] + PAGER = os.environ.get('PAGER') or '/usr/bin/less' EDITOR = os.environ.get('EDITOR') or '/usr/bin/vi' @@ -468,6 +471,8 @@ def process_new_request(bug, comment, allcomments, firstfound, pkgdb, fas, branc if i not in branches: warnings.append("WARNING: Invalid branch %s requested" % i) warned = True + if bug.assigned_to in bad_reviewers: + warnings.append("WARNING: Reviewer %s has done poor reviews in the past; please check." % bug.assigned_to) short_desc = bug.short_desc m=re.search('Review Request:\s+([a-zA-Z0-9_+.-]+)\s+', short_desc, re.I)