coreos-cincinnati: revert image related changes in template #2633

Merged

ryanlerch merged 1 commit from PR/cincinnati3 into main

2025-05-21 09:07:43 +00:00

c4rt0 commented

2025-05-20 20:42:32 +00:00

Contributor

As the previous change took no effect and the error while executing
sudo rbac-playbook -l os_control_stg openshift-apps/coreos-cincinnati.yml
continues to return an error as below, let's try another aproach.

"stderr": "The Deployment \"coreos-cincinnati\" is invalid: \n*
spec.template.spec.containers[0].image: Required value

Here adding a specific F42 image

As the previous change took no effect and the error while executing `sudo rbac-playbook -l os_control_stg openshift-apps/coreos-cincinnati.yml` continues to return an error as below, let's try another aproach. ``` "stderr": "The Deployment \"coreos-cincinnati\" is invalid: \n* spec.template.spec.containers[0].image: Required value ``` Here adding a specific F42 image

zuul commented

2025-05-20 20:45:37 +00:00

First-time contributor

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/7af7a141707f43a7a90815ded0d28151

fi-ansible-lint-diff : SUCCESS in 2m 47s
fi-yamllint-diff : SUCCESS in 2m 20s

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/7af7a141707f43a7a90815ded0d28151 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/2caadfea3b6e465f9229daa9e386199e) : SUCCESS in 2m 47s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/e715ae42c7954c47ba33c0dca7170027) : SUCCESS in 2m 20s

dustymabe commented

2025-05-20 21:57:07 +00:00

Contributor

So for the fedora-ostree-pruner we used the name of the imagestream that was the output of the buildconfig:

    spec:
      containers:
        - name: fedora-ostree-pruner
          # sleep infinity is useful for debugging environment issues
          # comment out when not debugging
          # args: ['/usr/bin/sleep', 'infinity']
          # command: ['/usr/bin/dumb-init']
          volumeMounts:
            - name: fedora-ostree-content-volume
              mountPath: /mnt/koji
          image: "fedora-ostree-pruner-img:latest"
          imagePullPolicy: IfNotPresent
          resources: {}

Let's just do the same here:

so:

image: "coreos-cincinnati-img:latest"
imagePullPolicy: IfNotPresent

So for the fedora-ostree-pruner we used the name of the imagestream that was the output of the buildconfig: ``` spec: containers: - name: fedora-ostree-pruner # sleep infinity is useful for debugging environment issues # comment out when not debugging # args: ['/usr/bin/sleep', 'infinity'] # command: ['/usr/bin/dumb-init'] volumeMounts: - name: fedora-ostree-content-volume mountPath: /mnt/koji image: "fedora-ostree-pruner-img:latest" imagePullPolicy: IfNotPresent resources: {} ``` Let's just do the same here: so: ``` image: "coreos-cincinnati-img:latest" imagePullPolicy: IfNotPresent ```

c4rt0 commented

2025-05-21 08:48:21 +00:00

Author

Contributor

rebased onto fd9fd09419

rebased onto fd9fd09419c0fe5c97d4a04ac80e65b68ce830f8

c4rt0 commented

2025-05-21 08:48:49 +00:00

Author

Contributor

image: "coreos-cincinnati-img:latest"
imagePullPolicy: IfNotPresent

Done.

> ``` > image: "coreos-cincinnati-img:latest" > imagePullPolicy: IfNotPresent > ``` Done.

zuul commented

2025-05-21 08:51:29 +00:00

First-time contributor

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/40a7635be7cf4de8a4d2e9537dde38a8

fi-ansible-lint-diff : SUCCESS in 2m 52s
fi-yamllint-diff : SUCCESS in 2m 20s

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/40a7635be7cf4de8a4d2e9537dde38a8 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/06870813b9d04113aa2b6ae40bb2e7de) : SUCCESS in 2m 52s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/9e46433f9bd24a0d87fc61436e5fa7b5) : SUCCESS in 2m 20s