Infrastructure/ansible
5
0
Fork 0
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

Clarify the Frozen variable #2481

Merged
ryanlerch merged 1 commit from clarify-frozen into main 2025-02-18 19:57:57 +00:00
Conversation 6 Commits 1 Files changed 3 +8 -3
adamwill commented 2025-02-18 17:35:00 +00:00
Contributor
Copy link

Per https://pagure.io/infra-docs-fpo/pull-request/361 there seems
to be substantial confusion about what the "Frozen" variable
means: does it refer to the infrastructure freeze, or a freeze
for the pending release? It seems like @kevin thought about it
as referring to the former, but the only practical use of it in
this repo treats it as the latter.

Let's make this clear with explicitly-named variables.
InfraFrozen tracks the infrastructure freeze, NextReleaseFrozen
tracks freezes for the pending release. We formerly had a var
called RelEngFrozen which had a similar meaning, but I like this
name more because the freeze doesn't apply to all releng
operations - just because the current Branched is frozen doesn't
mean Rawhide or stable releases are frozen.

We keep Frozen for 'backwards compatibility', in case anyone is
referring to this variable from outside of the repo.

This goes along with https://pagure.io/infra-docs-fpo/pull-request/361
which updates the SOPs.

Signed-off-by: Adam Williamson awilliam@redhat.com

Per https://pagure.io/infra-docs-fpo/pull-request/361 there seems to be substantial confusion about what the "Frozen" variable means: does it refer to the infrastructure freeze, or a freeze for the pending release? It seems like @kevin thought about it as referring to the former, but the only practical use of it in this repo treats it as the latter. Let's make this clear with explicitly-named variables. InfraFrozen tracks the infrastructure freeze, NextReleaseFrozen tracks freezes for the pending release. We formerly had a var called RelEngFrozen which had a similar meaning, but I like this name more because the freeze doesn't apply to *all* releng operations - just because the current Branched is frozen doesn't mean Rawhide or stable releases are frozen. We keep Frozen for 'backwards compatibility', in case anyone is referring to this variable from outside of the repo. This goes along with https://pagure.io/infra-docs-fpo/pull-request/361 which updates the SOPs. Signed-off-by: Adam Williamson <awilliam@redhat.com>
zuul commented 2025-02-18 17:37:42 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/c3a49edf44e044c58a2ba54cadad230b

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/c3a49edf44e044c58a2ba54cadad230b - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/337fe31200e54169bbfba2271ad977ea) : SUCCESS in 2m 10s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/fc74a9ca3db14d6898befdfa8e59f964) : SUCCESS in 2m 27s
kevin commented 2025-02-18 19:51:58 +00:00
Contributor
Copy link

rebased onto 2e3eaabb1c

rebased onto 2e3eaabb1c3227cd75d332978cbf68b0637c4a38
kevin commented 2025-02-18 19:52:05 +00:00
Contributor
Copy link

rebased onto 2e3eaabb1c

rebased onto 2e3eaabb1c3227cd75d332978cbf68b0637c4a38
zuul commented 2025-02-18 19:54:54 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/1d357f93fba441f88c5a8a50d228a063

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/1d357f93fba441f88c5a8a50d228a063 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/2a79cc4dbd6043b9a733ed66da55eabb) : SUCCESS in 2m 39s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/c1cf9d11eaf746d39365db0de42d27ff) : SUCCESS in 2m 21s
kevin commented 2025-02-18 19:57:38 +00:00
Contributor
Copy link

I agree with changing the name, that seems fine and more descriptive.

I agree with changing the name, that seems fine and more descriptive.
kevin commented 2025-02-18 19:57:58 +00:00
Contributor
Copy link

Pull-Request has been merged by kevin

Pull-Request has been merged by kevin
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
freeze-break-request

   
post-freeze
No labels
freeze-break-request
post-freeze
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Infrastructure/ansible#2481
No description provided.
Delete branch "clarify-frozen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?