dnf-automatic: create a drop-in for the Mon..Fri configuration #2469

Merged
ryanlerch merged 1 commit from dnf-automatic-drop-in into main 2025-02-14 09:25:31 +00:00
Contributor
See https://github.com/fedora-copr/copr/issues/3623#issuecomment-2656844947
First-time contributor

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/65f8b7899ff2490c90e3a3d29493bca2

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/65f8b7899ff2490c90e3a3d29493bca2 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/e170e5f277804eaa898fe60a48611ae1) : FAILURE in 2m 25s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/40c2c624bd7a4b6ba4e16411f9a80065) : SUCCESS in 2m 10s
Author
Contributor

rebased onto 6428f8f772

rebased onto 6428f8f7720dbc204a6515e540cea2bd840283c2
First-time contributor

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/fe78e36617fd4b15b20d01c90f8dbf8c

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/fe78e36617fd4b15b20d01c90f8dbf8c - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/1008fe38aa4c4488a8fccd202a4d2121) : FAILURE in 2m 32s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/0e16ebcfc4ae4a9fa832d8d04998237b) : SUCCESS in 2m 19s
Author
Contributor

The zuul failure seems to be unrelated to the change

The zuul failure seems to be unrelated to the change
Contributor

@adamwill you setup the previous thing, does this look reasonable? (using a dropin instead of the main timer which gets overriden on upgrade)

@adamwill you setup the previous thing, does this look reasonable? (using a dropin instead of the main timer which gets overriden on upgrade)
Owner

I am never 100% confident that you can use variables defined just one line up.

I am never 100% confident that you can use variables defined just one line up.
Owner

LGTM, but +1 for Adam's review.

LGTM, but +1 for Adam's review.
Author
Contributor

Me neither. I know they can be defined on the same level as tasks: but I didn't want to change the whole file

Me neither. I know they can be defined on the same level as `tasks:` but I didn't want to change the whole file
Contributor

yeah. In theory I'm fine with it, in practice I can't predict if it'll actually work. But we could merge it and run it on stg and see if it does the right thing. er, if this exists in stg? I forget.

yeah. In theory I'm fine with it, in practice I can't predict if it'll actually work. But we could merge it and run it on stg and see if it does the right thing. er, if this exists in stg? I forget.
Author
Contributor

For Copr servers, we have this even on stage, so I can test it on our stuff without a problem. But yea, it would be good if you could try this as well.

For Copr servers, we have this even on stage, so I can test it on our stuff without a problem. But yea, it would be good if you could try this as well.
Contributor

yes, it's enabled for everything with the base role, including stg.

yes, it's enabled for everything with the base role, including stg.
Owner

I vote for "us" (copr) merging this && testing in copr stage || bug-fix || revert. There's a high chance that this will work for everyone, if it works for Copr.

I vote for "us" (copr) merging this && testing in copr stage || bug-fix || revert. There's a high chance that this will work for everyone, if it works for Copr.
Author
Contributor

rebased onto 3602ac8f97

rebased onto 3602ac8f9789554dcb40284423e9786d9de82033
Author
Contributor

Pull-Request has been merged by frostyx

Pull-Request has been merged by frostyx
First-time contributor

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/eab6f8ddbd7647f58fba8f7dce7a7e69

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/eab6f8ddbd7647f58fba8f7dce7a7e69 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/17d93cedc7f64bf897a058f296cd4ccf) : FAILURE in 2m 58s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/2aa1eed15e7b4e5ebf0fa3c64b22a80b) : SUCCESS in 2m 37s
Author
Contributor

Tested on copr-be-dev and it seem to work:

● dnf5-automatic.timer - dnf-automatic timer
     Loaded: loaded (/usr/lib/systemd/system/dnf5-automatic.timer; enabled; preset: disabled)
    Drop-In: /etc/systemd/system/dnf5-automatic.timer.d
             └─weekdays.conf
     Active: active (waiting) since Sat 2024-11-30 23:26:11 UTC; 2 months 14 days ago
 Invocation: 8c658adeb8544164b9c644a442646d8d
    Trigger: Mon 2025-02-17 06:24:07 UTC; 2 days left
   Triggers: ● dnf5-automatic.service

(the drop-in file is mentioned and next trigger is on monday)

Tested on copr-be-dev and it seem to work: ``` ● dnf5-automatic.timer - dnf-automatic timer Loaded: loaded (/usr/lib/systemd/system/dnf5-automatic.timer; enabled; preset: disabled) Drop-In: /etc/systemd/system/dnf5-automatic.timer.d └─weekdays.conf Active: active (waiting) since Sat 2024-11-30 23:26:11 UTC; 2 months 14 days ago Invocation: 8c658adeb8544164b9c644a442646d8d Trigger: Mon 2025-02-17 06:24:07 UTC; 2 days left Triggers: ● dnf5-automatic.service ``` (the drop-in file is mentioned and next trigger is on monday)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Infrastructure/ansible#2469
No description provided.