Tweak coreos block in greenwave config to avoid newline issues

adamwill commented

2025-02-07 21:00:22 +00:00

Contributor

Well, I hope, anyway. This is a nightmare to predict/test because
jinja is weird and ansible puts it in a weird non-standard mode.
But this does the same thing as the product_versions macro we
use for all other releases - just leave out all attempts to avoid
blank lines.

It might cause blank lines in some states, but I think I found
(while testing product_versions) that blank lines don't break the
parsing. I can't find anywhere in the YAML spec where it actually
defines when a block sequence ends, but as a matter of fact it
seems like whatever parser is being used here doesn't choke on
blank lines.

My ideal goal here is that, whatever entries are present or
absent based on the conditionals, we get a clean block sequence
with each entry on its own line and no blank lines, but this
seems to be incredibly hard to get jinja to do.

Signed-off-by: Adam Williamson awilliam@redhat.com

Well, I hope, anyway. This is a nightmare to predict/test because jinja is weird and ansible puts it in a weird non-standard mode. But this does the same thing as the product_versions macro we use for all other releases - just leave out all attempts to avoid blank lines. It *might* cause blank lines in some states, but I *think* I found (while testing product_versions) that blank lines don't break the parsing. I can't find anywhere in the YAML spec where it actually defines when a block sequence *ends*, but as a matter of fact it seems like whatever parser is being used here doesn't choke on blank lines. My ideal goal here is that, whatever entries are present or absent based on the conditionals, we get a clean block sequence with each entry on its own line and no blank lines, but this seems to be *incredibly* hard to get jinja to do. Signed-off-by: Adam Williamson <awilliam@redhat.com>

adamwill commented

2025-02-07 21:00:55 +00:00

Author

Contributor

@kevin shall we try this on stg and see what rendering we get, and how greenwave parses it?

zuul commented

2025-02-07 21:03:04 +00:00

First-time contributor

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/0728ef6856354c6d85dcdc0db6430922

fi-ansible-lint-diff : SUCCESS in 2m 21s
fi-yamllint-diff : SUCCESS in 2m 08s

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/0728ef6856354c6d85dcdc0db6430922 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/057ed100bf89419db127a8e1bdbbc6bf) : SUCCESS in 2m 21s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/05ace6e25e4047899a43c4b04b8bd574) : SUCCESS in 2m 08s

adamwill commented

2025-02-13 01:04:03 +00:00

Author

Contributor

rebased onto 09418d9216

rebased onto 09418d921641188ede0269bb9e860c395285e4f6

zuul commented

2025-02-13 01:06:32 +00:00

First-time contributor

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/1288da88b1f942368f5ce4f844740eb2

fi-ansible-lint-diff : SUCCESS in 2m 13s
fi-yamllint-diff : SUCCESS in 2m 00s

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/1288da88b1f942368f5ce4f844740eb2 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/6446a485123a4063849d407470d294c3) : SUCCESS in 2m 13s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/7ed17fd6c0c542c8b5908a14420b2e29) : SUCCESS in 2m 00s

adamwill commented

2025-02-13 01:07:39 +00:00

Author

Contributor

let's do that...