Infrastructure/ansible
5
0
Fork 0
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

[Waiting for fedmsg EOL] Sunset github2fedmsg and fedmsg #2454

Merged
ryanlerch merged 1 commit from fedmsg_sunset into main 2025-02-13 10:09:41 +00:00
Conversation 26 Commits 1 Files changed 199 +17 -11255
zlopez commented 2025-02-04 14:29:51 +00:00
Contributor
Copy link

This commit is removing all the fedmsg related stuff from ansible
repository.

Signed-off-by: Michal Konecny mkonecny@redhat.com

This commit is removing all the fedmsg related stuff from ansible repository. Signed-off-by: Michal Konecny <mkonecny@redhat.com>
zuul commented 2025-02-04 14:30:00 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2454,8294feeac7bf5691d5a41b6c6f682f3c9c54890d

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2454,8294feeac7bf5691d5a41b6c6f682f3c9c54890d
zlopez commented 2025-02-04 14:35:30 +00:00
Author
Contributor
Copy link

rebased onto 04bc8ed4d2

rebased onto 04bc8ed4d213447964d3228d79f9e6131b267777
zuul commented 2025-02-04 14:35:38 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2454,62d294d4d6fbe1aaf707593e88bd86c5654b6e47

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2454,62d294d4d6fbe1aaf707593e88bd86c5654b6e47
zlopez commented 2025-02-04 14:40:18 +00:00
Author
Contributor
Copy link

Strange, there is no conflict anymore, but zuul is still unable to merge it for testing :/

@kevin @abompard Could you check this PR? Hopefully I wasn't too overzealous when removing the fedmsg from ansible.

Strange, there is no conflict anymore, but zuul is still unable to merge it for testing :/ @kevin @abompard Could you check this PR? Hopefully I wasn't too overzealous when removing the fedmsg from ansible.
kevin commented 2025-02-04 22:59:09 +00:00
Contributor
Copy link

A pretty massive pr. ;)

I skimmed it and it all seemed pretty reasonable.

I think we can delete playbooks/manual/upgrade/packages.yml entirely. also roles/packages3/ I think.

We should confirm that pagure has no need for gitolite3 anymore. I don't think it does, but we should make sure.

A pretty massive pr. ;) I skimmed it and it all seemed pretty reasonable. I think we can delete playbooks/manual/upgrade/packages.yml entirely. also roles/packages3/ I think. We should confirm that pagure has no need for gitolite3 anymore. I don't think it does, but we should make sure.
zlopez commented 2025-02-05 08:21:54 +00:00
Author
Contributor
Copy link

@kevin I will update the PR to remove playbooks/manual/upgrade/packages.yml as well. Only place I needed to remove gitolite role from was playbooks/manual/upgrade/pkgs.yml and that only used the gitolite/check_fedmsg_hooks. It seems that pagure doesn't need it for anything.

@kevin I will update the PR to remove playbooks/manual/upgrade/packages.yml as well. Only place I needed to remove gitolite role from was playbooks/manual/upgrade/pkgs.yml and that only used the `gitolite/check_fedmsg_hooks`. It seems that pagure doesn't need it for anything.
zlopez commented 2025-02-05 08:22:45 +00:00
Author
Contributor
Copy link

rebased onto 7880b13991

rebased onto 7880b13991967051819896381c0f5f5935d5353a
zuul commented 2025-02-05 08:22:52 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2454,2e3f9bb2a042c556edf98bcf1ae6421a0c77d115

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2454,2e3f9bb2a042c556edf98bcf1ae6421a0c77d115
zlopez commented 2025-02-05 08:29:25 +00:00
Author
Contributor
Copy link

rebased onto 7880b13991

rebased onto 7880b13991967051819896381c0f5f5935d5353a
zuul commented 2025-02-05 08:29:32 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2454,2d8fd26ab3b75a18270b304cc9541e831e5412ea

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2454,2d8fd26ab3b75a18270b304cc9541e831e5412ea
zlopez commented 2025-02-05 08:46:41 +00:00
Author
Contributor
Copy link

rebased onto 7880b13991

rebased onto 7880b13991967051819896381c0f5f5935d5353a
zlopez commented 2025-02-05 08:47:08 +00:00
Author
Contributor
Copy link

Removed also monitori-dashboard as part of this PR.

Removed also monitori-dashboard as part of this PR.
zuul commented 2025-02-05 08:51:42 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/a1e7694b7c684733a1f6f28a5e05ce95

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/a1e7694b7c684733a1f6f28a5e05ce95 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/32f25311bd264118885f18a49e86f2f1) : FAILURE in 4m 41s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/dbf36830f4de4e88848dff59371fd1d5) : SUCCESS in 3m 26s
nphilipp commented 2025-02-05 09:59:38 +00:00
Owner
Copy link

This removes the dead csi_* vars, too (e.g. inventory/host_vars/bodhi-backend01.iad2.fedoraproject.org). Do you want to keep this together or split into separate commits?

I see some stuff being removed which I don’t understand:

  • This removes something about bugz.fp.o from playbooks/include/proxies-redirects.yml. Intentional?
  • Some seemingly unrelated playbooks and roles are removed completely:
    • playbooks/manual/upgrade/packages.yml
    • playbooks/openshift-apps/monitor_dashboard.yml
    • roles/gitolite/base/tasks/main.yml
    • roles/openshift-apps/monitor-dashboard/*
    • roles/packages3/bugz.fp.o/* (see above)
    • roles/packages3/web/*
This removes the dead `csi_*` vars, too (e.g. `inventory/host_vars/bodhi-backend01.iad2.fedoraproject.org`). Do you want to keep this together or split into separate commits? I see some stuff being removed which I don’t understand: * This removes something about `bugz.fp.o` from `playbooks/include/proxies-redirects.yml`. Intentional? * Some seemingly unrelated playbooks and roles are removed completely: * `playbooks/manual/upgrade/packages.yml` * `playbooks/openshift-apps/monitor_dashboard.yml` * `roles/gitolite/base/tasks/main.yml` * `roles/openshift-apps/monitor-dashboard/*` * `roles/packages3/bugz.fp.o/*` (see above) * `roles/packages3/web/*`
zlopez commented 2025-02-05 10:07:09 +00:00
Author
Contributor
Copy link

This removes the dead csi_* vars, too (e.g. inventory/host_vars/bodhi-backend01.iad2.fedoraproject.org). Do you want to keep this together or split into separate commits?

I can remove them from this commit, it was just too close to fedmsg that I just removed them as well as CSI is no longer a thing.

I see some stuff being removed which I don’t understand:

  • This removes something about bugz.fp.o from playbooks/include/proxies-redirects.yml. Intentional?

That is because of the removal of packages3 role.

  • Some seemingly unrelated playbooks and roles are removed completely:
  • playbooks/manual/upgrade/packages.yml

That was mentioned by @kevin to remove as it's no longer needed and it was related to packages3 role.

  • playbooks/openshift-apps/monitor_dashboard.yml

That one was too tied to fedmsg and I got confirmation that it should be removed anyway.

  • roles/gitolite/base/tasks/main.yml

Another one that had plenty of fedmsg references and got confirmed that it should be removed.

  • roles/openshift-apps/monitor-dashboard/*

Just the role for monitor-dashboard playbook.

  • roles/packages3/bugz.fp.o/* (see above)

Too tied to fedmsg and got confirmation that it could be deleted completelly.

  • roles/packages3/web/*

Same as above.

> This removes the dead `csi_*` vars, too (e.g. `inventory/host_vars/bodhi-backend01.iad2.fedoraproject.org`). Do you want to keep this together or split into separate commits? I can remove them from this commit, it was just too close to fedmsg that I just removed them as well as CSI is no longer a thing. > > I see some stuff being removed which I don’t understand: > > * This removes something about `bugz.fp.o` from `playbooks/include/proxies-redirects.yml`. Intentional? That is because of the removal of packages3 role. > * Some seemingly unrelated playbooks and roles are removed completely: > * `playbooks/manual/upgrade/packages.yml` That was mentioned by @kevin to remove as it's no longer needed and it was related to packages3 role. > * `playbooks/openshift-apps/monitor_dashboard.yml` That one was too tied to fedmsg and I got confirmation that it should be removed anyway. > * `roles/gitolite/base/tasks/main.yml` Another one that had plenty of fedmsg references and got confirmed that it should be removed. > * `roles/openshift-apps/monitor-dashboard/*` Just the role for monitor-dashboard playbook. > * `roles/packages3/bugz.fp.o/*` (see above) Too tied to fedmsg and got confirmation that it could be deleted completelly. > * `roles/packages3/web/*` Same as above.
kevin commented 2025-02-05 21:50:24 +00:00
Contributor
Copy link

Oh, my mistake. We do want to keep roles/packages3/bugz.fp.o/ just drop roles/packages3/web

Oh, my mistake. We do want to keep roles/packages3/bugz.fp.o/ just drop roles/packages3/web
zlopez commented 2025-02-06 09:12:50 +00:00
Author
Contributor
Copy link

rebased onto 0a0713ecb4

rebased onto 0a0713ecb44c04600b9feee97c0c9c68aca1f281
zuul commented 2025-02-06 09:17:18 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/0842c02a04304158b43ecbeed9987048

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/0842c02a04304158b43ecbeed9987048 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/33e91add260640de8778503fe950a177) : FAILURE in 4m 11s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/8969f1c0e9374d119b9498e8641fb8b9) : SUCCESS in 3m 18s
zlopez commented 2025-02-06 09:18:03 +00:00
Author
Contributor
Copy link

Removed roles/packages3/bugz.fp.o and the change in playbooks/include/proxies-redirects.yaml from the PR.

Removed `roles/packages3/bugz.fp.o` and the change in `playbooks/include/proxies-redirects.yaml` from the PR.
zlopez commented 2025-02-06 09:19:08 +00:00
Author
Contributor
Copy link

Zuul is working again :-)

Zuul is working again :-)
zlopez commented 2025-02-12 10:03:05 +00:00
Author
Contributor
Copy link

rebased onto cdb7471dfe

rebased onto cdb7471dfe2b9827dcea8d0a4c1d8e6339474f3e
zuul commented 2025-02-12 10:08:16 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/b54bdd461c304d10bcb65822370a88d0

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/b54bdd461c304d10bcb65822370a88d0 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/e5773a8ff86949328a79139941b68fb0) : FAILURE in 4m 20s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/fb3b808c51324872b47427115f240b3f) : SUCCESS in 3m 22s
zlopez commented 2025-02-13 10:08:59 +00:00
Author
Contributor
Copy link

rebased onto 2f5ee2da64

rebased onto 2f5ee2da6456a7988bb4274b632a505299638ac5
zlopez commented 2025-02-13 10:09:08 +00:00
Author
Contributor
Copy link

rebased onto 2f5ee2da64

rebased onto 2f5ee2da6456a7988bb4274b632a505299638ac5
zlopez commented 2025-02-13 10:09:42 +00:00
Author
Contributor
Copy link

Pull-Request has been merged by zlopez

Pull-Request has been merged by zlopez
zuul commented 2025-02-13 10:13:38 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/24a85c06c3ad40f7831c6276d99aed72

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/24a85c06c3ad40f7831c6276d99aed72 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/f4ca38d935754b4583879feb1a2b44a4) : FAILURE in 4m 19s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/a745f0a6d9664d71bb9a0b451dde1a83) : SUCCESS in 3m 24s
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
freeze-break-request

   
post-freeze
No labels
freeze-break-request
post-freeze
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Infrastructure/ansible#2454
No description provided.
Delete branch "fedmsg_sunset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?