Infrastructure/ansible
5
0
Fork 0
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

motd generic template added #2418

Merged
ryanlerch merged 1 commit from motd into main 2025-01-28 01:31:29 +00:00
Conversation 69 Commits 1 Files changed 112 +370 -562
thisisyaash commented 2025-01-06 08:01:25 +00:00
Contributor
Copy link
  • Added motd.j2 under roles/base.
  • templates/system_identification still references about CSI stuffs in the last 2 lines (let me know what should I update it with?)
- Added `motd.j2` under `roles/base`. - `templates/system_identification` still references about CSI stuffs in the last 2 lines (*let me know what should I update it with?*)
zuul commented 2025-01-06 08:04:27 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/737b1f55fc3743f1956301ce68c7af00

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/737b1f55fc3743f1956301ce68c7af00 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/7b0dd757f83e4f4491e017bd50291486) : SUCCESS in 2m 44s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/dbb1a4ff2f494cb4af858b15a13c131d) : SUCCESS in 1m 56s
kevin commented 2025-01-06 18:21:30 +00:00
Contributor
Copy link

So yeah, those 2 bottom lines are going to be the tricky/time consuming part.

Currently it gets those from the hosts repo (which we want to retire). So, ideally we would look at the hosts repo, ignore anything that is 'phx2' (thats our old datacenter), and copy the notes for each host that is still a valid host into ansible/inventory/host_vars/hosname as a 'notes: ' variable. Or perhaps it would be better as 'motd_notes: '.

The system_identification.j2 template in the hosts repo is a bit of discussion point, we don't want to point to CSI or use it's stuff, but there's still possibly useful things there. I guess for now, I'd say drop all the variables that are csi_* and so keep, freezes, and env.

So, Could you make a small script that does that and then add the changes to this PR?
Let me know if that does or does not make sense. ;)

So yeah, those 2 bottom lines are going to be the tricky/time consuming part. Currently it gets those from the hosts repo (which we want to retire). So, ideally we would look at the hosts repo, ignore anything that is 'phx2' (thats our old datacenter), and copy the notes for each host that is still a valid host into ansible/inventory/host_vars/hosname as a 'notes: ' variable. Or perhaps it would be better as 'motd_notes: '. The system_identification.j2 template in the hosts repo is a bit of discussion point, we don't want to point to CSI or use it's stuff, but there's still possibly useful things there. I guess for now, I'd say drop all the variables that are csi_* and so keep, freezes, and env. So, Could you make a small script that does that and then add the changes to this PR? Let me know if that does or does not make sense. ;)
thisisyaash commented 2025-01-07 06:32:23 +00:00
Author
Contributor
Copy link

Currently it gets those from the hosts repo (which we want to retire). So, ideally we would look at the hosts repo, ignore anything that is 'phx2' (thats our old datacenter), and copy the notes for each host that is still a valid host into ansible/inventory/host_vars/hosname as a 'notes: ' variable. Or perhaps it would be better as 'motd_notes: '.

so, I should create a script that lists the directory that are not phx2 from infra/hosts And compares the directories with ansible/inventory/host_vars, if the dir matches, create a variable named motd_notes in yaml files, write the notes content into it and save it. do it for each hostnames that is valid and matches with host_vars.

The system_identification.j2 template in the hosts repo is a bit of discussion point, we don't want to point to CSI or use it's stuff, but there's still possibly useful things there. I guess for now, I'd say drop all the variables that are csi_* and so keep, freezes, and env.

okay, I'll drop any CSI* related stuffs from the file and keep the freeze, env...and so on.

am I correct?

> Currently it gets those from the hosts repo (which we want to retire). So, ideally we would look at the hosts repo, ignore anything that is 'phx2' (thats our old datacenter), and copy the notes for each host that is still a valid host into ansible/inventory/host_vars/hosname as a 'notes: ' variable. Or perhaps it would be better as 'motd_notes: '. so, I should create a script that lists the directory that are not `phx2` from **`infra/hosts`** And compares the directories with **`ansible/inventory/host_vars`**, if the dir matches, create a variable named `motd_notes` in yaml files, write the notes content into it and save it. do it for each hostnames that is valid and matches with `host_vars`. > The system_identification.j2 template in the hosts repo is a bit of discussion point, we don't want to point to CSI or use it's stuff, but there's still possibly useful things there. I guess for now, I'd say drop all the variables that are csi_* and so keep, freezes, and env. okay, I'll drop any CSI* related stuffs from the file and keep the `freeze`, `env`...and so on. am I correct?
thisisyaash commented 2025-01-07 07:16:44 +00:00
Author
Contributor
Copy link

Is it okay to write the path that is
/srv/infra/hosts/* to access the files from ansible repo in the script?

Or is there any other way to mention the path of dir? (vars, alias.....anything?) rather than mentioning the absolute path?

Is it okay to write the path that is `/srv/infra/hosts/*` to access the files from `ansible` repo in the script? Or is there any other way to mention the path of dir? (vars, alias.....anything?) rather than mentioning the absolute path?
kevin commented 2025-01-08 01:19:27 +00:00
Contributor
Copy link

Nope, we don't want to refer to hosts repo at all in the end...

I was suggesting a one-off script to move things from hosts to ansible repo... ie, just create a script to do the work, and add the changes here (we don't need the script after that, it's just run once).

Does that make sense?

Nope, we don't want to refer to hosts repo at all in the end... I was suggesting a one-off script to move things from hosts to ansible repo... ie, just create a script to do the work, and add the changes here (we don't need the script after that, it's just run once). Does that make sense?
thisisyaash commented 2025-01-08 04:02:25 +00:00
Author
Contributor
Copy link

um...how do i specify the location of the hosts directory?

I understand it's a "one-time use" script, but the "hosts" located in a different directory right, how can this script access the directory that is outside of it's own location?

we're basically moving things from infra/hosts/(match+valid hostnames) to anisble/inventory/host_vars/(match+valid hostname) correct?

the script can access the elements from this repo, but how does it access a directory that is outside the repo?

i have mostly used scripts for local machine tasks, so im not familiar with executing scripts between servers, please correct me if im on the wrong side :)

um...how do i specify the location of the `hosts` directory? I understand it's a "one-time use" script, but the "`hosts`" located in a different directory right, how can this script access the directory that is outside of it's own location? we're basically moving things from `infra/hosts/(match+valid hostnames)` to `anisble/inventory/host_vars/(match+valid hostname)` correct? the script can access the elements from this repo, but how does it access a directory that is outside the repo? > i have mostly used scripts for local machine tasks, so im not familiar with executing scripts between servers, please correct me if im on the wrong side :)
kevin commented 2025-01-08 17:21:18 +00:00
Contributor
Copy link

The one-time script doesn't need to be added to ansible repo at all. You can make it in your homedir on batcave01 and just refer to /srv/web/infra/hosts/ directory directly... then the output you can copy down locally and add to the pr?

I'm probibly not explaining things well... sorry for any confusion...

The one-time script doesn't need to be added to ansible repo at all. You can make it in your homedir on batcave01 and just refer to /srv/web/infra/hosts/ directory directly... then the output you can copy down locally and add to the pr? I'm probibly not explaining things well... sorry for any confusion...
thisisyaash commented 2025-01-10 03:53:02 +00:00
Author
Contributor
Copy link

oh, thanks for explaining that :D

so, I'll create a script that compares the dirnames from ansible/inventory/host_vars to infra/hosts(!phx2)
only the valid directory's "notes" will be copied into my home directory.

at last, I'll create a variable named "motd_notes" under each valid hostname's yaml file and add the notes content there.
Then I'll make a PR.

did I get that right?

oh, thanks for explaining that :D so, I'll create a script that compares the dirnames from `ansible/inventory/host_vars` to `infra/hosts`(!phx2) only the valid directory's "notes" will be copied into my home directory. at last, I'll create a variable named "motd_notes" under each valid hostname's yaml file and add the notes content there. Then I'll make a PR. did I get that right?
thisisyaash commented 2025-01-11 06:18:44 +00:00
Author
Contributor
Copy link

um...I didn't used any scripts, it seems a bit complex for me, idk how to do it on servers.

So I ended up doing the tasks manually,

  1. so far I was only able to copy 2 notes from infra/hosts
	modified:   ibiblio02.fedoraproject.org
	modified:   noc02.fedoraproject.org

only these 2 hosts have contents that can copied

  1. Other matched + valid hostnames have this: (so I din't bother copying them)
********      
No notes found for this server! Please add some in the infra-hosts repository  
********

is that okay, can I make a PR for that?

um...I didn't used any scripts, it seems a bit complex for me, idk how to do it on servers. So I ended up doing the tasks manually, 1. so far I was only able to copy 2 notes from `infra/hosts` ``` modified: ibiblio02.fedoraproject.org modified: noc02.fedoraproject.org ``` *only these 2 hosts have contents that can copied* 2. Other matched + valid hostnames have this: (so I din't bother copying them) ``` ******** No notes found for this server! Please add some in the infra-hosts repository ******** ``` is that okay, can I make a PR for that?
thisisyaash commented 2025-01-11 06:46:35 +00:00
Author
Contributor
Copy link

matched + valid hostnames with no contents in notes:

  • download-ib01.fedoraproject.org
  • ns02.fedoraproject.org
  • ns05.fedoraproject.org
  • osuosl01.fedoraproject.org
  • osuosl02.fedoraproject.org
  • pagure-stg01.fedoraproject.org
  • proxy02.fedoraproject.org
  • proxy03.fedoraproject.org
  • proxy04.fedoraproject.org
  • proxy05.fedoraproject.org
  • proxy06.fedoraproject.org
  • proxy07.fedoraproject.org
  • proxy09.fedoraproject.org
    (count: 13)
    these hostnames contains either the "No notes found.." text or no notes file found in them.

matched + valid hostnames with contents in notes:

  • ibiblio02.fedoraproject.org
  • noc02.fedoraproject.org

so out of 169 hostnames from infra/hosts only 2 hostnames have notes contents that can be copied to the "matched" hostnames in ansible/inventory/host_vars.

**matched + valid hostnames with no contents in `notes`**: - download-ib01.fedoraproject.org - ns02.fedoraproject.org - ns05.fedoraproject.org - osuosl01.fedoraproject.org - osuosl02.fedoraproject.org - pagure-stg01.fedoraproject.org - proxy02.fedoraproject.org - proxy03.fedoraproject.org - proxy04.fedoraproject.org - proxy05.fedoraproject.org - proxy06.fedoraproject.org - proxy07.fedoraproject.org - proxy09.fedoraproject.org (count: 13) *these hostnames contains either the "No notes found.." text or no `notes` file found in them.* --- **matched + valid hostnames with contents in `notes`**: - ibiblio02.fedoraproject.org - noc02.fedoraproject.org so out of 169 hostnames from `infra/hosts` only 2 hostnames have `notes` contents that can be copied to the "matched" hostnames in `ansible/inventory/host_vars`.
thisisyaash commented 2025-01-11 08:55:39 +00:00
Author
Contributor
Copy link

1 new commit added

  • migrated notes from infra/hosts
**1 new commit added** * ``migrated notes from infra/hosts``
zuul commented 2025-01-11 08:58:19 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/ec61c7b2e40f4ba19671759740cbc756

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/ec61c7b2e40f4ba19671759740cbc756 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/cefa0e9897c543bb8d5b1bf422111702) : SUCCESS in 2m 24s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/f0a8c802535d4f95931f65e6ed3e4ff3) : SUCCESS in 2m 13s
kevin commented 2025-01-13 18:00:13 +00:00
Contributor
Copy link

Wow. I thought there would be more. ;)

I guess that shows how out of date that hosts repo is. ;)

So, next steps then:

The roles/base/motd.j2 you have here needs adjsted to work in the base role.
The includes need adjusted. You can drop the system_identification include, since thats all the CSI stuff we arent including.

Theres a few things from the old system_identification template that aren't CSI that we could also include:

Environment: {{env}}
Freezes: {{freezes}}

There's also a bunch of csi_ variables in group vars in ansible. Perhaps we could delete those and perhaps rename some. I think the csi_propose could perhaps just be converted into notes: ?
and the rest deleted.

Let me know if that makes sense... and sorry for the delay getting back to you.
The notes are no longer including a file, but using a variable, so you probibly want something like:

{{ hostvars[inventory_hostname][notes] }}

Wow. I thought there would be more. ;) I guess that shows how out of date that hosts repo is. ;) So, next steps then: The roles/base/motd.j2 you have here needs adjsted to work in the base role. The includes need adjusted. You can drop the system_identification include, since thats all the CSI stuff we arent including. Theres a few things from the old system_identification template that aren't CSI that we could also include: Environment: {{env}} Freezes: {{freezes}} There's also a bunch of csi_ variables in group vars in ansible. Perhaps we could delete those and perhaps rename some. I think the csi_propose could perhaps just be converted into notes: ? and the rest deleted. Let me know if that makes sense... and sorry for the delay getting back to you. The notes are no longer including a file, but using a variable, so you probibly want something like: {{ hostvars[inventory_hostname][notes] }}
thisisyaash commented 2025-01-14 06:04:47 +00:00
Author
Contributor
Copy link

The includes need adjusted. You can drop the system_identification include, since thats all the CSI stuff we arent including.
Theres a few things from the old system_identification template that aren't CSI that we could also include:
Environment: {{env}}
Freezes: {{freezes}}

okay, so I will remove the "include" for the "system_identification"

{% include 'templates/system_identification' %}

and replace it with the variables {env} & {freezes}

Environment: {{env}}
Freezes: {{freezes}}

There's also a bunch of csi_ variables in group vars in ansible. Perhaps we could delete those and perhaps rename some. I think the csi_propose could perhaps just be converted into notes: ?
and the rest deleted.
yeah that makes sense!

I mostly see these 4 variables in the inventory group_vars:

csi_primary_contact: ...
csi_purpose: ...
csi_relationship: ...
csi_security_category: ...

I can't find any csi_propose variable, so I assume you meant the csi_purpose.

so I will delete these vars:

  • csi_primary_contact
  • csi_relationship
  • `csi_security_category

then I'll convert the csi_purpose into notes for the respective group var?

> The includes need adjusted. You can drop the system_identification include, since thats all the CSI stuff we arent including. Theres a few things from the old system_identification template that aren't CSI that we could also include: Environment: {{env}} Freezes: {{freezes}} okay, so I will remove the "include" for the "`system_identification`" ```j2 {% include 'templates/system_identification' %} ``` and replace it with the variables `{env} & {freezes}` ```j2 Environment: {{env}} Freezes: {{freezes}} ``` --- > There's also a bunch of csi_ variables in group vars in ansible. Perhaps we could delete those and perhaps rename some. I think the csi_propose could perhaps just be converted into notes: ? and the rest deleted. yeah that makes sense! I mostly see these 4 variables in the inventory group_vars: ```j2 csi_primary_contact: ... csi_purpose: ... csi_relationship: ... csi_security_category: ... ``` > I can't find any **`csi_propose`** variable, so I assume you meant the **`csi_purpose`**. so I will delete these vars: - `csi_primary_contact` - `csi_relationship` - `csi_security_category then I'll convert the `csi_purpose` into `notes` for the respective group var?
thisisyaash commented 2025-01-14 07:20:52 +00:00
Author
Contributor
Copy link

so I was deleting the all the other vars except csi_purpose
I think we can also make "notes" for csi_relationship as well?

that var explains some stuffs related to group_var...idk
should we just keep only the csi_purpose to provide context about what's happening?
or we can keep both csi_purpose & csi_relationship with the context & explanation as well?

csi_primary_contact: mote admins - sysadmin-mote-members@fedoraproject.org
csi_purpose: Hosts services which help facilitate communication over IRC and related mediums.
csi_relationship: |
  There are a couple things running here.

  * zodbot, a supybot instance.  See the zodbot SOP for more info.
  * fedmsg-irc, our fedmsg to IRC relay.  'journalctl -u fedmsg-irc'
  * mote, a webapp running behind httpd that serves meetbot log files.
# For the MOTD
csi_security_category: Moderate
so I was deleting the all the other vars except `csi_purpose` I think we can also make "notes" for `csi_relationship` as well? that var explains some stuffs related to group_var...idk should we just keep only the `csi_purpose` to provide context about what's happening? or we can keep both `csi_purpose` & `csi_relationship` with the context & explanation as well? ```j2 csi_primary_contact: mote admins - sysadmin-mote-members@fedoraproject.org csi_purpose: Hosts services which help facilitate communication over IRC and related mediums. csi_relationship: | There are a couple things running here. * zodbot, a supybot instance. See the zodbot SOP for more info. * fedmsg-irc, our fedmsg to IRC relay. 'journalctl -u fedmsg-irc' * mote, a webapp running behind httpd that serves meetbot log files. # For the MOTD csi_security_category: Moderate ```
kevin commented 2025-01-14 21:57:53 +00:00
Contributor
Copy link

Yes, that was exactly right. ;)

Hum... I suppose we could merge csi_relationship and csi_purpose into notes. We can always adjust notes afterwards. So sure...

Yes, that was exactly right. ;) Hum... I suppose we could merge csi_relationship and csi_purpose into notes. We can always adjust notes afterwards. So sure...
thisisyaash commented 2025-01-15 06:24:58 +00:00
Author
Contributor
Copy link

2 new commits added

  • removed csi_* vars from group_vars; converted csi_purpose & csi_responsibility into notes
  • motd changes; excluding CSI infos
**2 new commits added** * ``removed csi_* vars from group_vars; converted csi_purpose & csi_responsibility into notes`` * ``motd changes; excluding CSI infos``
zuul commented 2025-01-15 06:25:27 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/2cc9b1337fae4ba9872873fc66cd73e8

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/2cc9b1337fae4ba9872873fc66cd73e8 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/621b1e56a32c41529b4a4683d98770a6) : MERGE_CONFLICT in 1s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/99a783f7505948579b953080fc18f12b) : MERGE_CONFLICT in 1s
thisisyaash commented 2025-01-15 06:29:01 +00:00
Author
Contributor
Copy link

4 new commits added

  • removed csi_* vars from group_vars; converted csi_purpose & csi_relationship into notes
  • motd changes; excluding CSI infos
  • migrated notes from infra/hosts
  • motd generic template added
**4 new commits added** * ``removed csi_* vars from group_vars; converted csi_purpose & csi_relationship into notes`` * ``motd changes; excluding CSI infos`` * ``migrated notes from infra/hosts`` * ``motd generic template added``
zuul commented 2025-01-15 06:29:07 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2418,3dea3697de5f4e58248ea1fb8ae3eb35f9350506

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2418,3dea3697de5f4e58248ea1fb8ae3eb35f9350506
thisisyaash commented 2025-01-15 06:34:53 +00:00
Author
Contributor
Copy link
  1. is it bcz i have older branch? or...
  2. I messed up making changes?

the current branch im working on is like 8 days old...should i pull the upstream and rebase...then push the changes?

also made typo while entering commit msgs, so i amended and pushed it again? is it not okay?

1. is it bcz i have older branch? or... 2. I messed up making changes? the current branch im working on is like 8 days old...should i pull the upstream and rebase...then push the changes? > also made typo while entering commit msgs, so i amended and pushed it again? is it not okay?
thisisyaash commented 2025-01-15 07:50:24 +00:00
Author
Contributor
Copy link

rebased onto 47c68f478d

rebased onto 47c68f478d035b19d81809f1f15d9998b532b215
zuul commented 2025-01-15 07:50:34 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2418,76507df3225bceba862b0f58439e647df27757e0

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2418,76507df3225bceba862b0f58439e647df27757e0
thisisyaash commented 2025-01-15 07:55:55 +00:00
Author
Contributor
Copy link

1 new commit added

  • fixed merge conflicts
**1 new commit added** * ``fixed merge conflicts``
zuul commented 2025-01-15 07:58:34 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/473130fb586444928e42ffb1dce89e38

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/473130fb586444928e42ffb1dce89e38 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/228eac6f4fca41778102fa64c08fe421) : SUCCESS in 2m 22s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/f666aea3c3df48bb8889185eb4fec53c) : SUCCESS in 2m 05s
thisisyaash commented 2025-01-15 08:02:32 +00:00
Author
Contributor
Copy link

phew...at last it works!

actually, there a conflict btw

#local 
volgroup: /dev/vg_virt_buildvm_ppc64le_iscsi
# upstream changes
volgroup: /dev/vg_guests

i updated it by keeping the upstream changes and pushed it!

let me know if this fix is okay, as I have made another commit for that!

phew...at last it works! actually, there a conflict btw ``` #local volgroup: /dev/vg_virt_buildvm_ppc64le_iscsi # upstream changes volgroup: /dev/vg_guests ``` i updated it by keeping the upstream changes and pushed it! *let me know if this fix is okay, as I have made another commit for that!*
kevin commented 2025-01-15 17:46:32 +00:00
Contributor
Copy link

Yep. I changed that after your orig work so thats fine.

Getting really close! :)

2 last things.

Why are two of them 'motd_notes' and not just 'notes' ?

And the motd template has '+ {% include inventory_hostname + '/notes' ignore missing %}' but that wont work as these are not files to be included, but variables... so change to just "{{ notes }}" ?

Yep. I changed that after your orig work so thats fine. Getting really close! :) 2 last things. Why are two of them 'motd_notes' and not just 'notes' ? And the motd template has '+ {% include inventory_hostname + '/notes' ignore missing %}' but that wont work as these are not files to be included, but variables... so change to just "{{ notes }}" ?
thisisyaash commented 2025-01-15 18:56:07 +00:00
Author
Contributor
Copy link

Why are two of them 'motd_notes' and not just 'notes' ?

ah those two....they were copied from the infra/hosts
I cross-checked hostnames from infra/hosts to ansible/inventory/host_vars and copied them manually. so I named them like that...but I'll change it np

as for notes, those were already present inside group_vars under 2 different variable, I just converted two vars into one var (notes) like you said

And the motd template has '+ {% include inventory_hostname + '/notes' ignore missing %}' but that wont work as these are not files to be included, but variables... so change to just "{{ notes }}" ?

alrigth...remove that line and replaced it with Notes: {{ notes}}

> Why are two of them 'motd_notes' and not just 'notes' ? ah those two....they were copied from the `infra/hosts` I cross-checked hostnames from `infra/hosts` to `ansible/inventory/host_vars` and copied them manually. so I named them like that...but I'll change it np as for `notes`, those were already present inside `group_vars` under 2 different variable, I just converted two vars into one var (`notes`) like you said > And the motd template has '+ {% include inventory_hostname + '/notes' ignore missing %}' but that wont work as these are not files to be included, but variables... so change to just "{{ notes }}" ? alrigth...remove that line and replaced it with `Notes: {{ notes}}`
thisisyaash commented 2025-01-15 18:59:57 +00:00
Author
Contributor
Copy link

1 new commit added

  • minor changes; var
**1 new commit added** * ``minor changes; var``
zuul commented 2025-01-15 19:02:35 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/0e6f58d7a35c4e14a14b312686fcbd5b

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/0e6f58d7a35c4e14a14b312686fcbd5b - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/b8d76ec04f734bb6958dc3ee4cbf9501) : SUCCESS in 2m 19s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/d0bf995ffcc84df1ad1c49cac5770de5) : SUCCESS in 2m 14s
kevin commented 2025-01-15 19:24:04 +00:00
Contributor
Copy link

Looks good... and sorry to keep piling things on here, but... one (hopefully last) thing:

Right now, we have a tasks/motd.yml task that uses the old hosts template. Can you drop the:

tasks:

  • import_tasks: "{{ tasks_path }}/motd.yml"

from all the playbooks that use it and replace it with a roles/base/tasks/motd.yml that copies the roles/base/templates/motd.j2 instead of the hosts one?
Then roles/base/tasks/main.yml will need to include motd.yml (just look at the other split out roles there).

Then, I sure hope it will be done. :) Thanks for being so responsive here.

Looks good... and sorry to keep piling things on here, but... one (hopefully last) thing: Right now, we have a tasks/motd.yml task that uses the old hosts template. Can you drop the: tasks: - import_tasks: "{{ tasks_path }}/motd.yml" from all the playbooks that use it and replace it with a roles/base/tasks/motd.yml that copies the roles/base/templates/motd.j2 instead of the hosts one? Then roles/base/tasks/main.yml will need to include motd.yml (just look at the other split out roles there). Then, I sure hope it will be done. :) Thanks for being so responsive here.
thisisyaash commented 2025-01-16 06:06:30 +00:00
Author
Contributor
Copy link

from all the playbooks that use it and replace it with a roles/base/tasks/motd.yml that copies the roles/base/templates/motd.j2 instead of the hosts one?

ah...

  1. there's no motd.yml in tasks/ so I'll create one that copies from roles/base/motd.j2.
  2. currently motd.j2 is in roles/base/motd.j2 should I move it inside templates? like you mentioned?
    (ill move it inside & push the changes, let me know I'll have to move it back :P)

as for the roles/base/template/motd.yml, i essentially followed the same old tasks/motd.yml and just changed the locations....

---
- name: Add motd to system
  ansible.builtin.template: src=/roles/base/templates/motd.j2 dest=/etc/motd

  tags:
    - motd
    - base

i hope dest=/etc/motd is fine

I cant find any motd in /etc/ ;except /etc/motd.d/ which had no files in it!

> from all the playbooks that use it and replace it with a roles/base/tasks/motd.yml that copies the roles/base/templates/motd.j2 instead of the hosts one? ah... 1. there's no `motd.yml` in `tasks/` so I'll create one that copies from `roles/base/motd.j2`. 2. currently `motd.j2` is in `roles/base/motd.j2` should I move it inside `templates`? like you mentioned? (ill move it inside & push the changes, let me know I'll have to move it back :P) as for the `roles/base/template/motd.yml`, i essentially followed the same old `tasks/motd.yml` and just changed the locations.... ``` --- - name: Add motd to system ansible.builtin.template: src=/roles/base/templates/motd.j2 dest=/etc/motd tags: - motd - base ``` i hope `dest=/etc/motd` is fine > I cant find any motd in /etc/ ;except `/etc/motd.d/` which had no files in it!
thisisyaash commented 2025-01-16 06:54:32 +00:00
Author
Contributor
Copy link

so basically....I'll have to replace the "tasks_path" with the actual path of the motd.yml right?

if so...then it would be smthg like this:

tasks:
- import_tasks: "/roles/base/tasks/motd.yml"

am i correct?

or do i have to mention the absolute path of the motd.yml?

perhaps we could create a new variable for that in /vars/global.yml
something like:

motd_path: /srv/web/infra/ansible/roles/base/tasks

also I can see another variable

roles_path: /srv/web/infra/ansible/roles

so I could use it like

tasks:
- import_tasks: "{{ roles_path }}/base/tasks/motd.yml"

is that okay?

so basically....I'll have to replace the "`tasks_path`" with the actual path of the `motd.yml` right? if so...then it would be smthg like this: ``` tasks: - import_tasks: "/roles/base/tasks/motd.yml" ``` am i correct? or do i have to mention the absolute path of the motd.yml? perhaps we could create a new variable for that in `/vars/global.yml` something like: ``` motd_path: /srv/web/infra/ansible/roles/base/tasks ``` also I can see another variable ``` roles_path: /srv/web/infra/ansible/roles ``` so I could use it like ``` tasks: - import_tasks: "{{ roles_path }}/base/tasks/motd.yml" ``` is that okay?
thisisyaash commented 2025-01-16 07:20:52 +00:00
Author
Contributor
Copy link

I updated all the playbooks to go with this location is that okay?

- import_tasks: "{{ roles_path }}/base/tasks/motd.yml"

so far...

  1. created motd.yml in roles/base/tasks and point to roles/base/template/motd.j2
  2. updated the playbooks like you said

hope i did correctly?

also updated the main.yml to include motd.yml
(i saw the other "imports" and essentially followed the same way)

I updated all the playbooks to go with this location is that okay? ``` - import_tasks: "{{ roles_path }}/base/tasks/motd.yml" ``` so far... 1. created `motd.yml` in `roles/base/tasks` and point to `roles/base/template/motd.j2` 2. updated the playbooks like you said hope i did correctly? also updated the `main.yml` to include `motd.yml` (i saw the other "imports" and essentially followed the same way)
thisisyaash commented 2025-01-16 08:17:11 +00:00
Author
Contributor
Copy link

1 new commit added

  • updating YAMLs & playbooks
**1 new commit added** * ``updating YAMLs & playbooks``
zuul commented 2025-01-16 08:28:32 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/5f910ec15d554253b27124c0c2babdc1

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/5f910ec15d554253b27124c0c2babdc1 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/61bf71fb8e2b415ab0513172c10e22b2) : FAILURE in 11m 03s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/31a8addc568e4e5bad10db24f1d49040) : SUCCESS in 7m 33s
thisisyaash commented 2025-01-17 10:35:26 +00:00
Author
Contributor
Copy link

I honestly don't know why it's failing.

So I went back few previous commits, switched to main branch, and it's still not works.
(i may have debugged it incorrerctly, so let me mention what I did)

  1. clicked this link https://fedora.softwarefactory-project.io/zuul/build/61bf71fb8e2b415ab0513172c10e22b2
  2. saw the first error log from playbooks/groups/backup-server.yml'
  3. copied the command that run the ansible-lint
ansible-lint --nocolor playbooks/groups/backup-server.yml
  1. opened my local repo and went back few commits (switched branches too)
  2. run the command
ansible-lint --nocolor playbooks/groups/backup-server.yml

I still ended up getting the same error output...

iamyaash@fedora41:~/Projects/iamyaash/fedora/ansible$ ansible-lint --nocolor playbooks/groups/backup-server.yml
WARNING  Listing 16 violation(s) that are fatal
role-name[path]: Avoid using paths when importing roles. (collectd/base)
playbooks/groups/backup-server.yml:7

role-name[path]: Avoid using paths when importing roles. (ipa/client)
playbooks/groups/backup-server.yml:7

role-name[path]: Avoid using paths when importing roles. (openvpn/client)
playbooks/groups/backup-server.yml:7

role-name[path]: Avoid using paths when importing roles. (nfs/client)
playbooks/groups/backup-server.yml:26

var-naming[no-role-prefix]: Variables names from within roles should use client_ as a prefix. (vars: mnt_dir)
playbooks/groups/backup-server.yml:27

var-naming[no-role-prefix]: Variables names from within roles should use client_ as a prefix. (vars: nfs_mount_opts)
playbooks/groups/backup-server.yml:28

var-naming[no-role-prefix]: Variables names from within roles should use client_ as a prefix. (vars: nfs_src_dir)
playbooks/groups/backup-server.yml:29

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/groups/backup-server.yml:34 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[missing]: All tasks should be named.
playbooks/groups/backup-server.yml:34 Task/Handler: import_tasks {{ tasks_path }}/yumrepos.yml

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/groups/backup-server.yml:37 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[missing]: All tasks should be named.
playbooks/groups/backup-server.yml:37 Task/Handler: import_tasks {{ tasks_path }}/motd.yml

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/groups/backup-server.yml:38 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[missing]: All tasks should be named.
playbooks/groups/backup-server.yml:38 Task/Handler: import_tasks {{ tasks_path }}/rdiff_backup_server.yml

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/groups/backup-server.yml:41 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[missing]: All tasks should be named.
playbooks/groups/backup-server.yml:41 Task/Handler: import_tasks {{ handlers_path }}/restart_services.yml

syntax-check[unknown-module]: couldn't resolve module/action 'ipahostgroup'. This often indicates a misspelling, missing collection, or incorrect module path.
roles/ipa/client/tasks/common.yml:22:3

Read documentation for instructions on how to ignore specific rule violations.

                        Rule Violation Summary                        
 count tag                          profile    rule associated tags   
     1 syntax-check[unknown-module] min        core, unskippable      
     4 role-name[path]              basic      deprecations, metadata 
     4 name[missing]                basic      idiom                  
     3 var-naming[no-role-prefix]   basic      idiom                  
     4 fqcn[action-core]            production formatting             

Failed: 16 failure(s), 0 warning(s) on 1 files.
I honestly don't know why it's failing. So I went back few previous commits, switched to main branch, and it's still not works. (i may have debugged it incorrerctly, so let me mention what I did) 1. clicked this link https://fedora.softwarefactory-project.io/zuul/build/61bf71fb8e2b415ab0513172c10e22b2 2. saw the first error log from `playbooks/groups/backup-server.yml`' 3. copied the command that run the `ansible-lint` ```sh ansible-lint --nocolor playbooks/groups/backup-server.yml ``` 4. opened my local repo and went back few commits (switched branches too) 5. run the command ``` ansible-lint --nocolor playbooks/groups/backup-server.yml ``` I still ended up getting the same error output... ``` iamyaash@fedora41:~/Projects/iamyaash/fedora/ansible$ ansible-lint --nocolor playbooks/groups/backup-server.yml WARNING Listing 16 violation(s) that are fatal role-name[path]: Avoid using paths when importing roles. (collectd/base) playbooks/groups/backup-server.yml:7 role-name[path]: Avoid using paths when importing roles. (ipa/client) playbooks/groups/backup-server.yml:7 role-name[path]: Avoid using paths when importing roles. (openvpn/client) playbooks/groups/backup-server.yml:7 role-name[path]: Avoid using paths when importing roles. (nfs/client) playbooks/groups/backup-server.yml:26 var-naming[no-role-prefix]: Variables names from within roles should use client_ as a prefix. (vars: mnt_dir) playbooks/groups/backup-server.yml:27 var-naming[no-role-prefix]: Variables names from within roles should use client_ as a prefix. (vars: nfs_mount_opts) playbooks/groups/backup-server.yml:28 var-naming[no-role-prefix]: Variables names from within roles should use client_ as a prefix. (vars: nfs_src_dir) playbooks/groups/backup-server.yml:29 fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/groups/backup-server.yml:34 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. playbooks/groups/backup-server.yml:34 Task/Handler: import_tasks {{ tasks_path }}/yumrepos.yml fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/groups/backup-server.yml:37 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. playbooks/groups/backup-server.yml:37 Task/Handler: import_tasks {{ tasks_path }}/motd.yml fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/groups/backup-server.yml:38 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. playbooks/groups/backup-server.yml:38 Task/Handler: import_tasks {{ tasks_path }}/rdiff_backup_server.yml fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/groups/backup-server.yml:41 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. playbooks/groups/backup-server.yml:41 Task/Handler: import_tasks {{ handlers_path }}/restart_services.yml syntax-check[unknown-module]: couldn't resolve module/action 'ipahostgroup'. This often indicates a misspelling, missing collection, or incorrect module path. roles/ipa/client/tasks/common.yml:22:3 Read documentation for instructions on how to ignore specific rule violations. Rule Violation Summary count tag profile rule associated tags 1 syntax-check[unknown-module] min core, unskippable 4 role-name[path] basic deprecations, metadata 4 name[missing] basic idiom 3 var-naming[no-role-prefix] basic idiom 4 fqcn[action-core] production formatting Failed: 16 failure(s), 0 warning(s) on 1 files. ```
kevin commented 2025-01-18 01:30:18 +00:00
Contributor
Copy link

We only got ansiblelint working on things a few months ago, so there's a lot of old legacy things that need fixing.

So, I think perhaps I confused you here. :(

I was suggesting:

  1. Remove entirely the - import_tasks: "{{ tasks_path }}/motd.yml" from playbooks. We are moving it from being that seperate task to just being part of the base role, so it doesn't need to be there at all anymore.

  2. You can remove entirely the tasks/motd.yml file too.

  3. In the roles/base/tasks/motd.yml for the template call, you don't need to specify any path, just 'src=motd.j2' Ansible will look in the templates dir for that role first to find it. :)

Aside that this looks pretty close. Can you make those changes and then we can see about the lint stuff?

Thanks again for working on this!

We only got ansiblelint working on things a few months ago, so there's a lot of old legacy things that need fixing. So, I think perhaps I confused you here. :( I was suggesting: 1. Remove entirely the - import_tasks: "{{ tasks_path }}/motd.yml" from playbooks. We are moving it from being that seperate task to just being part of the base role, so it doesn't need to be there at all anymore. 2. You can remove entirely the tasks/motd.yml file too. 3. In the roles/base/tasks/motd.yml for the template call, you don't need to specify any path, just 'src=motd.j2' Ansible will look in the templates dir for that role first to find it. :) Aside that this looks pretty close. Can you make those changes and then we can see about the lint stuff? Thanks again for working on this!
thisisyaash commented 2025-01-18 14:27:27 +00:00
Author
Contributor
Copy link

Remove entirely the - import_tasks: "{{ tasks_path }}/motd.yml" from playbooks. We are moving it from being that seperate task to just being part of the base role, so it doesn't need to be there at all anymore.

hmm...hmm, removed that line from all the playbooks.

You can remove entirely the tasks/motd.yml file too.

yup, deleted that file!

In the roles/base/tasks/motd.yml for the template call, you don't need to specify any path, just 'src=motd.j2' Ansible will look in the templates dir for that role first to find it. :)

oh I understand, now it only contains src=motd.j2

> Remove entirely the - import_tasks: "{{ tasks_path }}/motd.yml" from playbooks. We are moving it from being that seperate task to just being part of the base role, so it doesn't need to be there at all anymore. hmm...hmm, removed that line from all the playbooks. > You can remove entirely the tasks/motd.yml file too. yup, deleted that file! > In the roles/base/tasks/motd.yml for the template call, you don't need to specify any path, just 'src=motd.j2' Ansible will look in the templates dir for that role first to find it. :) oh I understand, now it only contains `src=motd.j2`
thisisyaash commented 2025-01-18 14:27:37 +00:00
Author
Contributor
Copy link

1 new commit added

  • udpated YAMLs & playbooks again
**1 new commit added** * ``udpated YAMLs & playbooks again``
zuul commented 2025-01-18 14:27:45 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2418,19c212f9296722d72c19464ae591977603fb755a

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2418,19c212f9296722d72c19464ae591977603fb755a
thisisyaash commented 2025-01-18 14:32:53 +00:00
Author
Contributor
Copy link

1 new commit added

  • updated correctly; buildhw.yml
**1 new commit added** * ``updated correctly; buildhw.yml``
zuul commented 2025-01-18 14:32:59 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2418,bac2873637808274b180a4f65628fb36d4e76208

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2418,bac2873637808274b180a4f65628fb36d4e76208
thisisyaash commented 2025-01-18 14:55:07 +00:00
Author
Contributor
Copy link

rebased onto a0720a8029

rebased onto a0720a802945f4fa6d6850e9221bd83cbd4bb1a8
zuul commented 2025-01-18 14:55:14 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2418,94f49e7b7f80e36624cd7a49b8bc73735227a4a6

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2418,94f49e7b7f80e36624cd7a49b8bc73735227a4a6
thisisyaash commented 2025-01-18 15:23:46 +00:00
Author
Contributor
Copy link

1 new commit added

  • fixing merge conflicts
**1 new commit added** * ``fixing merge conflicts``
zuul commented 2025-01-18 15:35:03 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/09f53cf05e0b44d69eccc44ae8625c70

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/09f53cf05e0b44d69eccc44ae8625c70 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/3e01e07357014f11b4200284a1097b9e) : FAILURE in 11m 02s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/53769e585a43494083946d094f31d1f6) : SUCCESS in 7m 29s
thisisyaash commented 2025-01-18 15:40:11 +00:00
Author
Contributor
Copy link

Aside that this looks pretty close. Can you make those changes and then we can see about the lint stuff?

i fixed the merge conflicts and now we're back to the fi-ansible-lint-diff failure :(
how are we going to fix that?

Thanks again for working on this!

i would say, thanks for guiding me even if im making a lot of mistakes here :)

> Aside that this looks pretty close. Can you make those changes and then we can see about the lint stuff? i fixed the merge conflicts and now we're back to the `fi-ansible-lint-diff` failure :( how are we going to fix that? > Thanks again for working on this! i would say, thanks for guiding me even if im making a lot of mistakes here :)
kevin commented 2025-01-18 19:23:01 +00:00
Contributor
Copy link

@ryanlerch was looking at these lint issues. We can also just ignore them for this pr (since they have been this way a long time).
(lets see what he says)

Otherwise, you do need 'dest=/etc/motd' in the template call. :) I meant that src can just be motd.j2, but it still needs to know where to copy it to. ;)

@ryanlerch was looking at these lint issues. We can also just ignore them for this pr (since they have been this way a long time). (lets see what he says) Otherwise, you do need 'dest=/etc/motd' in the template call. :) I meant that src can just be motd.j2, but it still needs to know where to copy it to. ;)
thisisyaash commented 2025-01-18 19:29:35 +00:00
Author
Contributor
Copy link

Otherwise, you do need 'dest=/etc/motd' in the template call. :) I meant that src can just be motd.j2, but it still needs to know where to copy it to. ;)

yes, will do it right away!

> Otherwise, you do need 'dest=/etc/motd' in the template call. :) I meant that src can just be motd.j2, but it still needs to know where to copy it to. ;) yes, will do it right away!
thisisyaash commented 2025-01-18 19:33:08 +00:00
Author
Contributor
Copy link

1 new commit added

  • dest added in motd.yml
**1 new commit added** * ``dest added in motd.yml``
zuul commented 2025-01-18 19:44:46 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/135a4ba0455a42d593b7cf6de9a8feec

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/135a4ba0455a42d593b7cf6de9a8feec - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/81a979b8693246ea802f57dfdfa84383) : FAILURE in 11m 22s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/6fdd76bc24e84f0d89d4a0deea807cb3) : SUCCESS in 7m 54s
thisisyaash commented 2025-01-22 07:46:30 +00:00
Author
Contributor
Copy link

@kevin now that we have updated from infra/hosts to infra/ansible/.
what information are we going to replace with in the current Infrastructure Apprentice page?

should we start a discussion threat? or send mailing lists?
yk, you mentioned that we could start sending mailing lists or creating discussion threat on or after new year?

I think it's about time we get started with this?

@kevin now that we have updated from `infra/hosts` to `infra/ansible/`. what information are we going to replace with in the current **Infrastructure Apprentice** page? should we start a discussion threat? or send mailing lists? yk, you mentioned that we could start sending mailing lists or creating discussion threat on or after new year? I think it's about time we get started with this?
kevin commented 2025-01-22 19:47:12 +00:00
Contributor
Copy link

So, looks like there are conflicts here now. ;( Can you rebase? I suspect it's ryan's lint changes touched things in this...

Also, can you perhaps squash the 11 commits here into 1?
(git rebase -i HEAD~11 should allow you do it.)

On the apprentice stuff... thats pretty unrelated here. Lets talk on matrix first and figure out where and what we want to discuss first?

So, looks like there are conflicts here now. ;( Can you rebase? I suspect it's ryan's lint changes touched things in this... Also, can you perhaps squash the 11 commits here into 1? (git rebase -i HEAD~11 should allow you do it.) On the apprentice stuff... thats pretty unrelated here. Lets talk on matrix first and figure out where and what we want to discuss first?
thisisyaash commented 2025-01-23 05:40:18 +00:00
Author
Contributor
Copy link

rebased onto 588dc2af21

rebased onto 588dc2af21ddc602b40a40c9c19d77a13bc6d7d4
zuul commented 2025-01-23 05:40:28 +00:00
First-time contributor
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging pagure.io/fedora-infra/ansible for 2418,d6ba72075ba2b7c5168267f82995d3d2d631fae5

Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging pagure.io/fedora-infra/ansible for 2418,d6ba72075ba2b7c5168267f82995d3d2d631fae5
thisisyaash commented 2025-01-23 05:44:03 +00:00
Author
Contributor
Copy link

So, looks like there are conflicts here now. ;( Can you rebase? I suspect it's ryan's lint changes touched things in this...

i have resolved the merge conflicts by updating it with the upstream changes, it still failing

Also, can you perhaps squash the 11 commits here into 1?
(git rebase -i HEAD~11 should allow you do it.)

yes, I have squashed it too

On the apprentice stuff... thats pretty unrelated here. Lets talk on matrix first and figure out where and what we want to discuss first?

alright!

> So, looks like there are conflicts here now. ;( Can you rebase? I suspect it's ryan's lint changes touched things in this... i have resolved the merge conflicts by updating it with the upstream changes, it still failing > Also, can you perhaps squash the 11 commits here into 1? (git rebase -i HEAD~11 should allow you do it.) yes, I have squashed it too > On the apprentice stuff... thats pretty unrelated here. Lets talk on matrix first and figure out where and what we want to discuss first? alright!
thisisyaash commented 2025-01-23 19:32:15 +00:00
Author
Contributor
Copy link

@kevin
I have resolved the conflicts and squased the commits as well
finally pushed the changes

but its still failed?
i don't know which one is causing this?
is there a way to backtrace the issue?
i can't see any logs in zuul either, can you help me with that?

@kevin I have resolved the conflicts and squased the commits as well finally pushed the changes but its still failed? i don't know which one is causing this? is there a way to backtrace the issue? i can't see any logs in zuul either, can you help me with that?
thisisyaash commented 2025-01-25 14:51:10 +00:00
Author
Contributor
Copy link

rebased onto a6c874f45e

rebased onto a6c874f45e8f7896a2976b2d6b0503babfa34797
zuul commented 2025-01-25 15:02:24 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/380cde7f893741188c8f9d1642358c39

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/380cde7f893741188c8f9d1642358c39 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/aa93ad22ccb146d8b3cfc23e812b1ff3) : FAILURE in 11m 00s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/22240d8c07a64b17887c89701843a9a9) : SUCCESS in 7m 36s
thisisyaash commented 2025-01-25 17:53:46 +00:00
Author
Contributor
Copy link

I have rebased it once again, and now its seems to be working fine!
could you please review this PR?
@kevin

I have rebased it once again, and now its seems to be working fine! could you please review this PR? @kevin
thisisyaash commented 2025-01-27 15:11:42 +00:00
Author
Contributor
Copy link

rebased onto 85ecf47a2a

rebased onto 85ecf47a2a8122c18a4eed3d6a38a7c6cc5f8204
zuul commented 2025-01-27 15:23:07 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/c105c54d47a3490b8287af9e1856ac2e

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/c105c54d47a3490b8287af9e1856ac2e - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/dc801f2c1276435b8fc3e1fae8d0dc5b) : FAILURE in 11m 08s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/c62d7823fcfc481ba7f0a60def81a8c3) : FAILURE in 7m 13s
kevin commented 2025-01-28 01:10:22 +00:00
Contributor
Copy link

rebased onto 7799cc2478

rebased onto 7799cc2478e46138999a28b6858357e630ee6f10
kevin commented 2025-01-28 01:10:31 +00:00
Contributor
Copy link

rebased onto 7799cc2478

rebased onto 7799cc2478e46138999a28b6858357e630ee6f10
zuul commented 2025-01-28 01:22:02 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/fa0f8fb7542a4e34b679c204b4868020

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/fa0f8fb7542a4e34b679c204b4868020 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/cbaff8b18ec241279ee7cc6cfd32a27f) : FAILURE in 11m 23s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/9369b62a01e7487bb7807b6aa8c8659d) : FAILURE in 7m 40s
kevin commented 2025-01-28 01:31:16 +00:00
Contributor
Copy link

ok. I think everything should be addressed. ;) Lets give it a go...

and thanks so much for working through all the feedback.

ok. I think everything should be addressed. ;) Lets give it a go... and thanks so much for working through all the feedback.
kevin commented 2025-01-28 01:31:30 +00:00
Contributor
Copy link

Pull-Request has been merged by kevin

Pull-Request has been merged by kevin
thisisyaash commented 2025-01-28 06:20:14 +00:00
Author
Contributor
Copy link

and thanks so much for working through all the feedback.

yup, thanks for guiding me as well :)

> and thanks so much for working through all the feedback. yup, thanks for guiding me as well :)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
freeze-break-request

   
post-freeze
No labels
freeze-break-request
post-freeze
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Infrastructure/ansible#2418
No description provided.
Delete branch "motd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?