Update modules/ROOT/pages/set-nvidia-as-primary-gpu-on-optimus-based-laptops.adoc #741
No reviewers
Labels
No labels
bug
Closed As
complete
Closed As
duplicate
Closed As
insufficient data
Closed As
moved
Closed As
not possible
Closed As
out of scope
Closed As
stale
good first issue
help wanted
improvement
needs changes
needs committer review
needs info
new change
Priority
awaiting triage
Priority
needs review
Priority
next meeting
Priority
waiting on assignee
Priority
waiting on external
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Docs/quick-docs#741
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changes to the document to reflect grammatical issues, and to note the explicit use of an X11 Desktop environment.
Thanks for your contributions. Patches to docs bug are always welcome. Members who have permission to merge to upstream main will be able to help.
These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list?
same as above
Maybe we say "Execute the following command to update all your packages first:"? That way we don't have to worry about whether the following sentence needs to be capitalised.
Looks good to me. I've left a couple of cosmetic notes.
I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps?
Also: you should include yourself in the authorlist in the second line and update the revdate too.
@hankuoffroad : are we OK to bump the revnumber to F39 perhaps, which is now the oldest supported Fedora release?
The code blocks was not intentional. Could have been an issue on my end, as I wrote this in 4 languages and prepared it to be a seamless addition. Also i used a minimal markdown editor, which I will consider changing now.
I'm curious if there is a preview feature in Pagure, if not I will change editors.
Yes, I often comment on the forums for such topics. I have tested this, and more importantly consulted with a couple of Community members on the topic. So the translations can follow as soon as is merged.
The goal would have to been complete this one, and follow up with an all Nvidia for Wayland environments which we had tested a couple months ago.
No worries. Does the markdown editor also support asciidoc syntax?
Not that I'm aware of no. I don't think even GitLab has a preview feature that shows the asciidoc preview.
My workflow is to check out the code locally and then make changes. The docsbuilder script generates a preview. (For PRs, Pagure does allow one to test them out locally too. There is a "pull this pull-request locally" link right below the new comment box)
That's awesome. Thanks for working on this.
Not sure, It's a very simple editor with a preview window. it's called Marker. I could replace it with no fuss. I already use Vim/NeoVim so maybe switch to that.
I'll make the change here in a little bit.
My anecdotal experience with collaborative projects, both code and docs etc. suggests that small specific changes get merged much quicker because they take less time to review. Larger changes that touch lots of different bits require the reviewer to go through them all.
So, usually, I have multiple branches that each touch only one quick doc (maybe 2 if there are two related pages). All these branches become individual PRs that undergo their own review, and that way none of them are blocked by each other too.
A quick search suggests that others seem to have come to similar conclusions:
https://stackoverflow.com/collectives/aws/articles/77217753/code-change-best-practices-smaller-pull-requests-for-smoother-merging
https://testing.googleblog.com/2024/07/in-praise-of-small-pull-requests.html
https://essenceofcode.com/2019/10/29/the-art-of-small-pull-requests/
rebased onto
8780d722a3
Thanks to Ankur for review and LGTM. Merging.
Pull-Request has been merged by hankuoffroad