Docs/quick-docs
1
0
Fork 0
Code Issues 48 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Update modules/ROOT/pages/set-nvidia-as-primary-gpu-on-optimus-based-laptops.adoc #741

Merged
ryanlerch merged 1 commit from main into main 2024-07-25 09:24:06 +00:00
Conversation 14 Commits 1 Files changed 1 +21 -18
hamrheadcorvette commented 2024-07-01 21:35:18 +00:00
Contributor
Copy link

Changes to the document to reflect grammatical issues, and to note the explicit use of an X11 Desktop environment.

Changes to the document to reflect grammatical issues, and to note the explicit use of an X11 Desktop environment.
hankuoffroad commented 2024-07-12 19:27:25 +00:00
Contributor
Copy link

Thanks for your contributions. Patches to docs bug are always welcome. Members who have permission to merge to upstream main will be able to help.

Thanks for your contributions. Patches to docs bug are always welcome. Members who have permission to merge to upstream main will be able to help.
ankursinha commented 2024-07-15 09:45:18 +00:00
Contributor
Copy link

These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list?

These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list?
ankursinha commented 2024-07-15 09:45:37 +00:00
Contributor
Copy link

same as above

same as above
ankursinha commented 2024-07-15 09:46:36 +00:00
Contributor
Copy link

Maybe we say "Execute the following command to update all your packages first:"? That way we don't have to worry about whether the following sentence needs to be capitalised.

Maybe we say "Execute the following command to update all your packages first:"? That way we don't have to worry about whether the following sentence needs to be capitalised.
ankursinha commented 2024-07-15 09:48:32 +00:00
Contributor
Copy link

Looks good to me. I've left a couple of cosmetic notes.

I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps?

Also: you should include yourself in the authorlist in the second line and update the revdate too.

@hankuoffroad : are we OK to bump the revnumber to F39 perhaps, which is now the oldest supported Fedora release?

Looks good to me. I've left a couple of cosmetic notes. I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps? Also: you should include yourself in the authorlist in the second line and update the revdate too. @hankuoffroad : are we OK to bump the revnumber to F39 perhaps, which is now the oldest supported Fedora release?
hamrheadcorvette commented 2024-07-15 19:05:38 +00:00
Author
Contributor
Copy link

These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list?

The code blocks was not intentional. Could have been an issue on my end, as I wrote this in 4 languages and prepared it to be a seamless addition. Also i used a minimal markdown editor, which I will consider changing now.

> These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list? The code blocks was not intentional. Could have been an issue on my end, as I wrote this in 4 languages and prepared it to be a seamless addition. Also i used a minimal markdown editor, which I will consider changing now.
hamrheadcorvette commented 2024-07-15 19:07:04 +00:00
Author
Contributor
Copy link

same as above

I'm curious if there is a preview feature in Pagure, if not I will change editors.

> same as above I'm curious if there is a preview feature in Pagure, if not I will change editors.
hamrheadcorvette commented 2024-07-15 19:14:25 +00:00
Author
Contributor
Copy link

Looks good to me. I've left a couple of cosmetic notes.

I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps?

Also: you should include yourself in the authorlist in the second line and update the revdate too.

Yes, I often comment on the forums for such topics. I have tested this, and more importantly consulted with a couple of Community members on the topic. So the translations can follow as soon as is merged.
The goal would have to been complete this one, and follow up with an all Nvidia for Wayland environments which we had tested a couple months ago.

> Looks good to me. I've left a couple of cosmetic notes. > > I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps? > > Also: you should include yourself in the authorlist in the second line and update the revdate too. > Yes, I often comment on the forums for such topics. I have tested this, and more importantly consulted with a couple of Community members on the topic. So the translations can follow as soon as is merged. The goal would have to been complete this one, and follow up with an all Nvidia for Wayland environments which we had tested a couple months ago.
ankursinha commented 2024-07-15 22:29:29 +00:00
Contributor
Copy link

These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list?

The code blocks was not intentional. Could have been an issue on my end, as I wrote this in 4 languages and prepared it to be a seamless addition. Also i used a minimal markdown editor, which I will consider changing now.

No worries. Does the markdown editor also support asciidoc syntax?

same as above

I'm curious if there is a preview feature in Pagure, if not I will change editors.

Not that I'm aware of no. I don't think even GitLab has a preview feature that shows the asciidoc preview.

My workflow is to check out the code locally and then make changes. The docsbuilder script generates a preview. (For PRs, Pagure does allow one to test them out locally too. There is a "pull this pull-request locally" link right below the new comment box)

Looks good to me. I've left a couple of cosmetic notes.

I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps?

Also: you should include yourself in the authorlist in the second line and update the revdate too.

Yes, I often comment on the forums for such topics. I have tested this, and more importantly consulted with a couple of Community members on the topic. So the translations can follow as soon as is merged.
The goal would have to been complete this one, and follow up with an all Nvidia for Wayland environments which we had tested a couple months ago.

That's awesome. Thanks for working on this.

> > > These are currently being rendered as "code blocks" so one has to scroll side ways to see the full text. Was this the intention? Probably better to have these as a sub-list? > > The code blocks was not intentional. Could have been an issue on my end, as I wrote this in 4 languages and prepared it to be a seamless addition. Also i used a minimal markdown editor, which I will consider changing now. No worries. Does the markdown editor also support asciidoc syntax? > > same as above > > I'm curious if there is a preview feature in Pagure, if not I will change editors. Not that I'm aware of no. I don't think even GitLab has a preview feature that shows the asciidoc preview. My workflow is to check out the code locally and then make changes. The docsbuilder script generates a preview. (For PRs, Pagure does allow one to test them out locally too. There is a "pull this pull-request locally" link right below the new comment box) > > Looks good to me. I've left a couple of cosmetic notes. > > > > I don't have an optimus card any more so I can't verify if the steps are correct. @hamrheadcorvette : have you verified the steps? > > > > Also: you should include yourself in the authorlist in the second line and update the revdate too. > > > > Yes, I often comment on the forums for such topics. I have tested this, and more importantly consulted with a couple of Community members on the topic. So the translations can follow as soon as is merged. > The goal would have to been complete this one, and follow up with an all Nvidia for Wayland environments which we had tested a couple months ago. > That's awesome. Thanks for working on this.
hamrheadcorvette commented 2024-07-17 14:58:21 +00:00
Author
Contributor
Copy link

No worries. Does the markdown editor also support asciidoc syntax?
Not that I'm aware of no. I don't think even GitLab has a preview feature that shows the asciidoc preview.

Not sure, It's a very simple editor with a preview window. it's called Marker. I could replace it with no fuss. I already use Vim/NeoVim so maybe switch to that.

My workflow is to check out the code locally and then make changes. The docsbuilder script generates a preview. (For PRs, Pagure does allow one to test them out locally too. There is a "pull this pull-request locally" link right below the new comment box)

Also: you should include yourself in the authorlist in the second line and update the revdate too.

I'll make the change here in a little bit.

That's awesome. Thanks for working on this.
No problem, it's been some time. I used this to gage the process, the previous pull had changes to 5+ Quick Docs, I had to remove it in hopes 1 Doc could move it faster. . .

>No worries. Does the markdown editor also support asciidoc syntax? > Not that I'm aware of no. I don't think even GitLab has a preview feature that shows the asciidoc preview. Not sure, It's a very simple editor with a preview window. it's called Marker. I could replace it with no fuss. I already use Vim/NeoVim so maybe switch to that. > My workflow is to check out the code locally and then make changes. The docsbuilder script generates a preview. (For PRs, Pagure does allow one to test them out locally too. There is a "pull this pull-request locally" link right below the new comment box) > > > Also: you should include yourself in the authorlist in the second line and update the revdate too. I'll make the change here in a little bit. > That's awesome. Thanks for working on this. No problem, it's been some time. I used this to gage the process, the previous pull had changes to 5+ Quick Docs, I had to remove it in hopes 1 Doc could move it faster. . .
ankursinha commented 2024-07-17 15:11:20 +00:00
Contributor
Copy link

My anecdotal experience with collaborative projects, both code and docs etc. suggests that small specific changes get merged much quicker because they take less time to review. Larger changes that touch lots of different bits require the reviewer to go through them all.

So, usually, I have multiple branches that each touch only one quick doc (maybe 2 if there are two related pages). All these branches become individual PRs that undergo their own review, and that way none of them are blocked by each other too.

A quick search suggests that others seem to have come to similar conclusions:

https://stackoverflow.com/collectives/aws/articles/77217753/code-change-best-practices-smaller-pull-requests-for-smoother-merging

https://testing.googleblog.com/2024/07/in-praise-of-small-pull-requests.html

https://essenceofcode.com/2019/10/29/the-art-of-small-pull-requests/

My anecdotal experience with collaborative projects, both code and docs etc. suggests that small specific changes get merged much quicker because they take less time to review. Larger changes that touch lots of different bits require the reviewer to go through them all. So, usually, I have multiple branches that each touch only one quick doc (maybe 2 if there are two related pages). All these branches become individual PRs that undergo their own review, and that way none of them are blocked by each other too. A quick search suggests that others seem to have come to similar conclusions: https://stackoverflow.com/collectives/aws/articles/77217753/code-change-best-practices-smaller-pull-requests-for-smoother-merging https://testing.googleblog.com/2024/07/in-praise-of-small-pull-requests.html https://essenceofcode.com/2019/10/29/the-art-of-small-pull-requests/
hankuoffroad commented 2024-07-25 09:22:53 +00:00
Contributor
Copy link

rebased onto 8780d722a3

rebased onto 8780d722a32e9d68734a4d07fef30f643e04a74c
hankuoffroad commented 2024-07-25 09:23:48 +00:00
Contributor
Copy link

Thanks to Ankur for review and LGTM. Merging.

Thanks to Ankur for review and LGTM. Merging.
hankuoffroad commented 2024-07-25 09:24:06 +00:00
Contributor
Copy link

Pull-Request has been merged by hankuoffroad

Pull-Request has been merged by hankuoffroad
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
Closed As
complete
Closed with the reason of complete

  
Closed As
duplicate
Closed with the reason of duplicate

  
Closed As
insufficient data
Closed with the reason of insufficient data

  
Closed As
moved
Closed with the reason of moved

  
Closed As
not possible
Closed with the reason of not possible

  
Closed As
out of scope
Closed with the reason of out of scope

  
Closed As
stale
Closed with the reason of stale

  
good first issue

Good for newcomers (if you want to get involved, try working on one of these!)

  
help wanted

Anyone is welcome to help us with this!

  
improvement

Improves on something that already exists

  
needs changes

Needs changes or fixes before closing

  
needs committer review

Needs review by a person with committer privileges or a subject-matter expert (SME)

  
needs info

Extra attention or information needed

  
new change

Adds new capabilities or functionality

  
Priority
awaiting triage
Priority of awaiting triage

  
Priority
needs review
Priority of needs review

  
Priority
next meeting
Priority of next meeting

  
Priority
waiting on assignee
Priority of waiting on assignee

  
Priority
waiting on external
Priority of waiting on external

No labels
bug
Closed As
complete
Closed As
duplicate
Closed As
insufficient data
Closed As
moved
Closed As
not possible
Closed As
out of scope
Closed As
stale
good first issue
help wanted
improvement
needs changes
needs committer review
needs info
new change
Priority
awaiting triage
Priority
needs review
Priority
next meeting
Priority
waiting on assignee
Priority
waiting on external
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Docs/quick-docs#741
No description provided.
Delete branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?