Docs/quick-docs
2
0
Fork 0
Code Issues 48 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Review and reorganize details on Installing Spotify guide #493

Merged
ryanlerch merged 1 commit from update-spotify-installation-guide into master 2022-10-17 20:45:31 +00:00
Conversation 14 Commits 1 Files changed 1 +2 -4
wevtimoteo commented 2022-10-16 15:42:16 +00:00
Contributor
Copy link

Motivation

As discussed in #491, the Spotify guide is missing the details about how lpf works and that is not so user-friendly.

Proposed solution

We've decided to present:

  • Move Flatpak option first
  • Add Snap option
  • Move lpf option last

Screenshot

(is there any guideline on uploading images for Pull Requests?)

## Motivation As discussed in [#491](https://pagure.io/fedora-docs/quick-docs/issue/491), the Spotify guide is missing the details about how `lpf` works and that is not so user-friendly. ## Proposed solution We've decided to present: - Move `Flatpak` option first - Add `Snap` option - Move `lpf` option last ## Screenshot - [Preview image in ImgBB](https://ibb.co/QrV5Zcz) (is there any guideline on uploading images for Pull Requests?)
wevtimoteo commented 2022-10-16 15:45:28 +00:00
Author
Contributor
Copy link

1 new commit added

  • Add snapcraft to References on installing Spotify
**1 new commit added** * ``Add snapcraft to References on installing Spotify``
ankursinha commented 2022-10-17 12:59:56 +00:00
Contributor
Copy link

Uh---is this really required to get snap working?

Uh---is this really required to get snap working?
ankursinha commented 2022-10-17 13:00:56 +00:00
Contributor
Copy link

is sudo required? I thought the advantage of using snap, like flatpak, would be that users could just install whatever without needing sudo and system wide admin privileges?

is `sudo` required? I thought the advantage of using snap, like flatpak, would be that users could just install whatever without needing sudo and system wide admin privileges?
ankursinha commented 2022-10-17 13:02:10 +00:00
Contributor
Copy link

Do we need to tell users how to add pkg-build to their user etc.? If this is on the github link, it'll be good to say "please refer to the github .. for information" perhaps?

Do we need to tell users how to add `pkg-build` to their user etc.? If this is on the github link, it'll be good to say "please refer to the github .. for information" perhaps?
ankursinha commented 2022-10-17 13:02:36 +00:00
Contributor
Copy link

Thanks very much for this @wevtimoteo . Looks very good. I've left a few comments.

Thanks very much for this @wevtimoteo . Looks very good. I've left a few comments.
ankursinha commented 2022-10-17 13:02:40 +00:00
Contributor
Copy link

Metadata Update from @ankursinha:

  • Request assigned
**Metadata Update from @ankursinha**: - Request assigned
ankursinha commented 2022-10-17 13:02:55 +00:00
Contributor
Copy link

Metadata Update from @ankursinha:

  • Pull-request tagged with: improvement, needs changes, needs committer review
**Metadata Update from @ankursinha**: - Pull-request tagged with: improvement, needs changes, needs committer review
wevtimoteo commented 2022-10-17 17:48:19 +00:00
Author
Contributor
Copy link

2 new commits added

  • Add Spotify installation page to the references section
  • Remove `sudo` from snap installation
**2 new commits added** * ``Add Spotify installation page to the references section`` * ``Remove `sudo` from snap installation``
wevtimoteo commented 2022-10-17 17:51:21 +00:00
Author
Contributor
Copy link

1 new commit added

  • Remove details about `lpf` setup
**1 new commit added** * ``Remove details about `lpf` setup``
wevtimoteo commented 2022-10-17 17:52:56 +00:00
Author
Contributor
Copy link

Uh---is this really required to get snap working?

@ankursinha Yes, this is the recommendation extracted from Snapcraft page

is sudo required? I thought the advantage of using snap, like flatpak, would be that users could just install whatever without needing sudo and system wide admin privileges?

Some packages require sudo on installing, I've checked Spotify installation page and it recommends installation without sudo, done in 40daf31 and f9d13a8.

Do we need to tell users how to add pkg-build to their user etc.? If this is on the github link, it'll be good to say "please refer to the github .. for information" perhaps?

Agreed! Done in e1cb92e.

@ankursinha could you review it again? Thanks for your comments!

> Uh---is this really required to get snap working? @ankursinha Yes, this is the recommendation extracted from [Snapcraft](https://snapcraft.io/spotify) page > is `sudo` required? I thought the advantage of using snap, like flatpak, would be that users could just install whatever without needing sudo and system wide admin privileges? Some packages require `sudo` on installing, I've checked [Spotify installation page](https://www.spotify.com/us/download/linux/) and it recommends installation without `sudo`, done in 40daf31 and f9d13a8. > Do we need to tell users how to add `pkg-build` to their user etc.? If this is on the github link, it'll be good to say "please refer to the github .. for information" perhaps? Agreed! Done in e1cb92e. --- @ankursinha could you review it again? Thanks for your comments!
ankursinha commented 2022-10-17 20:44:53 +00:00
Contributor
Copy link

lgtm, merging. Thanks very much @wevtimoteo .

I'll also add you to the quick-docs-committers group. You should be able to work with tickets etc. and review other PRs to merge them and so on.

lgtm, merging. Thanks very much @wevtimoteo . I'll also add you to the quick-docs-committers group. You should be able to work with tickets etc. and review other PRs to merge them and so on.
ankursinha commented 2022-10-17 20:45:31 +00:00
Contributor
Copy link

Pull-Request has been merged by ankursinha

Pull-Request has been merged by ankursinha
dapperplant commented 2022-10-17 23:01:31 +00:00
First-time contributor
Copy link

That was fast, I think it's a great improvement.

I think that a general guide about choosing between different installation methodologies would also be useful to help people getting started. For myself I was keeping track a bit and by now I have installed software through:

dnf with its default repo's
RPM fusion
installed some downloaded RPM files
Flatpaks from flathub
Appimage

On the other hand maybe this is something people need to find out for themselves?

That was fast, I think it's a great improvement. I think that a general guide about choosing between different installation methodologies would also be useful to help people getting started. For myself I was keeping track a bit and by now I have installed software through: dnf with its default repo's RPM fusion installed some downloaded RPM files Flatpaks from flathub Appimage On the other hand maybe this is something people need to find out for themselves?
wevtimoteo commented 2022-10-18 01:33:04 +00:00
Author
Contributor
Copy link

lgtm, merging. Thanks very much @wevtimoteo .

I'll also add you to the quick-docs-committers group. You should be able to work with tickets etc. and review other PRs to merge them and so on.

Thanks @ankursinha! Will do my best.

That was fast, I think it's a great improvement.

I think that a general guide about choosing between different installation methodologies would also be useful to help people getting started. For myself I was keeping track a bit and by now I have installed software through:

dnf with its default repo's
RPM fusion
installed some downloaded RPM files
Flatpaks from flathub
Appimage

On the other hand maybe this is something people need to find out for themselves?

Thanks for your considerations @dapperplant. I think this would cover "software alternatives methods on installing Third-party software". Maybe would be a new entry in the docs, then we can just refer to them when guiding people on getting these apps installed (maybe we should open a new issue to discuss it and gather more opinions).

> lgtm, merging. Thanks very much @wevtimoteo . > > I'll also add you to the quick-docs-committers group. You should be able to work with tickets etc. and review other PRs to merge them and so on. Thanks @ankursinha! Will do my best. > That was fast, I think it's a great improvement. > > I think that a general guide about choosing between different installation methodologies would also be useful to help people getting started. For myself I was keeping track a bit and by now I have installed software through: > > dnf with its default repo's > RPM fusion > installed some downloaded RPM files > Flatpaks from flathub > Appimage > > > On the other hand maybe this is something people need to find out for themselves? > > Thanks for your considerations @dapperplant. I think this would cover "software alternatives methods on installing Third-party software". Maybe would be a new entry in the docs, then we can just refer to them when guiding people on getting these apps installed (maybe we should open a new issue to discuss it and gather more opinions).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
Closed As
complete
Closed with the reason of complete

  
Closed As
duplicate
Closed with the reason of duplicate

  
Closed As
insufficient data
Closed with the reason of insufficient data

  
Closed As
moved
Closed with the reason of moved

  
Closed As
not possible
Closed with the reason of not possible

  
Closed As
out of scope
Closed with the reason of out of scope

  
Closed As
stale
Closed with the reason of stale

  
good first issue

Good for newcomers (if you want to get involved, try working on one of these!)

  
help wanted

Anyone is welcome to help us with this!

  
improvement

Improves on something that already exists

  
needs changes

Needs changes or fixes before closing

  
needs committer review

Needs review by a person with committer privileges or a subject-matter expert (SME)

  
needs info

Extra attention or information needed

  
new change

Adds new capabilities or functionality

  
Priority
awaiting triage
Priority of awaiting triage

  
Priority
needs review
Priority of needs review

  
Priority
next meeting
Priority of next meeting

  
Priority
waiting on assignee
Priority of waiting on assignee

  
Priority
waiting on external
Priority of waiting on external

No labels
bug
Closed As
complete
Closed As
duplicate
Closed As
insufficient data
Closed As
moved
Closed As
not possible
Closed As
out of scope
Closed As
stale
good first issue
help wanted
improvement
needs changes
needs committer review
needs info
new change
Priority
awaiting triage
Priority
needs review
Priority
next meeting
Priority
waiting on assignee
Priority
waiting on external
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Docs/quick-docs#493
No description provided.
Delete branch "update-spotify-installation-guide"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?