Docs/quick-docs
2
0
Fork 0
Code Issues 48 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Technical review of using nested virtualization #323

Merged
ryanlerch merged 1 commit from technical-review-nested-virtualization into master 2021-01-27 09:49:05 +00:00
Conversation 9 Commits 1 Files changed 2 +7 -7
connorl commented 2021-01-15 13:44:36 +00:00
Contributor
Copy link

Fixes #214

Tested the instructions on Fedora 33 x86_64 with a Ryzen 4750U CPU. Everything was fine except for some minor tweaks:

  • Changed all instances of running as root to sudo
  • Update output of virt-host-validate command
  • Fix page formatting
  • Use HTTPS
Fixes #214 Tested the instructions on Fedora 33 x86_64 with a Ryzen 4750U CPU. Everything was fine except for some minor tweaks: - Changed all instances of running as root to sudo - Update output of `virt-host-validate` command - Fix page formatting - Use HTTPS
pbokoc commented 2021-01-27 00:39:14 +00:00
Contributor
Copy link

rebased onto 3c63210b8f517f178f9b978cccb96793f0bd200f

rebased onto 3c63210b8f517f178f9b978cccb96793f0bd200f
pbokoc commented 2021-01-27 00:42:33 +00:00
Contributor
Copy link

Hi @connorl, thank you for the PR. Everything looks fine, but I have a small change request: Can you please remove the # and $ prompts from command examples? We used to use them back when sudo wasn't enabled by default to indicate whether you need to be root to run a specific command or not, but nowadays that's not needed - instead we just use sudo when you need it, and the prompts aren't needed anymore.

Hi @connorl, thank you for the PR. Everything looks fine, but I have a small change request: Can you please remove the `#` and `$` prompts from command examples? We used to use them back when sudo wasn't enabled by default to indicate whether you need to be root to run a specific command or not, but nowadays that's not needed - instead we just use sudo when you need it, and the prompts aren't needed anymore.
pbokoc commented 2021-01-27 00:52:04 +00:00
Contributor
Copy link

Metadata Update from @pbokoc:

  • Request assigned
**Metadata Update from @pbokoc**: - Request assigned
pbokoc commented 2021-01-27 01:09:37 +00:00
Contributor
Copy link

Metadata Update from @pbokoc:

  • Pull-request tagged with: needs changes
**Metadata Update from @pbokoc**: - Pull-request tagged with: needs changes
connorl commented 2021-01-27 04:30:14 +00:00
Author
Contributor
Copy link

1 new commit added

  • Remove unnecessary command prompts
**1 new commit added** * ``Remove unnecessary command prompts``
connorl commented 2021-01-27 04:31:34 +00:00
Author
Contributor
Copy link

Hi @pbokoc thanks for the feedback. I've removed all the prompts from the command examples. Please let me know if you need any other changes.

Hi @pbokoc thanks for the feedback. I've removed all the prompts from the command examples. Please let me know if you need any other changes.
pbokoc commented 2021-01-27 09:48:48 +00:00
Contributor
Copy link

rebased onto 73c781cd26

rebased onto 73c781cd265052f07710a3a2fef20e1e8acf6330
pbokoc commented 2021-01-27 09:48:56 +00:00
Contributor
Copy link

Everything looks good, thank you!

Everything looks good, thank you!
pbokoc commented 2021-01-27 09:49:05 +00:00
Contributor
Copy link

Pull-Request has been merged by pbokoc

Pull-Request has been merged by pbokoc
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
Closed As
complete
Closed with the reason of complete

  
Closed As
duplicate
Closed with the reason of duplicate

  
Closed As
insufficient data
Closed with the reason of insufficient data

  
Closed As
moved
Closed with the reason of moved

  
Closed As
not possible
Closed with the reason of not possible

  
Closed As
out of scope
Closed with the reason of out of scope

  
Closed As
stale
Closed with the reason of stale

  
good first issue

Good for newcomers (if you want to get involved, try working on one of these!)

  
help wanted

Anyone is welcome to help us with this!

  
improvement

Improves on something that already exists

  
needs changes

Needs changes or fixes before closing

  
needs committer review

Needs review by a person with committer privileges or a subject-matter expert (SME)

  
needs info

Extra attention or information needed

  
new change

Adds new capabilities or functionality

  
Priority
awaiting triage
Priority of awaiting triage

  
Priority
needs review
Priority of needs review

  
Priority
next meeting
Priority of next meeting

  
Priority
waiting on assignee
Priority of waiting on assignee

  
Priority
waiting on external
Priority of waiting on external

No labels
bug
Closed As
complete
Closed As
duplicate
Closed As
insufficient data
Closed As
moved
Closed As
not possible
Closed As
out of scope
Closed As
stale
good first issue
help wanted
improvement
needs changes
needs committer review
needs info
new change
Priority
awaiting triage
Priority
needs review
Priority
next meeting
Priority
waiting on assignee
Priority
waiting on external
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Docs/quick-docs#323
No description provided.
Delete branch "technical-review-nested-virtualization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?