Docs/fedora-join-docs
2
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

UPDATES to Readme, index.adoc, hoping to solve [issus #19](https://pagure.io/fedora-join/fedora-join-docs/issue/19), and pulling in breaking sentences to individual lines #28

Closed
mkittermantgd wants to merge 0 commits from update-successful-contributor into main
pull from: update-successful-contributor
merge into: Docs:main
Conversation 9 Commits - Files changed -
mkittermantgd commented 2023-10-29 04:19:01 +00:00
Contributor
Copy link

In the README.md doc, I changed the doc to reflect the current workflow after running this locally and seeing that the previous command was depricated.

In the ../index.adocI re-formatted my admonition to have it render correctly on the webpage. Thanks Carl!

In the How to be a Successful Contributor document, I referenced Issue #19 and changed the doc to reflect the new Welcome workflow.

In the `README.md` doc, I changed the doc to reflect the current workflow after running this locally and seeing that the previous command was depricated. In the `../index.adoc`I re-formatted my admonition to have it render correctly on the webpage. Thanks Carl! In the `How to be a Successful Contributor` document, I referenced Issue #19 and changed the doc to reflect the new Welcome workflow.
ankursinha commented 2023-10-29 09:51:59 +00:00
Contributor
Copy link

rebased onto 90b7e58046

rebased onto 90b7e58046accc7f73306313c9406a13a00679db
ankursinha commented 2023-10-29 09:52:44 +00:00
Contributor
Copy link

Are the extra new lines required? They'll make each sentence into a new paragraph I think?

Are the extra new lines required? They'll make each sentence into a new paragraph I think?
ankursinha commented 2023-10-29 09:53:35 +00:00
Contributor
Copy link

I rebased your PR on to main, so please run a git pull --force on the branch to update your local branch before making any more changes.

I rebased your PR on to main, so please run a `git pull --force` on the branch to update your local branch before making any more changes.
ankursinha commented 2023-10-30 08:47:46 +00:00
Contributor
Copy link

Hrm, @mkittermantgd : not sure what that is---have you perhaps replied with encryption on? I don't think pagure can handle that.

Hrm, @mkittermantgd : not sure what that is---have you perhaps replied with encryption on? I don't think pagure can handle that.
ankursinha commented 2023-10-30 08:56:33 +00:00
Contributor
Copy link

Metadata Update from @ankursinha:

  • Pull-request tagged with: needs changes, needs feedback, type - existing docs
**Metadata Update from @ankursinha**: - Pull-request tagged with: needs changes, needs feedback, type - existing docs
mkittermantgd commented 2023-10-30 10:16:51 +00:00
Author
Contributor
Copy link

Hrm, @mkittermantgd : not sure what that is---have you perhaps replied with encryption on? I don't think pagure can handle that.

Thanks Proton Mail! Lol.

Here is what that says in plain text:

Fantastic!

On the lines to paragraphs, it should have been to align with asciidoc syntaxes. I'll definitely be more clear about that moving forward

> Hrm, @mkittermantgd : not sure what that is---have you perhaps replied with encryption on? I don't think pagure can handle that. Thanks Proton Mail! Lol. Here is what that says in plain text: Fantastic! On the lines to paragraphs, it should have been to align with asciidoc syntaxes. I'll definitely be more clear about that moving forward
ankursinha commented 2023-10-30 10:24:01 +00:00
Contributor
Copy link

Cool, I'll merge your bits into my branch and then push everything once I've made some content changes.

Cool, I'll merge your bits into my branch and then push everything once I've made some content changes.
ankursinha commented 2023-10-30 10:26:14 +00:00
Contributor
Copy link

Merged into https://pagure.io/fedora-join/fedora-join-docs/tree/update-successful-contributor

Merged into https://pagure.io/fedora-join/fedora-join-docs/tree/update-successful-contributor
ankursinha commented 2023-10-30 10:26:21 +00:00
Contributor
Copy link

Pull-Request has been closed by ankursinha

Pull-Request has been closed by ankursinha

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Progress blocked by another task or issue

  
Closed As
complete
Closed with the reason of complete

  
Closed As
duplicate
Closed with the reason of duplicate

  
Closed As
insufficient data
Closed with the reason of insufficient data

  
Closed As
moved
Closed with the reason of moved

  
Closed As
not possible
Closed with the reason of not possible

  
Closed As
out of scope
Closed with the reason of out of scope

  
Closed As
stale
Closed with the reason of stale

  
good first issue

Good for newcomers (if you want to get involved, try working on one of these!)

  
help wanted

Anyone is welcome to help us with this!

  
needs changes

Needs changes or fixes before closing

  
needs feedback

Extra attention or feedback needed

  
needs testing

Needs testing or QA before closing

  
Priority
awaiting triage
Priority of awaiting triage

  
Priority
needs review
Priority of needs review

  
Priority
next meeting
Priority of next meeting

  
Priority
waiting on assignee
Priority of waiting on assignee

  
Priority
waiting on external
Priority of waiting on external

  
type - dev tools

Related to developer tooling or build scripts

  
type - existing docs

Improves or changes existing documentation

  
type - new docs

Adds or creates new documentation

No labels
blocked
Closed As
complete
Closed As
duplicate
Closed As
insufficient data
Closed As
moved
Closed As
not possible
Closed As
out of scope
Closed As
stale
good first issue
help wanted
needs changes
needs feedback
needs testing
Priority
awaiting triage
Priority
needs review
Priority
next meeting
Priority
waiting on assignee
Priority
waiting on external
type - dev tools
type - existing docs
type - new docs
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Docs/fedora-join-docs#28
No description provided.
Delete branch "update-successful-contributor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?