infrastructure/fedora-infrastructure
2
0
Fork 0
Code Issues 66 Pull requests Projects Releases Packages Wiki Activity Actions

Add more warnings.

Browse source 
Add warnings for new package requests:
  fedora-review flag is not set to '+'
  Ticket is not assigned to anyone.
This commit is contained in:
Jason Tibbitts 2011-06-24 10:34:16 -05:00
parent 11b13f8fa1
commit cdfb9dc2f3
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
scripts/process-git-requests/process-git-requests
View file

@ -170,7 +170,7 @@ def run_query(bz):
querydata['column_list'] = ['opendate', 'changeddate', 'bug_severity',
'alias', 'assigned_to', 'reporter', 'bug_status', 'resolution',
'component', 'blockedby', 'dependson', 'short_desc',
'status_whiteboard', 'flag_types']
'status_whiteboard', 'flagtypes.name']
querydata['field0-0-0'] = 'flagtypes.name'
querydata['type0-0-0'] = 'equals'
@ -470,8 +470,18 @@ def process_new_request(bug, comment, allcomments, firstfound, pkgdb, fas, branc
if i not in branches:
warnings.append("WARNING: Invalid branch %s requested" % i)
warned = True
if bug.assigned_to == 'nobody@fedoraproject.org':
warnings.append("WARNING: Ticket is not assigned to anyone.")
warned = True
if bug.assigned_to in bad_reviewers:
warnings.append("WARNING: Reviewer %s has done poor reviews in the past; please check." % bug.assigned_to)
warned = True
# This is an unpleasant hack
flags = bug.__getattr__('flagtypes.name')
if flags.find('fedora-review+') < 0:
warnings.append("WARNING: fedora-review flag not set to '+'")
warned = True
short_desc = bug.short_desc
m=re.search('Review Request:\s+([a-zA-Z0-9_+.-]+)\s+', short_desc, re.I)