diff --git a/fas/devdata.sqlite b/fas/devdata.sqlite deleted file mode 100644 index 30840e9..0000000 Binary files a/fas/devdata.sqlite and /dev/null differ diff --git a/fas/devdata.sqlite.bak b/fas/devdata.sqlite.bak deleted file mode 100644 index 092c6e0..0000000 Binary files a/fas/devdata.sqlite.bak and /dev/null differ diff --git a/fas/fas/controllers.py b/fas/fas/controllers.py index cc5c22e..9db02c4 100644 --- a/fas/fas/controllers.py +++ b/fas/fas/controllers.py @@ -72,7 +72,7 @@ class editGroup(widgets.WidgetsList): fedoraGroupUserCanRemove = widgets.CheckBox(label='Self Removal') fedoraGroupJoinMsg = widgets.TextField(label='Group Join Message') -editGroupForm = widgets.ListForm(fields=editPerson(), submit_text='Update') +editGroupForm = widgets.ListForm(fields=editGroup(), submit_text='Update') class findUser(widgets.WidgetsList): userName = widgets.AutoCompleteField(label='Username', search_controller='search', search_param='userName', result_name='people') @@ -228,7 +228,6 @@ class Root(controllers.RootController): @expose(template="fas.templates.editGroup") @identity.require(identity.not_anonymous()) def editGroup(self, groupName, action=None): - pass userName = turbogears.identity.current.user_name try: Groups.byUserName(userName)['accounts'].cn @@ -241,14 +240,14 @@ class Root(controllers.RootController): turbogears.flash('You cannot edit %s' % groupName) turbogears.redirect('viewGroup?groupName=%s' % groupName) group = Groups.groups(groupName)[groupName] - #value = {'givenName' : user.givenName, - # 'mail' : user.mail, - # 'fedoraPersonBugzillaMail' : user.fedoraPersonBugzillaMail, - # 'fedoraPersonIrcNick' : user.fedoraPersonIrcNick, - # 'fedoraPersonKeyId' : user.fedoraPersonKeyId, - # 'telephoneNumber' : user.telephoneNumber, - # 'postalAddress' : user.postalAddress, - # 'description' : user.description, } + value = {'groupName' : groupName, + 'fedoraGroupOwner' : group.fedoraGroupOwner, + 'fedoraGroupType' : group.fedoraGroupType, + 'fedoraGroupNeedsSponsor' : (group.fedoraGroupNeedsSponsor.upper() == 'TRUE'), + 'fedoraGroupUserCanRemove' : (group.fedoraGroupUserCanRemove.upper() == 'TRUE'), + 'fedoraGroupJoinMsg' : group.fedoraGroupJoinMsg, + 'fedoraGroupDesc' : group.fedoraGroupDesc, } + #'fedoraGroupRequires' : group.fedoraGroupRequires, } return dict(form=editGroupForm, value=value) @expose(template="fas.templates.groupList") @@ -357,15 +356,15 @@ class Root(controllers.RootController): sponsor = turbogears.identity.current.user_name try: group = Groups.groups(groupName)[groupName] - except KeyError, e: - turbogears.flash('Group Error: %s does not exist - %s' % (groupName, e)) + except KeyError: + turbogears.flash('Group Error: %s does not exist.' % groupName) turbogears.redirect('viewGroup?groupName=%s' % group.cn) try: p = Person.byUserName(userName) if not p.cn: - raise KeyError, 'User %s, just not there' % userName - except KeyError, e: - turbogears.flash('User Error: %s does not exist - %s' % (userName, e)) + raise KeyError, userName + except KeyError: + turbogears.flash('User Error: User %s does not exist.' % userName) turbogears.redirect('viewGroup?groupName=%s' % group.cn) g = Groups.byGroupName(groupName, includeUnapproved=True) diff --git a/fas/fas/fasLDAP.py b/fas/fas/fasLDAP.py index 5aa0e56..75851e0 100644 --- a/fas/fas/fasLDAP.py +++ b/fas/fas/fasLDAP.py @@ -355,6 +355,8 @@ class Person: @classmethod def auth(self, who, password, ldapServer=None): ''' Basic Authentication Module ''' + if not password: + raise AuthError if not ldapServer: s = Server() ldapServer = s.ldapConn diff --git a/fas/fasdb.sqlite b/fas/fasdb.sqlite deleted file mode 100644 index 30840e9..0000000 Binary files a/fas/fasdb.sqlite and /dev/null differ