infrastructure/ansible
1
0
Fork 0
Code Pull requests 7 Activity Actions

mediawiki fedmsg-emit: fix error on creating page (#7415)

Browse source 
This function is set up as a mediawiki hook. It expects to be
passed 12 args. It turns out that mediawiki 1.29.3 - the version
we're running - has two codepaths that call the hook: one passes
it all 12 args, one only passes it 11, missing out the final arg
(undidRevId). @puiterwijk tried to fix this in d85f8c2, but it
seems he misread and set a default value for the 11th arg rather
than the 12th, so it didn't actually fix the problem. Moving the
default value to the 12th arg should fix the problem for good.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2018-12-03 23:46:09 -08:00
parent 10c88b0933
commit e3a7bfda34
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
roles/mediawiki/files/fedmsg-emit.php
View file

@ -205,8 +205,8 @@ function article_save(
&$flags,
$revision,
&$status,
$baseRevId=0,
$undidRevId
$baseRevId,
$undidRevId=0
) {
# If for some reason or another we can't create our socket, then bail.