openqa/server: clean up and trim package requirements

Several of these requirements are old ones that were only needed
for createhdds, when we ran createhdds on the servers. All of
those can go. Also make the list line-by-line for easier git
blame tracking in future (and add comments for the remaining
entries so we know why they're there).

Signed-off-by: Adam Williamson <awilliam@redhat.com>

roles/openqa/server/files/createhdds

@@ -1,4 +0,0 @@
-#!/bin/sh
-
-cd /var/lib/openqa/share/factory/hdd/fixed
-LIBGUESTFS_BACKEND=direct withlock /var/lock/createhdds.lock /root/createhdds/createhdds.py all --clean

roles/openqa/server/tasks/main.yml

@@ -148,8 +148,11 @@
 # for these packages
 - name: Install openQA packages
   package:
-    name: ['openqa', 'openqa-httpd', 'openqa-plugin-fedora-messaging', 'openqa-plugin-fedoraupdaterestart',
+    name:
-           'python3-fedfind']
+      - openqa
+      - openqa-httpd
+      - openqa-plugin-fedora-messaging
+      - openqa-plugin-fedoraupdaterestart
     state: latest
     enablerepo: "{{ openqa_repo }}"
   tags:
@@ -157,10 +160,15 @@
 
 - name: Install various other required packages
   package:
-    name: ['python3-libselinux', 'git', 'jq', 'libselinux-utils', 'python3-libsemanage',
+    name:
-           'nfs-utils', 'perl(Class::DBI::Pg)', 'expect', 'libguestfs-tools-c', 'libguestfs-xfs',
+      - python3-libselinux # for custom SELinux policy
-           'libvirt-daemon-config-network', 'libvirt-python3', 'python3-libguestfs',
+      - git # for checking out tests/tools
-           'virt-install', 'withlock', 'genisoimage']
+      - jq # for checking if tests changed after template load
+      - libselinux-utils # custom SELinux policy
+      - python3-libsemanage # custom SELinux policy
+      - nfs-utils # for configuring/running NFS server
+      - perl(Class::DBI::Pg) # for using postgresql DB
+      - genisoimage # for building cloud-init ISO
     state: present
   tags:
   - packages