Fix 'name' class linting issues in openshift-apps playbooks

Fixes a bunch of linting issues with the names of tasks and plays in the
openshift-apps playbooks.

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
This commit is contained in:
Ryan Lercho 2024-11-12 18:09:09 +10:00
parent f2cccb662a
commit 4394556d4c
62 changed files with 130 additions and 117 deletions

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_masters_stg[0] # only in staging for the ARC deployment
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: False

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: localhost
connection: local
user: root

View file

@ -3,7 +3,7 @@
#
---
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -25,7 +25,7 @@
owner: "{{ tahrirDBUser }}"
encoding: UTF-8
- name: give access to the datanommer DB
- name: Give access to the datanommer DB
hosts: datanommer_dbserver:datanommer_dbserver_stg
gather_facts: no
become: yes
@ -41,14 +41,14 @@
postgresql_user:
name: "{{ tahrirDBUser }}"
password: "{{ (env == 'production')|ternary(tahrirDBPassword, tahrirstgDBPassword) }}"
- name: grant the db user read only access to datanommer2
- name: Grant the db user read only access to datanommer2
postgresql_privs:
database: datanommer2
privs: SELECT
objs: ALL_IN_SCHEMA
roles: "{{ tahrirDBUser }}"
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: false

View file

@ -1,15 +1,15 @@
- name: prepare setting up the database
- name: Prepare setting up the database
hosts: db01.stg.iad2.fedoraproject.org:db01.iad2.fedoraproject.org
gather_facts: no
user: root
tasks:
- name: install psycopg2 for the postgresql ansible modules
- name: Install psycopg2 for the postgresql ansible modules
package: name=python3-psycopg2 state=present
tags:
- packages
- name: setup the database
- name: Setup the database
hosts: db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -35,7 +35,7 @@
owner: "{{ stg_blockerbugs_db_user }}"
encoding: UTF-8
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -61,7 +61,7 @@
owner: "{{ prod_blockerbugs_db_user }}"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False
@ -19,9 +19,12 @@
- ocp4: true
pre_tasks:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- include_vars: /srv/web/infra/ansible/vars/apps/bodhi.yml
- set_fact:
- name: Include Global Variables
include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: Include Bodhi Variables
include_vars: /srv/web/infra/ansible/vars/apps/bodhi.yml
- name: Set bodhi_version fact
set_fact:
args:
bodhi_version: "{{ bodhi_version }}"
@ -172,7 +175,7 @@
command: "oc -n bodhi annotate route bodhi-web --overwrite haproxy.router.openshift.io/timeout=180s"
tags:
- route-timeout
- name: trigger critpath cronjob
- name: Trigger critpath cronjob
command: "oc -n bodhi create job critpathcron-manual-{{ lookup('pipe','date +%s') }} --from=cronjob/fedora-bodhi-critpathcron"
tags:
- never

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: false

View file

@ -1,5 +1,6 @@
---
- hosts: os_control:os_control_stg
- name: Make the app be real
hosts: os_control:os_control_stg
user: root
gather_facts: false

View file

@ -1,5 +1,5 @@
---
- name: provision CoreOS Cincinnati backend
- name: Provision CoreOS Cincinnati backend
hosts: os_control:os_control_stg
user: root
gather_facts: false
@ -11,7 +11,8 @@
- /srv/web/infra/ansible/roles/openshift-apps/coreos-cincinnati/vars/{{ env }}.yml
pre_tasks:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: Include Global Variables
include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
############################################
# actions to create the project in OpenShift

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control:os_control_stg
user: root
gather_facts: false

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control:os_control_stg
user: root
gather_facts: false
@ -18,11 +18,13 @@
# Set the fedora_messaging_routing_keys var based on the environment
pre_tasks:
- set_fact:
- name: Set the fedora_messaging_routing_keys var
set_fact:
fedora_messaging_routing_keys:
- "org.fedoraproject.stg.coreos.build.request.ostree-import"
when: env == 'staging'
- set_fact:
- name: Set the fedora_messaging_routing_keys var
set_fact:
fedora_messaging_routing_keys:
- "org.fedoraproject.prod.coreos.build.request.ostree-import"
when: env != 'staging'

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: false

View file

@ -1,4 +1,4 @@
- name: give access to the datanommer DB
- name: Give access to the datanommer DB
hosts: datanommer_dbserver:datanommer_dbserver_stg
gather_facts: no
become: yes
@ -14,7 +14,7 @@
postgresql_user:
name: datagrepper
password: "{{ (env == 'production')|ternary(datagrepper_prod_db_password, datagrepper_stg_db_password) }}"
- name: grant the db user read only access to datanommer2
- name: Grant the db user read only access to datanommer2
postgresql_privs:
database: datanommer2
privs: SELECT
@ -22,7 +22,7 @@
roles: datagrepper
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: false

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -2,7 +2,7 @@
# Fedora Project easyfixes
#
- name: make the app be real
- name: Make the app be real
# hosts: os_control_stg:os_control
hosts: os_control_stg
user: root

View file

@ -1,4 +1,4 @@
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -9,18 +9,18 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
tasks:
- name: elections DB user
- name: Elections DB user
postgresql_user:
name: "{{ elections_db_user }}"
password: "{{ elections_db_pass }}"
- name: elections database creation
- name: Elections database creation
postgresql_db:
name: "{{ elections_db_name }}"
owner: "{{ elections_db_user }}"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0],os_control[0]
user: root
gather_facts: False

View file

@ -1,5 +1,6 @@
---
- hosts: os_control:os_control_stg
- name: Make the app be real
hosts: os_control:os_control_stg
user: root
gather_facts: false

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control:os_control_stg
user: root
gather_facts: false

View file

@ -1,5 +1,6 @@
---
- hosts: os_control_stg #:os_control
- name: Make the app be real
hosts: os_control_stg #:os_control
user: root
gather_facts: false

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg
user: root
gather_facts: False

View file

@ -3,7 +3,7 @@
#
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -24,7 +24,7 @@
owner: fmn
encoding: UTF-8
- name: setup RabbitMQ
- name: Setup RabbitMQ
hosts: rabbitmq[0]:rabbitmq_stg[0]
user: root
gather_facts: False
@ -100,7 +100,7 @@
- fedora-messaging
- rabbitmq_cluster
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -4,7 +4,7 @@
user: root
tasks:
- name: install psycopg2 for the postgresql ansible modules
- name: Install psycopg2 for the postgresql ansible modules
package: name=python3-psycopg2 state=present
tags:
- packages

View file

@ -1,4 +1,4 @@
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -9,18 +9,18 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
tasks:
- name: kerneltest DB user
- name: Kerneltest DB user
postgresql_user:
name: "{{ (env == 'production')|ternary(kerneltest_db_user,kerneltest_stg_db_user) }}"
password: "{{ (env == 'production')|ternary(kerneltest_db_pass,kerneltest_stg_db_pass) }}"
- name: kerneltest database creation
- name: Kerneltest database creation
postgresql_db:
name: "{{ kerneltest_db_name }}"
owner: "{{ (env == 'production')|ternary(kerneltest_db_user,kerneltest_stg_db_user) }}"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: False
@ -31,7 +31,8 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
pre_tasks:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: Include Global Variables
include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
roles:

View file

@ -1,4 +1,4 @@
- name: provision koschei
- name: Provision koschei
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False
@ -70,28 +70,28 @@
- delete
post_tasks:
- name: run initial f.10 import
- name: Run initial f.10 import
command: "oc -n languages create job stats-10-{{ lookup('pipe','date +%s') }}-init --from=cronjob/stats-10"
tags:
- never
- init
- f10
- name: run initial f.20 import
- name: Run initial f.20 import
command: "oc -n languages create job stats-20-{{ lookup('pipe','date +%s') }}-init --from=cronjob/stats-20"
tags:
- never
- init
- f20
- name: run initial f.30 import
- name: Run initial f.30 import
command: "oc -n languages create job stats-30-{{ lookup('pipe','date +%s') }}-init --from=cronjob/stats-30"
tags:
- never
- init
- f30
- name: run initial f.latest import
- name: Run initial f.latest import
command: "oc -n languages create job stats-latest-{{ lookup('pipe','date +%s') }}-init --from=cronjob/stats-latest"
tags:
- never

View file

@ -1,4 +1,4 @@
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -9,17 +9,17 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
tasks:
- name: maubot DB user
- name: Maubot DB user
postgresql_user:
name: maubot
password: "{{ (env == 'production')|ternary(maubot_prod_db_password, maubot_stg_db_password) }}"
- name: maubot database creation
- name: Maubot database creation
postgresql_db:
name: maubot
owner: maubot
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,6 +1,6 @@
# Create the RabbitMQ users
- name: setup RabbitMQ
- name: Setup RabbitMQ
hosts: rabbitmq[0]:rabbitmq_stg[0]:rabbitmq01.iad2.fedoraproject.org
user: root
gather_facts: False
@ -75,7 +75,7 @@
# Now create the app
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -3,7 +3,7 @@
#
---
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -25,7 +25,7 @@
owner: "{{ (env == 'production')|ternary(mirrormanager_db_user, mirrormanager_stg_db_user) }}"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg:os_control
user: root
gather_facts: false

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -13,7 +13,8 @@
- openscanhub_sent_topics: ^org\.fedoraproject\.{{ env_short }}\.openscanhub\..*
pre_tasks:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: Include Global Variables
include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
roles:
- role: openshift/project

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
# We don't have any VPN set up on stg
hosts: os_control[0]
user: root

View file

@ -1,15 +1,15 @@
- name: prepare setting up the database
- name: Prepare setting up the database
hosts: db01.stg.iad2.fedoraproject.org:db01.iad2.fedoraproject.org
gather_facts: no
user: root
tasks:
- name: install psycopg2 for the postgresql ansible modules
- name: Install psycopg2 for the postgresql ansible modules
package: name=python3-psycopg2 state=present
tags:
- packages
- name: setup the database
- name: Setup the database
hosts: db01.stg.iad2.fedoraproject.org:db01.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -35,7 +35,7 @@
owner: "{{ oraculum_db_user }}"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
# hosts: os_control[0]:os_control_stg[0]
hosts: os_control_stg[0]
user: root
@ -11,13 +11,15 @@
- /srv/web/infra/ansible/vars/apps/poddlers.yml
pre_tasks:
- include_role:
- name: Setup Rabbit User
include_role:
name: rabbit/user
vars:
username: toddlers{{ env_suffix }}
sent_topics: ^org\.fedoraproject\.{{ env_short }}\.toddlers\..*
- include_role:
- name: Setup Rabbit Queue
include_role:
name: rabbit/queue
vars:
username: toddlers{{ env_suffix }}

View file

@ -1,6 +1,6 @@
# Deploy the app
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,5 +1,5 @@
---
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -10,24 +10,24 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
tasks:
- name: resultsdb DB user - prod
- name: Resultsdb DB user - prod
postgresql_user:
name: "resultsdb"
password: "{{ prod_resultsdb_db_password }}"
when: env != 'staging'
- name: resultsdb DB user - staging
- name: Resultsdb DB user - staging
postgresql_user:
name: "resultsdb"
password: "{{ stg_resultsdb_db_password }}"
when: env == 'staging'
- name: resultsdb database creation
- name: Resultsdb database creation
postgresql_db:
name: "resultsdb"
owner: "resultsdb"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: no

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_masters[0]:os_masters_stg[0]
user: root
gather_facts: False

View file

@ -1,15 +1,15 @@
- name: prepare setting up the database
- name: Prepare setting up the database
hosts: db01.stg.iad2.fedoraproject.org:db01.iad2.fedoraproject.org
gather_facts: no
user: root
tasks:
- name: install psycopg2 for the postgresql ansible modules
- name: Install psycopg2 for the postgresql ansible modules
package: name=python3-psycopg2 state=present
tags:
- packages
- name: setup the database
- name: Setup the database
hosts: db01.stg.iad2.fedoraproject.org:db01.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -49,7 +49,7 @@
owner: "{{ resultsdb_testdays_db_user }}"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control_stg[0]:os_control[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,4 +1,4 @@
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -9,24 +9,24 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
tasks:
- name: waiverdb DB user - prod
- name: Waiverdb DB user - prod
postgresql_user:
name: "waiverdb"
password: "{{ prod_waiverdb_db_password }}"
when: env != 'staging'
- name: waiverdb DB user - staging
- name: Waiverdb DB user - staging
postgresql_user:
name: "waiverdb"
password: "{{ stg_waiverdb_db_password }}"
when: env == 'staging'
- name: waiverdb database creation
- name: Waiverdb database creation
postgresql_db:
name: "waiverdb"
owner: "waiverdb"
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -2,7 +2,7 @@
# Webhook to Fedora Messaging
#
- name: setup the database
- name: Setup the database
hosts: db01.iad2.fedoraproject.org:db01.stg.iad2.fedoraproject.org
gather_facts: no
become: yes
@ -13,17 +13,17 @@
- /srv/web/infra/ansible/vars/{{ ansible_distribution }}.yml
tasks:
- name: webhook2fedmsg DB user
- name: Webhook2fedmsg DB user
postgresql_user:
name: webhook2fedmsg
password: "{{ (env == 'production')|ternary(webhook2fedmsg_prod_db_password, webhook2fedmsg_stg_db_password) }}"
- name: webhook2fedmsg database creation
- name: Webhook2fedmsg database creation
postgresql_db:
name: webhook2fedmsg
owner: webhook2fedmsg
encoding: UTF-8
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False

View file

@ -1,5 +1,5 @@
---
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: false

View file

@ -1,4 +1,4 @@
- name: make the app be real
- name: Make the app be real
hosts: os_control[0]:os_control_stg[0]
user: root
gather_facts: False