Yum allowed state=installed. Lets use state=present consistently

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>

roles/abrt/faf/tasks/celery.yml

@@ -1,11 +1,11 @@
 - name: install faf web celery packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_web_celery_packages }}"
   tags:
   - packages
 
 - name: install redis package
-  yum : name={{ item }} state=installed
+  yum : name={{ item }} state=present
   with_items:
   - redis
   - python-redis

roles/abrt/faf/tasks/install.yml

@@ -8,37 +8,37 @@
   when: faf_force_reinstall
 
 - name: install core faf packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_packages }}"
 
 - name: install faf problem packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_problem_packages }}"
 
 - name: install faf opsys packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_opsys_packages }}"
 
 - name: install faf action packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_action_packages }}"
 
 - name: install faf bugtracker packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_bugtracker_packages }}"
   when: faf_with_bugtrackers
 
 - name: install faf celery packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_celery_packages }}"
   when: faf_with_celery
 
 - name: install faf fedmsg packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_fedmsg_packages }}"
   when: faf_with_fedmsg
 
 - name: install faf solutionfinder packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_solutionfinder_packages }}"
   when: faf_with_solutionfinders

roles/abrt/faf/tasks/web.yml

@@ -15,7 +15,7 @@
   when: faf_with_celery
 
 - name: install faf web symboltransfer packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items: "{{ faf_web_symboltransfer_packages }}"
   when: faf_with_symboltransfer
 

roles/abrt/retrace/tasks/install.yml

@@ -4,4 +4,4 @@
   when: rs_force_reinstall
 
 - name: install retrace-server package
-  yum : name=retrace-server state=installed
+  yum : name=retrace-server state=present

roles/ansible-ansible-openshift-ansible/tasks/main.yml

@@ -3,7 +3,7 @@
 #
 
 - name: Install required packages
-  package: name="{{ item }}" state=installed
+  package: name="{{ item }}" state=present
   with_items:
     - ansible
     - git

roles/docker-distribution/tasks/main.yml

@@ -2,7 +2,7 @@
 # tasks file for docker-distribution
 
 - name: install docker-distribution
-  action: "{{ ansible_pkg_mgr }} name=docker-distribution state=installed"
+  action: "{{ ansible_pkg_mgr }} name=docker-distribution state=present"
   tags:
   - docker-distribution
 

roles/download/tasks/main.yml

@@ -97,7 +97,7 @@
   - reload httpd
 
 - name: Install haveged for entropy
-  package: name=haveged state=installed
+  package: name=haveged state=present
   tags:
   - httpd
   - httpd/proxy

roles/fas3_server/tasks/main.yml

@@ -9,7 +9,7 @@
   - yumrepos
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - fas
   - fas-theme-fedoraproject

roles/fas_server/tasks/main.yml

@@ -2,7 +2,7 @@
 # Tasks to set up fas_server
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - fas
   - fas-plugin-yubikey
@@ -17,7 +17,7 @@
   - fas
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - krb5-workstation
   - python-requests-kerberos

roles/fedimg/tasks/main.yml

@@ -2,7 +2,7 @@
 # Configuration for the notifications consumer
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - koji
   - fedmsg

roles/fedmsg/gateway/slave/tasks/main.yml

@@ -2,7 +2,7 @@
 # Tasks to set up fedmsg-gateway-slave
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - fedmsg-gateway
   - stunnel

roles/haproxy/tasks/main.yml

@@ -2,7 +2,7 @@
 # Tasks to set up haproxy
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - haproxy
   tags:
@@ -41,7 +41,7 @@
   - haproxy
 
 - name: Install libsemanage-python so we can manage selinux with python...
-  package: name=libsemanage-python state=installed
+  package: name=libsemanage-python state=present
   tags:
   - haproxy
   - selinux

roles/httpd/mod_ssl/tasks/main.yml

@@ -1,5 +1,5 @@
 - name: Install mod_ssl
-  package: name=mod_ssl state=installed
+  package: name=mod_ssl state=present
   notify:
   - reload proxyhttpd
   tags:
@@ -20,7 +20,7 @@
   - httpd/certificate
 
 - name: Install haveged for entropy
-  package: name=haveged state=installed
+  package: name=haveged state=present
   tags:
   - httpd
   - httpd/proxy

roles/httpd/proxy/tasks/main.yml

@@ -48,7 +48,7 @@
   - httpd/proxy
 
 - name: Install libsemanage-python so we can manage selinux with python...
-  package: name=libsemanage-python state=installed
+  package: name=libsemanage-python state=present
   tags:
   - httpd
   - httpd/proxy

roles/jenkins/master/tasks/main.yml

@@ -10,7 +10,7 @@
   - yumrepos
 
 - name: install packages
-  dnf: name={{ item }} state=installed
+  dnf: name={{ item }} state=present
   with_items:
   - jenkins
   - jenkins-openid-plugin

roles/jenkins/slave/tasks/main.yml

@@ -1,5 +1,5 @@
 - name: install common slave packages (dnf)
-  dnf: name={{ item }} state=installed
+  dnf: name={{ item }} state=present
   with_items: "{{ slave_packages_common }}"
   when: ansible_distribution_major_version|int > 21
   tags:
@@ -8,7 +8,7 @@
   - packages
 
 - name: install common slave packages (yum)
-  package: name={{ item }} state=installed
+  package: name={{ item }} state=present
   with_items: "{{ slave_packages_common }}"
   when: ansible_distribution_major_version|int < 22
   tags:
@@ -17,7 +17,7 @@
   - packages
 
 - name: install distro-specific slave packages (fedora, dnf)
-  dnf: name={{ item }} state=installed
+  dnf: name={{ item }} state=present
   with_items: "{{ slave_packages_fedora }}"
   when: ansible_distribution_major_version|int > 21
   tags:
@@ -26,7 +26,7 @@
   - packages
 
 - name: install distro-specific slave packages (centos, yum)
-  package: name={{ item }} state=installed
+  package: name={{ item }} state=present
   with_items: "{{ slave_packages_centos }}"
   when: ansible_distribution_major_version|int < 8
   tags:
@@ -35,7 +35,7 @@
   - packages
 
 - name: install el7 specific slave packages
-  package: name={{ item }} state=installed
+  package: name={{ item }} state=present
   with_items: "{{ el7_only }}"
   when: ansible_distribution_major_version|int == 7
   tags:
@@ -44,7 +44,7 @@
   - packages
 
 - name: install f25 specific slave packages
-  dnf: name={{ item }} state=installed
+  dnf: name={{ item }} state=present
   with_items: "{{ f25_only }}"
   when: ansible_distribution_major_version|int == 25
   tags:
@@ -53,7 +53,7 @@
   - packages
 
 - name: install f24 specific slave packages
-  dnf: name={{ item }} state=installed
+  dnf: name={{ item }} state=present
   with_items: "{{ f24_only }}"
   when: ansible_distribution_major_version|int == 24
   tags:
@@ -80,7 +80,7 @@
 # Haveged is not needed per se, but very useful for builds that require lots of entropy
 # Hello, Ipsilon
 - name: install haveged
-  dnf: name=haveged state=installed
+  dnf: name=haveged state=present
   when: is_fedora is defined and ansible_distribution_major_version|int > 21
   tags:
   - jenkins

roles/koschei/backend/tasks/main.yml

@@ -1,5 +1,5 @@
 - name: install packages
-  package: name={{ item }} state=installed
+  package: name={{ item }} state=present
   with_items:
   - koschei-admin
   - koschei-backend

roles/koschei/frontend/tasks/main.yml

@@ -1,5 +1,5 @@
 - name: install packages
-  package: name={{ item }} state=installed
+  package: name={{ item }} state=present
   with_items:
   - koschei-frontend
   - koschei-frontend-fedora

roles/loopabull/tasks/main.yml

@@ -2,7 +2,7 @@
 # tasks file for loopabull
 
 - name: Install required packages
-  package: name="{{ item }}" state=installed
+  package: name="{{ item }}" state=present
   with_items:
     - git
     - loopabull

roles/osbs-client/tasks/main.yml

@@ -2,7 +2,7 @@
 # tasks file for osbs-client
 
 - name: install osbs-client package
-  action: "{{ ansible_pkg_mgr }} name=osbs-client state=installed"
+  action: "{{ ansible_pkg_mgr }} name=osbs-client state=present"
 
 - name: apply osbs-client templated config
   template: src=osbs.conf.j2 dest={{ osbs_client_conf_path }} mode=0640

roles/osbs-common/tasks/main.yml

@@ -4,7 +4,7 @@
   when: hostname is defined
 
 - name: install basic packages
-  action: "{{ ansible_pkg_mgr }} name={{ item }} state=installed"
+  action: "{{ ansible_pkg_mgr }} name={{ item }} state=present"
   with_items:
   - vim
   - tmux
@@ -14,7 +14,7 @@
   - tree
 
 - name: install yum-utils when using yum
-  package: name=yum-utils state=installed
+  package: name=yum-utils state=present
   when: ansible_pkg_mgr == "yum"
 
 - name: enable rhel7 repos
@@ -25,11 +25,11 @@
   when: ansible_distribution == 'RedHat' and ansible_distribution_major_version == '7'
 
 - name: enable epel7
-  package: name={{ epel7_url }} state=installed
+  package: name={{ epel7_url }} state=present
   when: ansible_os_family == 'RedHat' and ansible_distribution_major_version == '7'
 
 - name: install firewalld
-  action: "{{ ansible_pkg_mgr }} name=firewalld state=installed"
+  action: "{{ ansible_pkg_mgr }} name=firewalld state=present"
   when: osbs_manage_firewalld
 
 - name: enable firewalld

roles/people/tasks/main.yml

@@ -36,7 +36,7 @@
   - people
 
 - name: Install haveged for entropy
-  package: name=haveged state=installed
+  package: name=haveged state=present
   tags:
   - httpd
   - httpd/proxy

roles/push-docker/tasks/main.yml

@@ -2,7 +2,7 @@
 # tasks file for push-docker
 #
 - name: install docker
-  action: "{{ ansible_pkg_mgr }} name=docker state=installed"
+  action: "{{ ansible_pkg_mgr }} name=docker state=present"
 
 - name: ensure docker daemon cert dir exists
   file:

roles/s3-mirror/tasks/main.yml

@@ -8,7 +8,7 @@
   template: src=s3cfg dest=/home/s3-mirror/.s3cfg owner=s3-mirror group=s3-mirror mode=0600
 
 - name: Install packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - s3cmd
   - mirrormanager2-client

roles/varnish/tasks/main.yml

@@ -2,7 +2,7 @@
 # Tasks to set up varnish
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - libsemanage-python
   - varnish

roles/yubikey/tasks/main.yml

@@ -2,7 +2,7 @@
 # Tasks to set up yubikey_verifier
 
 - name: install needed packages
-  package: pkg={{ item }} state=installed
+  package: pkg={{ item }} state=present
   with_items:
   - yubikey-ksm
   - yubikey-val