Save or cache calls to bodhi.get_active_branches()
#346
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On staging (and probably prod but I didn't check) there's a ton on calls to
/releases/?exclude_archived=True
. I think it comes from toddlers. There are places here that can spare quite a few calls tobodhi.get_active_branches()
, as they are done inside loops but will always return the same thing.There's calls in
clean_retired_packages
, indistgit_bugzilla_sync
and inkoji_block_retired
.These calls could be done only once or/and cached with dogpile.
Maybe we can do the caching directly in bodhi module
Yeah that would be a possible improvement. We can easily cache this value for an hour, and the caching infrastructure is already in place (
dogpile
).