Infrastructure/toddlers
3
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Wiki Activity Actions

koji_retired_packages: fix tests

Browse source 
Signed-off-by: Lenka Segura <lsegura@redhat.com>
This commit is contained in:
Lenka Segura 2024-07-11 15:09:30 +02:00
parent ca595a3846
commit cc277eaaf8
2 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/plugins/test_koji_block_retired.py
View file

@ -3,7 +3,7 @@ Unit tests for `toddler.plugins.koji_block_retired`
""" """
import logging import logging
from unittest import mock from unittest.mock import MagicMock
import koji import koji
import pytest import pytest
@ -56,7 +56,7 @@ class TestProcess:
config = {"key": "value"} config = {"key": "value"}
message = "Example message" message = "Example message"
self.toddler_cls.process_block_retired = mock.MagicMock() self.toddler_cls.process_block_retired = MagicMock()
self.toddler_cls.process(config, message) self.toddler_cls.process(config, message)
self.toddler_cls.process_block_retired.assert_called_once_with(config, message) self.toddler_cls.process_block_retired.assert_called_once_with(config, message)
@ -70,16 +70,16 @@ class TestProcessBlockRetired:
def setup_method(self): def setup_method(self):
"""Initialize toddler.""" """Initialize toddler."""
self.toddler_cls = koji_block_retired.KojiBlockRetired() self.toddler_cls = koji_block_retired.KojiBlockRetired()
self.toddler_cls.koji_session = mock.MagicMock() self.toddler_cls.koji_session = MagicMock()
def test_no_dead_package_file(self, caplog): def test_no_dead_package_file(self, caplog):
""" """
Assert that if no dead package was added the plugin stops. Assert that if no dead package was added the plugin stops.
""" """
caplog.set_level(logging.INFO) caplog.set_level(logging.INFO)
message = mock.MagicMock() message = MagicMock()
message.body = {"commit": {"stats": {"files": {}}}} message.body = {"commit": {"stats": {"files": {}}}}
config = mock.MagicMock() config = MagicMock()
config = {"profile": "stg"} config = {"profile": "stg"}
self.toddler_cls.process_block_retired(config, message) self.toddler_cls.process_block_retired(config, message)
assert caplog.records[-1].message == "No dead.package in the commit, bailing" assert caplog.records[-1].message == "No dead.package in the commit, bailing"
@ -89,13 +89,13 @@ class TestProcessBlockRetired:
Assert if in commit dead package wasn't added the plugin stops. Assert if in commit dead package wasn't added the plugin stops.
""" """
caplog.set_level(logging.INFO) caplog.set_level(logging.INFO)
message = mock.MagicMock() message = MagicMock()
message.body = { message.body = {
"commit": { "commit": {
"stats": {"files": {"dead.package": {"additions": 0, "deletions": 1}}} "stats": {"files": {"dead.package": {"additions": 0, "deletions": 1}}}
} }
} }
config = mock.MagicMock() config = MagicMock()
config = {"profile": "stg"} config = {"profile": "stg"}
self.toddler_cls.process_block_retired(config, message) self.toddler_cls.process_block_retired(config, message)
assert caplog.records[-1].message == "dead.package file was not added, bailing" assert caplog.records[-1].message == "dead.package file was not added, bailing"
@ -106,7 +106,7 @@ class TestProcessBlockRetired:
""" """
caplog.set_level(logging.INFO) caplog.set_level(logging.INFO)
message = mock.MagicMock() message = MagicMock()
message.body = { message.body = {
"commit": { "commit": {
"stats": {"files": {"dead.package": {"additions": 1, "deletions": 0}}}, "stats": {"files": {"dead.package": {"additions": 1, "deletions": 0}}},
@ -115,7 +115,7 @@ class TestProcessBlockRetired:
"namespace": "example_ns", "namespace": "example_ns",
} }
} }
config = mock.MagicMock() config = MagicMock()
config = {"profile": "stg"} config = {"profile": "stg"}
self.toddler_cls.process_block_retired(config, message) self.toddler_cls.process_block_retired(config, message)
self.toddler_cls.koji_session.packageListBlock.assert_called_once_with( self.toddler_cls.koji_session.packageListBlock.assert_called_once_with(
@ -128,7 +128,7 @@ class TestProcessBlockRetired:
Assert that method will process correctly with different branches. Assert that method will process correctly with different branches.
""" """
caplog.set_level(logging.INFO) caplog.set_level(logging.INFO)
message = mock.MagicMock() message = MagicMock()
message.body = { message.body = {
"commit": { "commit": {
"stats": {"files": {"dead.package": {"additions": 1, "deletions": 0}}}, "stats": {"files": {"dead.package": {"additions": 1, "deletions": 0}}},
@ -137,7 +137,7 @@ class TestProcessBlockRetired:
"namespace": "example_ns", "namespace": "example_ns",
} }
} }
config = mock.MagicMock() config = MagicMock()
config = {"profile": "stg"} config = {"profile": "stg"}
self.toddler_cls.process_block_retired(config, message) self.toddler_cls.process_block_retired(config, message)
self.toddler_cls.koji_session.packageListBlock.assert_called_once_with( self.toddler_cls.koji_session.packageListBlock.assert_called_once_with(
@ -149,7 +149,7 @@ class TestProcessBlockRetired:
""" """
Assert that Koji generic error will be handled correctly. Assert that Koji generic error will be handled correctly.
""" """
message = mock.MagicMock() message = MagicMock()
message.body = { message.body = {
"commit": { "commit": {
"stats": {"files": {"dead.package": {"additions": 1, "deletions": 0}}}, "stats": {"files": {"dead.package": {"additions": 1, "deletions": 0}}},
@ -158,7 +158,7 @@ class TestProcessBlockRetired:
"namespace": "example_ns", "namespace": "example_ns",
} }
} }
config = mock.MagicMock() config = MagicMock()
config = {"profile": "stg"} config = {"profile": "stg"}
self.toddler_cls.koji_session.packageListBlock.side_effect = koji.GenericError( self.toddler_cls.koji_session.packageListBlock.side_effect = koji.GenericError(
"Failed" "Failed"

4
toddlers/plugins/koji_block_retired.py
View file

@ -139,7 +139,9 @@ def main(args):
# Either from a file # Either from a file
with open(msg_file, "r") as stream: with open(msg_file, "r") as stream:
msg = json.load(stream) msg = json.load(stream)
commit_msg = CommitV1(body=msg["body"], headers=msg["headers"], topic=msg["topic"]) commit_msg = CommitV1(
body=msg["body"], headers=msg["headers"], topic=msg["topic"]
)
else: else:
# Or edit this dict to match your needs # Or edit this dict to match your needs
body = {"commit": {"branch": "rawhide", "stats": {"files": {}}}, "repo": "repo"} body = {"commit": {"branch": "rawhide", "stats": {"files": {}}}, "repo": "repo"}