Infrastructure/toddlers
1
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Make the tests flake8 valid and enforce it in tox

Browse source 
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
This commit is contained in:
Pierre-Yves Chibon 2020-06-26 15:45:09 +02:00 • committed by pingou
parent 08a76aefab
commit 7af467ef1d
5 changed files with 39 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

34
tests/plugins/test_flag_commit_build.py
View file

@ -11,7 +11,7 @@ class TestFlagCommitBuildToddler:
def test_accepts_topic_invalid(self):
assert (
toddlers.plugins.flag_commit_build.FlagCommitBuild.accepts_topic("foo.bar")
== False
is False
)
@pytest.mark.parametrize(
@ -23,10 +23,7 @@ class TestFlagCommitBuildToddler:
],
)
def test_accepts_topic_valid(self, topic):
assert (
toddlers.plugins.flag_commit_build.FlagCommitBuild.accepts_topic(topic)
== True
)
assert toddlers.plugins.flag_commit_build.FlagCommitBuild.accepts_topic(topic)
def test_process_containerbuild(self, caplog):
caplog.set_level(logging.INFO)
@ -38,7 +35,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config={}, message=msg
)
== None
is None
)
assert caplog.records[-1].message == "Skipping container build"
@ -52,7 +49,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config={}, message=msg
)
== None
is None
)
assert caplog.records[-1].message == "Skipping MBS builds"
@ -69,7 +66,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config={}, message=msg
)
== None
is None
)
assert caplog.records[-1].message == "Ignoring secondary arch task..."
@ -87,7 +84,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config={}, message=msg
)
== None
is None
)
assert (
caplog.records[-1].message
@ -114,7 +111,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config=config, message=msg
)
== None
is None
)
assert (
caplog.records[-1].message
@ -143,7 +140,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config=config, message=msg
)
== None
is None
)
assert caplog.records[-1].message == "No # in the git_url: foobar"
@ -158,7 +155,8 @@ class TestFlagCommitBuildToddler:
return_value={
"extra": {
"source": {
"original_url": "https://src.fedoraproject.org/rpms/guake.git#commit_hash123"
"original_url": "https://src.fedoraproject.org/rpms/"
"guake.git#commit_hash123"
}
}
}
@ -188,7 +186,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config=config, message=msg
)
== None
is None
)
assert (
caplog.records[-1].message
@ -206,7 +204,8 @@ class TestFlagCommitBuildToddler:
return_value={
"extra": {
"source": {
"original_url": "https://src.fedoraproject.org/rpms/guake.git#commit_hash123"
"original_url": "https://src.fedoraproject.org/rpms/"
"guake.git#commit_hash123"
}
}
}
@ -236,7 +235,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config=config, message=msg
)
== None
is None
)
assert (
caplog.records[-1].message
@ -254,7 +253,8 @@ class TestFlagCommitBuildToddler:
return_value={
"extra": {
"source": {
"original_url": "https://src.fedoraproject.org/rpms/guake.git#commit_hash123"
"original_url": "https://src.fedoraproject.org/rpms/"
"guake.git#commit_hash123"
}
}
}
@ -283,7 +283,7 @@ class TestFlagCommitBuildToddler:
toddlers.plugins.flag_commit_build.FlagCommitBuild.process(
config=config, message=msg
)
== None
is None
)
assert (
caplog.records[-3].message