Infrastructure/toddlers
1
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Correctly convert bugzilla date to arrow

Browse source 
Bugzilla returns xmlrpc.client.DateTime object instead of just datetime. Let's
adjust the conversion to this fact.

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
This commit is contained in:
Michal Konečný 2022-08-24 15:33:03 +02:00
parent 869e71ba92
commit 4a9894c86a
2 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/plugins/test_scm_request_processor.py
View file

@ -5,6 +5,7 @@ import json
import logging
import re
from unittest.mock import call, MagicMock, Mock, patch
import xmlrpc.client
import arrow
from pagure_messages.issue_schema import IssueCommentAddedV1, IssueNewV1
@ -2572,9 +2573,9 @@ class TestValidateReviewBug:
"name": "fedora-review",
"status": "",
"setter": assignee,
"modification_date": arrow.utcnow()
.shift(days=-61)
.format("YYYY-MM-DDTHH-mm-ssZ"),
"modification_date": xmlrpc.client.DateTime(
arrow.utcnow().shift(days=-61).datetime
),
}
]
@ -2687,7 +2688,7 @@ class TestValidateReviewBug:
"name": "fedora-review",
"status": "+",
"setter": assignee,
"modification_date": arrow.utcnow().format("YYYY-MM-DDTHH-mm-ssZ"),
"modification_date": xmlrpc.client.DateTime(arrow.utcnow().datetime),
}
]
@ -2743,7 +2744,7 @@ class TestValidateReviewBug:
"name": "fedora-review",
"status": "+",
"setter": assignee,
"modification_date": arrow.utcnow().format("YYYY-MM-DDTHH-mm-ssZ"),
"modification_date": xmlrpc.client.DateTime(arrow.utcnow().datetime),
},
{
"name": "random-flag",

2
toddlers/plugins/scm_request_processor.py
View file

@ -963,7 +963,7 @@ class SCMRequestProcessor(ToddlerBase):
update_dt = flag.get("modification_date")
if update_dt:
dt = arrow.get(update_dt, "YYYY-MM-DDTHH-mm-ssZ")
dt = arrow.get(update_dt.value, "YYYYMMDDTHH:mm:ss")
delta = arrow.utcnow().date() - dt.date()
if delta.days > 60:
raise ValidationError(