Infrastructure/toddlers
1
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Don't hardcode src.fedoraproject.org

Browse source 
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
This commit is contained in:
Aurélien Bompard 2024-12-17 16:17:38 +01:00
parent 1bfdebd297
commit 0fcdd3b95d
No known key found for this signature in database
GPG key ID: 31584CFEB9BF64AD
5 changed files with 53 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

68
tests/plugins/test_check_commit_rights.py
View file

@ -6,6 +6,17 @@ import pytest
import toddlers.plugins.check_commit_rights
@pytest.fixture
def toddler_config():
return {
"exclude_users": "[]",
"notify_emails": "[]",
"admin_email": "foo@bar",
"mail_server": "127.0.0.1",
"dist_git_url": "https://src.fedoraproject.org",
}
class TestCheckCommitRightsToddler:
toddler_cls = toddlers.plugins.check_commit_rights.CheckCommitRights
@ -49,7 +60,7 @@ class TestCheckCommitRightsToddler:
@patch("toddlers.utils.fedora_account.set_fasjson", new=Mock(return_value=True))
@patch("toddlers.utils.fedora_account.get_group_member")
def test_process_no_fas(self, get_group_member, toddler):
def test_process_no_fas(self, get_group_member, toddler, toddler_config):
get_group_member.return_value = []
msg = fedora_messaging.api.Message()
@ -57,22 +68,19 @@ class TestCheckCommitRightsToddler:
msg.topic = "org.fedoraproject.prod.toddlers.trigger.check_commit_rights"
msg.body = {"foo": "bar"}
config = {
"exclude_users": "[]",
"notify_emails": "[]",
}
with pytest.raises(
Exception,
match=r"Something wrong occurred, I found no packagers. Exiting.",
):
toddler.process(config=config, message=msg, send_email=False)
toddler.process(config=toddler_config, message=msg, send_email=False)
@patch("toddlers.utils.fedora_account.set_fasjson", new=Mock(return_value=True))
@patch("toddlers.plugins.check_commit_rights._log.info")
@patch("toddlers.utils.notify.send_email")
@patch("toddlers.utils.fedora_account.get_group_member")
def test_process_all_right(self, get_group_member, send_email, info, toddler):
def test_process_all_right(
self, get_group_member, send_email, info, toddler, toddler_config
):
req_json = {
"pagination": {
"page": 1,
@ -104,14 +112,7 @@ class TestCheckCommitRightsToddler:
msg.topic = "org.fedoraproject.prod.toddlers.trigger.check_commit_rights"
msg.body = {"foo": "bar"}
config = {
"exclude_users": "[]",
"notify_emails": "[]",
"admin_email": "foo@bar",
"mail_server": "127.0.0.1",
}
assert toddler.process(config=config, message=msg) is None
assert toddler.process(config=toddler_config, message=msg) is None
info.assert_any_call(
"### Found 4 users with commit privileges but not in packager group ###"
)
@ -128,7 +129,7 @@ class TestCheckCommitRightsToddler:
@patch("toddlers.utils.notify.send_email")
@patch("toddlers.utils.fedora_account.get_group_member")
def test_process_all_right_multiple_pages(
self, get_group_member, send_email, info, toddler
self, get_group_member, send_email, info, toddler, toddler_config
):
req_json = [
{
@ -181,14 +182,7 @@ class TestCheckCommitRightsToddler:
msg.topic = "org.fedoraproject.prod.toddlers.trigger.check_commit_rights"
msg.body = {"foo": "bar"}
config = {
"exclude_users": "[]",
"notify_emails": "[]",
"admin_email": "foo@bar",
"mail_server": "127.0.0.1",
}
assert toddler.process(config=config, message=msg) is None
assert toddler.process(config=toddler_config, message=msg) is None
info.assert_any_call(
"### Found 2 users with commit privileges but not in packager group ###"
)
@ -202,7 +196,9 @@ class TestCheckCommitRightsToddler:
@patch("toddlers.plugins.check_commit_rights._log.info")
@patch("toddlers.utils.notify.send_email")
@patch("toddlers.utils.fedora_account.get_group_member")
def test_process_exclude_user(self, get_group_member, send_email, info, toddler):
def test_process_exclude_user(
self, get_group_member, send_email, info, toddler, toddler_config
):
req_json = {
"pagination": {
"page": 1,
@ -234,14 +230,9 @@ class TestCheckCommitRightsToddler:
msg.topic = "org.fedoraproject.prod.toddlers.trigger.check_commit_rights"
msg.body = {"foo": "bar"}
config = {
"exclude_users": "['admin_user']",
"notify_emails": "[]",
"admin_email": "foo@bar",
"mail_server": "127.0.0.1",
}
toddler_config["exclude_users"] = ["admin_user"]
assert toddler.process(config=config, message=msg) is None
assert toddler.process(config=toddler_config, message=msg) is None
info.assert_any_call(
"### Found 3 users with commit privileges but not in packager group ###"
)
@ -256,7 +247,9 @@ class TestCheckCommitRightsToddler:
@patch("toddlers.plugins.check_commit_rights._log.info")
@patch("toddlers.utils.notify.send_email")
@patch("toddlers.utils.fedora_account.get_group_member")
def test_process_no_result(self, get_group_member, send_email, info, toddler):
def test_process_no_result(
self, get_group_member, send_email, info, toddler, toddler_config
):
req_json = {
"pagination": {
"page": 1,
@ -288,12 +281,7 @@ class TestCheckCommitRightsToddler:
msg.topic = "org.fedoraproject.prod.toddlers.trigger.check_commit_rights"
msg.body = {"foo": "bar"}
config = {
"exclude_users": "[]",
"notify_emails": "[]",
}
assert toddler.process(config=config, message=msg) is None
assert toddler.process(config=toddler_config, message=msg) is None
info.assert_any_call(
"### Found 0 users with commit privileges but not in packager group ###"
)