diff --git a/README.rst b/README.rst index c358f27..a72b0b5 100644 --- a/README.rst +++ b/README.rst @@ -10,6 +10,15 @@ correspond `fedmsg`_ message. This repository stores the ansible playbooks and their related scripts used by the `Fedora`_ `Infrastructure`_ team. + +Good Practice +------------- + +Keep in mind that a playbook can be ran by multiple workers simultaneously, +therefore it is advised to keep all blocking tasks out of this repository (for +example: avoid installing packages) + + .. _Ansible: https://github.com/ansible/ansible .. _fedmsg: http://www.fedmsg.com/en/latest/ .. _Fedora: https://getfedora.org/ @@ -17,3 +26,4 @@ the `Fedora`_ `Infrastructure`_ team. .. _loopabull: https://github.com/maxamillion/loopabull .. _playbook: http://docs.ansible.com/ansible/playbooks.html + diff --git a/playbooks/roles/flag_build_commits/tasks/main.yml b/playbooks/roles/flag_build_commits/tasks/main.yml index 762f6a7..c84df5a 100644 --- a/playbooks/roles/flag_build_commits/tasks/main.yml +++ b/playbooks/roles/flag_build_commits/tasks/main.yml @@ -1,9 +1,3 @@ -- name: Install required packages - package: name="{{ item }}" state=present - with_items: - - python2-koji - - python2-requests - - name: Install script flagging commits on dist-git upon successful build copy: src: files/flag_commit_build.py diff --git a/playbooks/roles/flag_ci_pr/tasks/main.yml b/playbooks/roles/flag_ci_pr/tasks/main.yml index aa0546b..7f0d2f7 100644 --- a/playbooks/roles/flag_ci_pr/tasks/main.yml +++ b/playbooks/roles/flag_ci_pr/tasks/main.yml @@ -1,8 +1,3 @@ -- name: Install required packages - package: name="{{ item }}" state=present - with_items: - - python2-requests - - name: Install script flagging PRs on dist-git upon test results being published copy: src: files/flag_ci_pr.py