Infrastructure/generate_changelog
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve dict iteration and list reversal

Browse source 
- use dict.items() to get at keys and values in one go
- list.reverse() reverses the list in place, use reversed() instead

Signed-off-by: Nils Philippsen <nils@redhat.com>
This commit is contained in:
Nils Philippsen 2020-02-24 17:56:49 +01:00
parent bc99e99b0c
commit 81c50d20d0
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
rpmautospec/changelog.py
View file

@ -100,10 +100,9 @@ def main(args):
print("No more spec file, bailing") print("No more spec file, bailing")
break break
for nvr in data: for nvr, commits in data.items():
commits = data[nvr].reverse() for idx, commit in enumerate(reversed(commits)):
for idx, commit in enumerate(data[nvr]): last_commit = idx + 1 == len(commits)
last_commit = idx + 1 == len(data[nvr])
commit_dt = datetime.datetime.utcfromtimestamp(commit.commit_time) commit_dt = datetime.datetime.utcfromtimestamp(commit.commit_time)
wrapper = textwrap.TextWrapper(width=75, subsequent_indent=" ") wrapper = textwrap.TextWrapper(width=75, subsequent_indent=" ")
message = wrapper.fill(commit.message.split("\n")[0].strip("- ")) message = wrapper.fill(commit.message.split("\n")[0].strip("- "))