Enable opt-in gating on Greenwave

bowlofeggs commented

2018-10-16 19:01:23 +00:00

This is a ticket to track the work needed to get opt-in gating working. I haven't heard much about test gating in a while, so apologies if my information is out of date, but the last I heard about it we needed Factory2 to either deploy an update or a config change or both to Greenwave in order to allow packagers to opt-in to test gating.

@ralph do you know what the current state is? Is my information outdated?

CC @pfrields

This is a ticket to track the work needed to get opt-in gating working. I haven't heard much about test gating in a while, so apologies if my information is out of date, but the last I heard about it we needed Factory2 to either deploy an update or a config change or both to Greenwave in order to allow packagers to opt-in to test gating. @ralph do you know what the current state is? Is my information outdated? CC @pfrields

mizdebsk commented

2018-10-16 19:02:54 +00:00

Metadata Update from @mizdebsk:

Issue tagged with: factory2

**Metadata Update from @mizdebsk**: - Issue tagged with: factory2

pfrields commented

2018-10-16 19:03:21 +00:00

cc @dperpeet as well

mohanboddu commented

2018-10-16 21:09:21 +00:00

I guess we need to update https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/openshift-apps/greenwave/templates/configmap.yml#n108 to production as well.

ralph commented

2018-10-17 01:02:03 +00:00

I take it we are in freeze. We would need a FBR to change it.

edit to be clear: all we should need is that config change.

I take it we are in freeze. We would need a FBR to change it. *edit* to be clear: all we should need is that config change.

bowlofeggs commented

2018-10-18 21:16:46 +00:00

Author

@ralph Cool. I am not aware of how critical it is, so perhaps @pfrields can advise as to whether we should get an FBR, or whether we should just wait for F29 to release and the freeze to end. Note that F29 was no-go in today's meeting, so it will be at least 13 days from now before freeze is over.

ralph commented

2018-10-22 20:46:15 +00:00

OK. Will hang tight. :)

pingou commented

2018-10-23 08:26:11 +00:00

@pfrields @dperpeet would you like to weight in on whether we want a FBR or not for this change?

dperpeet commented

2018-10-23 08:47:19 +00:00

Since we only require a small change, I think it might be worth getting this in despite the freeze, especially since we're looking to introduce a process that can be opted into and out of fairly easily.

pfrields commented

2018-10-24 21:00:06 +00:00

Sorry, you guys cannot depend on me seeing Pagure pings to answer questions. Please reach out to me in the future. Having said that, cverna asked me and I think it's worth a FBR.

ralph commented

2018-10-29 13:35:27 +00:00

Well, time slipped by and now the release is tomorrow and the general thaw is on Wednesday. Let's just wait a few more days for that. I'll handle the update when time comes.

bstinson commented

2018-10-29 21:34:47 +00:00

Are we also planning on adding the allpackages pipeline topics to greenwave with this change?

I think that would be the last step needed and the STI test results will show in bodhi

Are we also planning on adding the allpackages pipeline topics to greenwave with this change? I *think* that would be the last step needed and the STI test results will show in bodhi

pingou commented

2018-10-30 10:26:23 +00:00

Are we also planning on adding the allpackages pipeline topics to greenwave with this change?
I think that would be the last step needed and the STI test results will show in bodhi

I believe the tests should show already (since ci-cc-resultsdb has been fixed), the piece about greenwave is about supporting opt-in gating (which would allow gating on the allpackages pipeline if these messages are in resultsdb)

> Are we also planning on adding the allpackages pipeline topics to greenwave with this change? > I think that would be the last step needed and the STI test results will show in bodhi I believe the tests should show already (since ci-cc-resultsdb has been fixed), the piece about greenwave is about supporting opt-in gating (which would allow gating on the allpackages pipeline if these messages are in resultsdb)

ralph commented

2018-10-31 20:48:34 +00:00

I didn't get a chance to do this today and won't again until Friday.

ralph commented

2018-11-02 20:49:08 +00:00

OK, it's in place.

Check out this update: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8046ebd005

It uses this gating.yaml file: https://src.fedoraproject.org/rpms/python-ansi2html/blob/master/f/gating.yaml

Notice that the greenwave decision (shown in bodhi) complains that two test cases are missing when it is really only one. It is just that it is counting the missing test twice (once from both decision contexts in the gating.yaml file). This has been fixed for a while in greenwave and is in the latest release. We should unpin greenwave from the 0.9.4 release and upgrade next week. (It is pinned in this file). @bowlofeggs, can you coordinate with @gnaponie and @lucarval on when would be a good time to do that?

It also seems that bodhi doesn't display the missing test like it should. Something in the javascript must be wrong. I see that missing_tests should be accounted for in the code there, but something is off.

OK, it's in place. Check out this update: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8046ebd005 It uses this `gating.yaml` file: https://src.fedoraproject.org/rpms/python-ansi2html/blob/master/f/gating.yaml Notice that the greenwave decision (shown in bodhi) complains that two test cases are missing when it is really only one. It is just that it is counting the missing test twice (once from both decision contexts in the gating.yaml file). This has been fixed for a while in greenwave and is in the latest release. We should unpin greenwave from the 0.9.4 release and upgrade next week. (It is pinned in [this file](https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/openshift-apps/greenwave/templates/imagestream.yml#n27)). @bowlofeggs, can you coordinate with @gnaponie and @lucarval on when would be a good time to do that? It also seems that bodhi doesn't *display* the missing test like it should. Something in the javascript must be wrong. I see that `missing_tests` should be accounted for in the code there, but something is off.

ralph commented

2018-11-02 20:51:47 +00:00

Metadata Update from @ralph:

Issue close_status updated to: Fixed
Issue status updated to: Closed (was: Open)

**Metadata Update from @ralph**: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)

bowlofeggs commented

2018-11-05 14:57:38 +00:00

Author

On Fri, 2018-11-02 at 20:49 +0000, Ralph Bean wrote:

@bowlofeggs, can you coordinate with @gnaponie and @lucarval on when
would be a good time to do that?

Any time is fine with me - with OpenShift it should be possible to
upgrade with no down time I presume?

On Fri, 2018-11-02 at 20:49 +0000, Ralph Bean wrote: > @bowlofeggs, can you coordinate with @gnaponie and @lucarval on when > would be a good time to do that? Any time is fine with me - with OpenShift it should be possible to upgrade with no down time I presume?

gnaponie commented

2018-11-06 07:54:21 +00:00

Yeah, we shouldn't have down time. I'll sync up with @lucarval later and we'll proceed.

Rows
Columns

Enable opt-in gating on Greenwave #7311