Infrastructure/fedora-infrastructure
1
0
Fork 0
Code Issues 70 Pull requests Projects Releases Packages Wiki Activity Actions

Robusticize fedora-review flag check.

Browse source
This commit is contained in:
Jon Ciesla 2012-08-16 14:42:26 -05:00
parent 772774e5f9
commit fe057c77ae
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
scripts/process-git-requests/process-git-requests
View file

@ -485,9 +485,13 @@ def process_new_request(bug, comment, allcomments, firstfound, pkgdb, fas, branc
warned = True warned = True
frflag = bug.get_flags('fedora-review') frflag = bug.get_flags('fedora-review')
if frflag[0]['status'] != '+': if not frflag[0]['status']:
warnings.append("WARNING: fedora-review flag not set to '+'") warnings.append("WARNING: fedora-review flag not set")
warned = True warned = True
else:
if frflag[0]['status'] != '+':
warnings.append("WARNING: fedora-review flag not set to '+'")
warned = True
if frflag[0]['setter_email'] == bug.reporter: if frflag[0]['setter_email'] == bug.reporter:
warnings.append("WARNING: fedora-review flag set by review submitter! Verify that review was approved by reviewer!") warnings.append("WARNING: fedora-review flag set by review submitter! Verify that review was approved by reviewer!")
warned = True warned = True