Infrastructure/fedora-infrastructure
1
0
Fork 0
Code Issues 70 Pull requests Projects Releases Packages Wiki Activity Actions

Warn if fedora-review flag set by submitter. (Thanks to Thomas Spura for alerting me to this)

Browse source
This commit is contained in:
Jon Ciesla 2012-07-05 10:12:38 -05:00
parent f7ed75b8df
commit d906b477f0
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
scripts/process-git-requests/process-git-requests
View file

@ -8,14 +8,15 @@ OBSOLETE_BRANCH='F-15'
# A bug for testing new types of badly formatted requests exists: # A bug for testing new types of badly formatted requests exists:
# https://bugzilla.redhat.com/show_bug.cgi?id=622067 # https://bugzilla.redhat.com/show_bug.cgi?id=622067
# A bug for testing flags, primarily by limburgher, also exists:
# https://bugzilla.redhat.com/show_bug.cgi?id=837840
# TODO: # TODO:
# Extract fedora-review flag setter if possible.
# Display last linked spec file. # Display last linked spec file.
# Download (and process?) last linked srpm # Download (and process?) last linked srpm
# Checks to add: # Checks to add:
# Package and/or branch already exists in pkgdb. # Package and/or branch already exists in pkgdb.
# fedora-review flag isn't set (especially if it's still set to '?'
# Catch common misspellings? # Catch common misspellings?
import bugzilla import bugzilla
@ -487,6 +488,11 @@ def process_new_request(bug, comment, allcomments, firstfound, pkgdb, fas, branc
warnings.append("WARNING: fedora-review flag not set to '+'") warnings.append("WARNING: fedora-review flag not set to '+'")
warned = True warned = True
frflag = bug.get_flags('fedora-review')
if frflag[0]['setter_email'] == bug.reporter:
warnings.append("WARNING: fedora-review flag set by review submitter! Verify that review was approved by reviewer!")
warned = True
m=re.search('Review Request:\s+([a-zA-Z0-9_+.-]+)\s+', bug.summary, re.I) m=re.search('Review Request:\s+([a-zA-Z0-9_+.-]+)\s+', bug.summary, re.I)
if not m: if not m:
warnings.append("WARNING: Couldn't parse package name out of bug summary.") warnings.append("WARNING: Couldn't parse package name out of bug summary.")