Add some logging and an ominous warning :-)

This commit is contained in:
Ricky Zhou (周家杰) 2009-07-26 10:19:31 -04:00
parent 810cc7ef9c
commit d8ef5c36ac

View file

@ -1,6 +1,6 @@
<?php
require_once('AuthPlugin.php');
class Auth_FAS extends AuthPlugin {
require_once('AuthPlugin.php');
class Auth_FAS extends AuthPlugin {
function authenticate($username, $password) {
if ( ucfirst(strtolower($username)) != ucfirst($username) ) {
return false;
@ -14,7 +14,11 @@
curl_setopt($ch, CURLOPT_USERAGENT, "Auth_FAS 0.9");
curl_setopt($ch, CURLOPT_POSTFIELDS, "username=".urlencode($username)."&user_name=".urlencode($username)."&password=".urlencode($password)."&login=Login");
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
# WARNING: Never leave this on in production, as it will cause
# plaintext passwords to show up in error logs.
curl_setopt($ch, CURLOPT_VERBOSE, 0);
# The following two lines need to be enabled when using a test FAS
# with an invalid cert. Otherwise they should be commented (or
# set to True) for security.
@ -23,15 +27,20 @@
$response = json_decode(curl_exec($ch), true);
curl_close ($ch);
if (!isset($response["success"])) return false;
if (!isset($response["success"])) {
fwrite(STDERR, "FAS auth failed for $username: incorrect username or password\n");
return false;
}
$groups = $response["person"]["approved_memberships"];
for ($i = 0, $cnt = count($groups); $i < $cnt; $i++) {
if ($groups[$i]["name"] == "cla_done") {
fwrite(STDERR, "FAS auth succeeded for $username\n");
return true;
}
}
fwrite(STDERR, "FAS auth failed for $username: insufficient group membership\n");
return false;
}
@ -100,7 +109,7 @@
$user->saveSettings();
return true;
}
}
}
/**
* Some extension information init
@ -109,7 +118,7 @@ $wgExtensionCredits['other'][] = array(
'name' => 'Auth_FAS',
'version' => '0.9.1',
'author' => 'Nigel Jones',
'description' => 'Authorisation plugin allowing login with FAS2 accounts'#,
'description' => 'Authorisation plugin allowing login with FAS2 accounts'
);
?>