Zabbix-stg: add placeholder macro dict to the correct group_vars

gwmngilfen commented

2025-05-01 15:09:54 +00:00

Contributor

Quick fix to #2603 - the empty dicts should in in "all", not in zabbix(_stg) because only the zabbix servers exist in those groups

zuul commented

2025-05-01 15:13:02 +00:00

First-time contributor

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/ca8cb9ec645841cd8b28743b2e72737d

fi-ansible-lint-diff : SUCCESS in 2m 49s
fi-yamllint-diff : SUCCESS in 2m 09s

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/ca8cb9ec645841cd8b28743b2e72737d - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/bb08371994f743ada32c182462182a54) : SUCCESS in 2m 49s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/8f84df8192b54b52a405257fd3ccc5b7) : SUCCESS in 2m 09s

gwmngilfen commented

2025-05-01 15:23:42 +00:00

Author

Contributor

@kevin given this touches "group_vars/all" I'd like a +1 from you if possible, thanks!

gwmngilfen commented

2025-05-02 08:53:01 +00:00

Author

Contributor

Merging this because it's going to cause "missing variable: zabbix_macros" on everything until we do.

gwmngilfen commented

2025-05-02 08:56:00 +00:00

Author

Contributor

rebased onto e76ba9a025

rebased onto e76ba9a025768c2fb853307a2083f1e705c95385

gwmngilfen commented

2025-05-02 08:56:10 +00:00

Author

Contributor

rebased onto e76ba9a025

rebased onto e76ba9a025768c2fb853307a2083f1e705c95385

zuul commented

2025-05-02 08:59:05 +00:00

First-time contributor

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/7751074b1a9d4b3790c3fda10ad78d9b

fi-ansible-lint-diff : SUCCESS in 2m 30s
fi-yamllint-diff : SUCCESS in 2m 44s

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/7751074b1a9d4b3790c3fda10ad78d9b - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/5d966ae9fec148c1ab0e286e2ca08730) : SUCCESS in 2m 30s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/ac4007b1e3134be1a60f1b9851715473) : SUCCESS in 2m 44s

gwmngilfen commented

2025-05-02 09:04:25 +00:00

Author

Contributor

Pull-Request has been merged by gwmngilfen

gwmngilfen commented

2025-05-02 09:23:12 +00:00

Author

Contributor

Looks OK:

Before:

TASK [zabbix/zabbix_agent : Set Host-level macros] **********************************************************************************************************
Friday 02 May 2025  09:03:57 +0000 (0:00:00.242)       0:00:02.628 ************ 
Friday 02 May 2025  09:03:57 +0000 (0:00:00.242)       0:00:02.627 ************ 
fatal: [proxy02.stg.iad2.fedoraproject.org]: FAILED! => {"msg": "'zabbix_macros' is undefined. 'zabbix_macros' is undefined"}

After:

TASK [zabbix/zabbix_agent : Set Host-level macros] **********************************************************************************************************
Friday 02 May 2025  09:09:23 +0000 (0:00:00.228)       0:00:02.560 ************ 
Friday 02 May 2025  09:09:23 +0000 (0:00:00.228)       0:00:02.560 ************ 
skipping: [proxy02.stg.iad2.fedoraproject.org]

Looks OK: Before: ``` TASK [zabbix/zabbix_agent : Set Host-level macros] ********************************************************************************************************** Friday 02 May 2025 09:03:57 +0000 (0:00:00.242) 0:00:02.628 ************ Friday 02 May 2025 09:03:57 +0000 (0:00:00.242) 0:00:02.627 ************ fatal: [proxy02.stg.iad2.fedoraproject.org]: FAILED! => {"msg": "'zabbix_macros' is undefined. 'zabbix_macros' is undefined"} ``` After: ``` TASK [zabbix/zabbix_agent : Set Host-level macros] ********************************************************************************************************** Friday 02 May 2025 09:09:23 +0000 (0:00:00.228) 0:00:02.560 ************ Friday 02 May 2025 09:09:23 +0000 (0:00:00.228) 0:00:02.560 ************ skipping: [proxy02.stg.iad2.fedoraproject.org] ```

Rows
Columns

Zabbix-stg: add placeholder macro dict to the correct group_vars #2604