Infrastructure/ansible
5
0
Fork 0
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

fix logrotate to match file with date #2478

Merged
ryanlerch merged 1 commit from logrotate_fix into main 2025-05-16 17:37:08 +00:00
Conversation 26 Commits 1 Files changed 2 +6 -2
seddik commented 2025-02-15 21:30:51 +00:00
Contributor
Copy link

Related to https://pagure.io/fedora-infrastructure/issue/12398

Related to https://pagure.io/fedora-infrastructure/issue/12398
zuul commented 2025-02-15 21:33:16 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/8b9d22bad4724b9db506a5619a7dce40

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/8b9d22bad4724b9db506a5619a7dce40 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/4081774319074e1b93125152426db3bc) : SUCCESS in 2m 10s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/ee53471233984cac97e8a47e0731bb58) : SUCCESS in 2m 00s
kevin commented 2025-02-17 18:02:52 +00:00
Contributor
Copy link

This will take care of the YYYY-MM-DD ones... but there is still also a access_log one.

So perhaps 2 entries? or some regex that works for both?

This will take care of the YYYY-MM-DD ones... but there is still also a access_log one. So perhaps 2 entries? or some regex that works for both?
seddik commented 2025-02-19 23:46:10 +00:00
Author
Contributor
Copy link

rebased onto 6d4c6b0be1

rebased onto 6d4c6b0be13ec1365deba1d5e05674a51481ee7f
seddik commented 2025-02-19 23:48:19 +00:00
Author
Contributor
Copy link

PR updated

PR updated
zuul commented 2025-02-19 23:48:41 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/9996ead7b6e14a979f324267f93e13af

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/9996ead7b6e14a979f324267f93e13af - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/191ab16eb7354619a192ce7534fd304f) : SUCCESS in 2m 15s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/e7ca21c420d14eb8b989985eaef4649d) : SUCCESS in 1m 59s
kevin commented 2025-02-23 19:17:36 +00:00
Contributor
Copy link

well, you shouldn't need *log and access_log right? the first one should match...

I think there may not be newlines between the logs to match? not 100% sure tho.

well, you shouldn't need *log and access_log right? the first one should match... I think there may not be newlines between the logs to match? not 100% sure tho.
seddik commented 2025-03-16 21:31:58 +00:00
Author
Contributor
Copy link

rebased onto f10301013c

rebased onto f10301013c5c2f0674ad3530f0f0eeb4f4ec5230
zuul commented 2025-03-16 21:35:03 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/558e5323f59e41be9572d63e771bec71

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/558e5323f59e41be9572d63e771bec71 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/a460816741f14bb2871f989808b025fb) : SUCCESS in 2m 43s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/a04cb1635a17472a901778653fb586b5) : SUCCESS in 2m 08s
seddik commented 2025-03-16 22:04:03 +00:00
Author
Contributor
Copy link

@kevin PR updated

@kevin PR updated
kevin commented 2025-03-17 17:39:09 +00:00
Contributor
Copy link

Metadata Update from @kevin:

  • Pull-request tagged with: post-freeze
**Metadata Update from @kevin**: - Pull-request tagged with: post-freeze
kevin commented 2025-03-19 20:21:05 +00:00
Contributor
Copy link

rebased onto 2f67aade41

rebased onto 2f67aade41ca38ec69e7077d3784d267a0ddc660
kevin commented 2025-03-19 20:21:15 +00:00
Contributor
Copy link

rebased onto 2f67aade41

rebased onto 2f67aade41ca38ec69e7077d3784d267a0ddc660
zuul commented 2025-03-19 20:23:57 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/780e9a2db66a4c16b0ac11a6bb3408bb

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/780e9a2db66a4c16b0ac11a6bb3408bb - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/e73568f62ccd483b9501cb6ed4db862a) : SUCCESS in 2m 35s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/fa6e966270a341dfbc91642981323cff) : SUCCESS in 2m 10s
kevin commented 2025-04-29 21:25:04 +00:00
Contributor
Copy link

Sorry this one has lingered so long. ;(

So, this will only matter on those kojipkgs servers, but it will apply to everything. Will it cause problems for non matching hosts?

Or perhaps can we just do a specific one for kojipkgs instead of changing every one all over?

Sorry this one has lingered so long. ;( So, this will only matter on those kojipkgs servers, but it will apply to everything. Will it cause problems for non matching hosts? Or perhaps can we just do a specific one for kojipkgs instead of changing every one all over?
seddik commented 2025-05-07 21:28:36 +00:00
Author
Contributor
Copy link

rebased onto 5561372a5f

rebased onto 5561372a5f4ae65ba157f7a738f40dcea4a39b52
zuul commented 2025-05-07 21:32:06 +00:00
First-time contributor
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/cfd4e79ee0f6418ea232627358f21368

Build succeeded. https://fedora.softwarefactory-project.io/zuul/buildset/cfd4e79ee0f6418ea232627358f21368 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/ab4e63dd25ec4ab3bfa7b72000a25908) : SUCCESS in 3m 06s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/bdf0fb8f24f3454db8e35ddba804c44d) : SUCCESS in 2m 12s
seddik commented 2025-05-07 21:43:26 +00:00
Author
Contributor
Copy link

@kevin I've just updated with condition !
Can you test this ??

@kevin I've just updated with condition ! Can you test this ??
kevin commented 2025-05-09 18:23:23 +00:00
Contributor
Copy link

That looks ok, but... this is a file, not a template. We would need to move it to a .j2 file and change the copy to a template in the ansible play(s) that call it.

Can you do that?

Sorry this is drawing out so long. Thanks for working on it!

That looks ok, but... this is a file, not a template. We would need to move it to a .j2 file and change the copy to a template in the ansible play(s) that call it. Can you do that? Sorry this is drawing out so long. Thanks for working on it!
seddik commented 2025-05-13 22:23:12 +00:00
Author
Contributor
Copy link

rebased onto 8a9adc58ec

rebased onto 8a9adc58ec726e397f500540649d60b2718315f2
seddik commented 2025-05-13 22:24:05 +00:00
Author
Contributor
Copy link

That looks ok, but... this is a file, not a template. We would need to move it to a .j2 file and change the copy to a template in the ansible play(s) that call it.

Can you do that?

Sorry this is drawing out so long. Thanks for working on it!

yes I've just updated the PR , thank you

> That looks ok, but... this is a file, not a template. We would need to move it to a .j2 file and change the copy to a template in the ansible play(s) that call it. > > Can you do that? > > Sorry this is drawing out so long. Thanks for working on it! > yes I've just updated the PR , thank you
zuul commented 2025-05-13 22:26:44 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/dd415917788e44b9b66ba965f46decef

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/dd415917788e44b9b66ba965f46decef - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/ad4e030976ab4615a5d6ae33dea6e0b1) : FAILURE in 3m 03s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/a0c60505c1744386ba0191ecab91c7dc) : SUCCESS in 2m 28s
kevin commented 2025-05-15 21:57:34 +00:00
Contributor
Copy link

rebased onto e9734b9cdf

rebased onto e9734b9cdf9c0bc7d2dad42d3293b585c0b48591
kevin commented 2025-05-15 21:57:43 +00:00
Contributor
Copy link

rebased onto e9734b9cdf

rebased onto e9734b9cdf9c0bc7d2dad42d3293b585c0b48591
zuul commented 2025-05-15 22:00:45 +00:00
First-time contributor
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/418b2bb4b7614832aeb25a40b5c17869

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/418b2bb4b7614832aeb25a40b5c17869 - [fi-ansible-lint-diff ](https://fedora.softwarefactory-project.io/zuul/build/7c345ba6a7134b6e8c7a782a83195930) : FAILURE in 2m 50s - [fi-yamllint-diff ](https://fedora.softwarefactory-project.io/zuul/build/6ebe30ce86bd4e4a8bf96544d05eeda0) : SUCCESS in 2m 20s
kevin commented 2025-05-16 17:36:53 +00:00
Contributor
Copy link

Thanks!

Thanks!
kevin commented 2025-05-16 17:37:08 +00:00
Contributor
Copy link

Pull-Request has been merged by kevin

Pull-Request has been merged by kevin
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
freeze-break-request

   
post-freeze
No labels
freeze-break-request
post-freeze
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Infrastructure/ansible#2478
No description provided.
Delete branch "logrotate_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?