Commit graph

159 commits

Author SHA1 Message Date
Michal Konecny
6428f8f772 Sunset github2fedmsg and fedmsg
This commit is removing all the fedmsg related stuff from ansible
repository.

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-13 10:08:51 +00:00
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
47c68f478d ansiblelint fixes - fqcn[action-core] - template to ansible.builtin.template
Replaces references to template: with ansible.builtin.template

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:30:29 +10:00
25391e95b7 ansiblelint fixes - fqcn[action-core] - package to ansible.builtin.package
Replaces many references to  package: with ansible.builtin.package

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:28:00 +10:00
6a3816dfdc ansiblelint fixes-- fqcn[action-core] - copy to ansible.builtin.copy
Replaces many references to 'copy' with ansible.builtin.copy

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:43:31 +10:00
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Kevin Fenzi
d11f9c5ced epel7 retirement
Drop epel7 all the places in ansible where it is and makes sense.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-07-03 20:00:59 +00:00
Kevin Fenzi
8feca5885b Revert "Reapply "Don't send a fedora-messaging message from the Pagure git hook""
This reverts commit 26358b62a2.

So, this broke the toddler that handles package retirements. ;(

It seems it was commited on feb 20th, but not actually pushed out until
March 4th. At that point, retirements stop. ;(

I think it's getting the new git pagure messages, but they don't
contain the information it expects so it just drops them.

We will need to adjust toddlers before we can re-drop this.
2024-04-01 11:19:00 -07:00
Aurélien Bompard
26358b62a2
Reapply "Don't send a fedora-messaging message from the Pagure git hook"
This reverts commit 7667b0e97e.

The packit folks have migrated to the Pagure-native message:
https://github.com/packit/packit-service/issues/2305
2024-02-20 12:14:44 +01:00
Sandro
93250fc4c5 Fix typo in alternative_arch_report.py
Just scratching an itch with `s/ExcludesArch/ExcludeArch/`, making the
script do what it was supposed to do all those years. Call it The Seven
Year Itch if you like. :-P
2024-02-14 22:19:08 +00:00
Aurélien Bompard
7667b0e97e
Revert "Don't send a fedora-messaging message from the Pagure git hook"
This reverts commit 4bfc46ce37.

The Packit folks are lisening to the git messages, they will migrate to
the pagure messages but ask us to re-enable them while they do the
migration.
2024-01-15 15:10:46 +01:00
Aurélien Bompard
4bfc46ce37
Don't send a fedora-messaging message from the Pagure git hook
Pagure already sends a message on commit, this causes a duplication.

Related to: https://pagure.io/fedora-infrastructure/issue/11687#comment-890826

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-01-11 11:35:39 +01:00
Aurélien Bompard
64da337e67
Use fedora-messaging-git-hook on dist-git
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2023-12-04 17:58:49 +01:00
Kevin Fenzi
0c81957b2d pkgs / make-git-checkout-seed: do not try and remove already removed file
We already removed the old previous days version here, so trying to
remove it again results in a cron email with:

rm: cannot remove '/srv/cache/lookaside//rpm-specs-epel7*.tar.xz': No such file or directory
rm: cannot remove '/srv/cache/lookaside//rpm-specs-epel8*.tar.xz': No such file or directory
rm: cannot remove '/srv/cache/lookaside//rpm-specs-epel9*.tar.xz': No such file or directory

So, drop that here so we don't get these daily emails.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-06-02 12:23:38 -07:00
4f13144d5c make-git-checkout-seed - add some optional debug messages
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2023-05-16 14:18:08 +10:00
0cad63d412 pkg01 - generate spec tarballs for epel with make-git-checkout-seed.sh
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2023-05-16 03:40:07 +00:00
Kevin Fenzi
820284cff8 pkgs / git-hooks: try and use the batcave certs for now
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-05-01 08:44:35 -07:00
Kevin Fenzi
b4e9ddf989 pkgs: install correct git-hook certs
Install the 'git-hooks' cert for use with git commits and package
uploads on pkgs. Before this we were... just not installing those
anymore and they had expired.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-05-01 08:23:37 -07:00
Adam Piasecki
18d4aae59f Matching all branches instead of Epel only 2022-06-23 21:15:10 +00:00
Adam Piasecki
771aff027b Added Epel version to the tar ball name 2022-06-23 21:15:10 +00:00
Adam Piasecki
005da070b3 Added archive EPEL -gt '6' branches 2022-06-23 21:15:10 +00:00
Kevin Fenzi
f9849b7316 git/hooks: everything using this role should be python3 now.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-05-05 16:28:06 -07:00
Pierre-Yves Chibon
bd6180dcd0 git/hooks: decode the output of the subprocess
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2021-01-25 10:54:51 +01:00
Miro Hrončok
400c6ecf47 post-receive-fedora-messaging: Don't attempt to decode unicode strings
On Python 3, we can only decode byte sequences.

subprocess.Popen(universal_newlines=True) always returns unicode stdout/sderr.

Fixes https://pagure.io/fedora-infrastructure/issue/9366

Signed-off-by: Miro Hrončok <miro@hroncok.cz>
2020-10-03 22:48:10 +02:00
Pierre-Yves Chibon
155094f884 git/hooks: Update the gnome-post-receive-email hook to use the git-multimail gook instead
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-10-02 18:39:08 +00:00
Pierre-Yves Chibon
3a7fa049d9 batcave: Fix the two git hooks run in the ansible git repo in the batcave
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-09-10 21:33:27 +02:00
Kevin Fenzi
460b28e0c5 git/hooks: Only install the batcave certs on batcave, not pkgs
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-09-09 11:32:02 -07:00
Pierre-Yves Chibon
a65d4589d0 git/hooks: ensures the revision sent to fedora-messaging are strings not oid objects
The issue was triggered when multiple commits were pushed at once at
which point the list of revisions contained a list of OID objects
that are not JSON serializable but can be converted to text via
str() or by accessing their .hex attribute.
However, when a single commit is pushed, the list of revisions
contains just the hash of the commit pushed and thus is already
a string. So relying on .hex will not work then.
Using str() becomes the solution that works for both scenarios.

Fixes https://pagure.io/fedora-infrastructure/issue/9247

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-08-20 10:33:47 +02:00
Nils Philippsen
74752c3a3c Cope with dangling symlinks
The exists() method uses os.stat() instead of os.lstat() and so doesn't
work for symlinks pointing to a non-existent path. A corresponding
lexists() method doesn't exist yet.

Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-25 10:30:33 +02:00
Nils Philippsen
34d165ab0d Fix hook links to Pagure hookrunner script, too
This doesn't attempt to prefix the base directory if a supplied `target`
is an absolute path (for debugging).

Fixes: fedora-infrastructure#9000

Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-25 07:26:50 +00:00
Nils Philippsen
5175246b89 Fix wrong argument help string
Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-25 07:26:50 +00:00
Nils Philippsen
a87c762569 Convert to pathlib API for easy path manipulation
The only left over is os.readlink() which was only introduced as
Path.readlink() in Python 3.9.

Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-25 07:26:50 +00:00
Pierre-Yves Chibon
dc92c9d924 git/hooks: fix typo isinstance != instance
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-06-12 14:15:54 +02:00
Pierre-Yves Chibon
b631c49d08 git/hook: apparently the rev can be either a string or the pygit2.Oid object
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-06-11 21:39:32 +02:00
Pierre-Yves Chibon
18a674d74d git/hook: parse the revision/hash rather than the Oid object
Fixes https://pagure.io/fedora-infrastructure/issue/9016

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-06-11 21:13:44 +02:00
Pierre-Yves Chibon
891dcaac2b distgit: give access to the fedora-messaging certs to the packager group
This solves the permission denied error packager would see otherwise
when pushing to dist-git as the hooks would fail to send notifications
on the fedora-messaging bus.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-06-10 10:06:13 +02:00
Stephen Smoogen
0082dc0996 make sure pkgs02 has tar and python2 installed 2020-06-09 22:32:53 -04:00
Pierre-Yves Chibon
de0b5d6abe git/hooks: point the post-receive-chained-forks file to the proper git hook from pagure
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-06-10 00:15:18 +02:00
Pierre-Yves Chibon
6e82268613 git/hooks: Start making the hooks crash less on rhel8/python3
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-06-06 21:17:05 +02:00
Pierre-Yves Chibon
e0ed6697f4 distgit: make the iad2 host closer to the current staging and different from phx2
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-05-25 23:10:15 +02:00
Pierre-Yves Chibon
7acddaeca5 git/hooks: adjusts the post-receive hooks so it loads the correct fedora-messaging config
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-05-20 11:23:28 +02:00
Pierre-Yves Chibon
cef92fff61 git/hooks: looks like moreutils fails to install on rhel8 atm
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-05-20 11:22:01 +02:00
Pierre-Yves Chibon
dd6c85b1e2 Adjust the list of packages to install for RHEL8/python3
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-05-20 11:21:14 +02:00
Pierre-Yves Chibon
633866fdff git/hooks: install the fedora-messaging certs and config file
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-05-20 11:20:57 +02:00
Pierre-Yves Chibon
7ee8003ba9 git/hooks: port from fedmsg to fedora-messaging
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
2020-05-20 11:13:37 +02:00
Kevin Fenzi
81fb4582e7 ansible: change when conditions to use == instead of is when checking strings.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-04-24 21:34:10 +02:00
Karsten Hopp
c9ed62ac32 update ansible_distribution_major_version conditionals
Signed-off-by: Karsten Hopp <karsten@redhat.com>
2020-04-24 21:34:10 +02:00
Aurélien Bompard
d98a7392a5 git/hooks: update package command to not use items
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2019-06-11 17:56:22 +02:00