Commit graph

17 commits

Author SHA1 Message Date
Adam Williamson
e3a7bfda34 mediawiki fedmsg-emit: fix error on creating page (#7415)
This function is set up as a mediawiki hook. It expects to be
passed 12 args. It turns out that mediawiki 1.29.3 - the version
we're running - has two codepaths that call the hook: one passes
it all 12 args, one only passes it 11, missing out the final arg
(undidRevId). @puiterwijk tried to fix this in d85f8c2, but it
seems he misread and set a default value for the 11th arg rather
than the 12th, so it didn't actually fix the problem. Moving the
default value to the 12th arg should fix the problem for good.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-12-03 23:48:38 -08:00
Patrick Uiterwijk
d85f8c2083 Fix creating of new wiki pages
This breaks because mediawiki doesn't follow their own documented API[1] and doesn't pass
a base revision ID when creating new pages.

Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>

[1]: https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
2018-08-31 19:52:17 +02:00
Patrick Uiterwijk
5ee3b0bbdc Do the lazy porting to mw 1.29.0 hooks
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-11-30 19:59:08 +00:00
Patrick Uiterwijk
3a55c768bf Fix fedmsg-emit accessing private fields
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-11-23 00:50:45 +00:00
Ralph Bean
7df52bd052 Correct the x509 patch to insert the note before signing (not after). 2014-12-11 01:49:22 +00:00
Ralph Bean
9cb51b5d1c Revert "fedmsg/mediawiki, replace the $revision dict with the simplest version we can."
This reverts commit 8a7eeacfeb.
2014-12-11 01:47:11 +00:00
Ralph Bean
8a7eeacfeb fedmsg/mediawiki, replace the $revision dict with the simplest version we can. 2014-12-11 01:30:17 +00:00
Kevin Fenzi
3a6d7c308c Add patch for mediawiki and fedmsg crypto. Ticket 4604 2014-12-10 19:29:18 +00:00
Ralph Bean
de01e68223 No, this should do it.... 2014-11-14 22:18:58 +00:00
Ralph Bean
023f2e84e9 OK, this should do it.... 2014-11-14 22:14:45 +00:00
Ralph Bean
6ff76f68ab Forgotten $. 2014-11-14 22:00:01 +00:00
Ralph Bean
c5104e1574 Cut out most of the stuff from this one php array to try and fix message signatures for wiki upload messages. 2014-11-14 21:55:05 +00:00
Ralph Bean
3016956a4d PHP wants double quotes here. 2014-11-14 21:38:00 +00:00
Ralph Bean
48d98684db Move the call up the stack. 2014-11-14 21:33:35 +00:00
Ralph Bean
7bb1e80fca Throw a newline in there. 2014-11-14 21:30:02 +00:00
Ralph Bean
1926f2019a Log wiki fedmsg messages to a file (temporarily, for debugging). 2014-11-14 21:21:39 +00:00
Kevin Fenzi
c2b06a44fc mediawiki role for wiki servers. Thanks adimania. ticket 4257 2014-04-21 18:10:28 +00:00