From f7c87b0f755638b9268cb1d4fee117c47cd0a560 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Tue, 6 Mar 2018 15:24:37 -0800 Subject: [PATCH] openqa/worker: make some file existence checks safer Signed-off-by: Adam Williamson --- roles/openqa/worker/tasks/tap-setup.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/openqa/worker/tasks/tap-setup.yml b/roles/openqa/worker/tasks/tap-setup.yml index 80645fcf0f..bd49cb60c7 100644 --- a/roles/openqa/worker/tasks/tap-setup.yml +++ b/roles/openqa/worker/tasks/tap-setup.yml @@ -29,11 +29,11 @@ - name: Make sure usb0 doesn't get in our way lineinfile: dest=/etc/sysconfig/network-scripts/ifcfg-usb0 regexp="^ONBOOT=" line="ONBOOT=no" - when: (ifcfgusb0.stat.exists == True) and (deployment_type is defined) + when: (ifcfgusb0.stat.exists is defined) and (ifcfgusb0.stat.exists == True) and (deployment_type is defined) - name: Make sure eth1 doesn't get in our way lineinfile: dest=/etc/sysconfig/network-scripts/ifcfg-eth1 regexp="^ONBOOT=" line="ONBOOT=no" - when: (ifcfgeth1.stat.exists == True) and (deployment_type is defined) + when: (ifcfgeth1.stat.exists is defined) and (ifcfgeth1.stat.exists == True) and (deployment_type is defined) - name: Start openvswitch service service: name=openvswitch enabled=yes state=started