openqa: drop prod/stg variance for fixed asset location

inventory/group_vars/openqa-stg

@@ -28,10 +28,6 @@ openqa_dbuser: openqastg
 openqa_dbpassword: "{{ stg_openqa_dbpassword }}"
 openqa_assetsize: 300
 
-# this is a temporary variance between staging and prod while
-# testing https://github.com/os-autoinst/openQA/pull/945
-openqa_fixed: /var/lib/openqa/share/factory/hdd/fixed
-
 openqa_key: "{{ stg_openqa_apikey }}"
 openqa_secret: "{{ stg_openqa_apisecret }}"
 

roles/openqa/server/defaults/main.yml

@@ -1 +0,0 @@
-openqa_fixed: /var/lib/openqa/share/factory/hdd

roles/openqa/server/files/createhdds

@@ -1,4 +1,4 @@
 #!/bin/sh
 
-cd {{ openqa_fixed }}
+cd /var/lib/openqa/share/factory/hdd/fixed
 LIBGUESTFS_BACKEND=direct withlock /var/lock/createhdds.lock /root/openqa_fedora_tools/tools/createhdds.py all --clean

roles/openqa/server/tasks/main.yml

@@ -16,11 +16,6 @@
 # - external_hostname
 ##       string - The public hostname for the server (will be used as ServerName)
 ##       default - ansible_nodename
-# - openqa_fixed
-##       string - location for fixed hdd assets; this varies depending on
-##                what openQA version is in use. This is a temporary thing
-##                while we're testing PR #945 on staging
-##       default - /var/lib/openqa/share/factory/hdd
 
 # Optional vars
 # - openqa_static_uid
@@ -138,12 +133,12 @@
   - /var/lib/openqa/share/factory/other
 
 - name: Set up createhdds cron job
-  template: src=createhdds.j2 dest=/etc/cron.daily/createhdds owner=root group=root mode=0755
+  copy: src=createhdds dest=/etc/cron.daily/createhdds owner=root group=root mode=0755
 
 - name: Check if any hard disk images need (re)building
   command: "/root/openqa_fedora_tools/tools/createhdds.py check"
   args:
-    chdir: "{{ openqa_fixed }}"
+    chdir: /var/lib/openqa/share/factory/hdd/fixed
   register: diskcheck
   failed_when: "1 != 1"
   changed_when: "1 != 1"