From ef8a705432eb70b0c09353dc3bb9a8c081e05647 Mon Sep 17 00:00:00 2001
From: Kevin Fenzi <kevin@scrye.com>
Date: Wed, 30 Mar 2016 14:57:54 +0000
Subject: [PATCH] Don't do updates in playbooks (for a number of reasons).

1. We want all playbooks to be idempotent. If we add things like this
it means the playbook will change every single time we run it.

2. Things like this mean that if we need to change one config or
something to get the service working we may have to wait a long time
for it to apply tons of pending updates, which may break more things.

3. On all Fedora machines (that have base role anyhow) we already run
dnf-automatic to apply all security updates. We could expand that to
apply all updates if you like. Doing them daily is much better for
finding regressions

4. We expect updates are applied normally by dnf-automatic or by
sysadmins so we can know whats in the updates and be ready for issues
or restarting things.
---
 roles/copr/backend/tasks/main.yml  | 3 ---
 roles/copr/dist_git/tasks/main.yml | 3 ---
 roles/copr/frontend/tasks/main.yml | 3 ---
 3 files changed, 9 deletions(-)

diff --git a/roles/copr/backend/tasks/main.yml b/roles/copr/backend/tasks/main.yml
index b4c5e1cadb..ab6ef89123 100644
--- a/roles/copr/backend/tasks/main.yml
+++ b/roles/copr/backend/tasks/main.yml
@@ -24,9 +24,6 @@
   - python-futures  # remove when new version of copr-backend will be released
   - logstash
 
-- name: upgrade all packages
-  dnf: name=* state=latest
-
 - name: make copr dirs
   file: state=directory path={{ item }}
   with_items:
diff --git a/roles/copr/dist_git/tasks/main.yml b/roles/copr/dist_git/tasks/main.yml
index c16cba6e47..7e11e6b01d 100644
--- a/roles/copr/dist_git/tasks/main.yml
+++ b/roles/copr/dist_git/tasks/main.yml
@@ -13,9 +13,6 @@
   - copr-dist-git
   - rdiff-backup
 
-- name: upgrade all packages
-  yum: name=* state=latest
-
 - name: ensure git storage path exists
   file: path="/var/lib/dist-git/git" state=directory group=packager mode=0775
 #- file: path="/var/lib/dist-git/git/pkgs-git-repos-list" state=file group=packager
diff --git a/roles/copr/frontend/tasks/main.yml b/roles/copr/frontend/tasks/main.yml
index ecbca11755..ad7def1795 100644
--- a/roles/copr/frontend/tasks/main.yml
+++ b/roles/copr/frontend/tasks/main.yml
@@ -25,9 +25,6 @@
   tags:
   - packages
 
-- name: upgrade all packages
-  dnf: name=* state=latest
-
 - name: install copr configs
   template: src="copr.conf" dest=/etc/copr/copr.conf mode=600
   notify: