From e87b4635b89dd132d59b1281847ec4da1ec73b32 Mon Sep 17 00:00:00 2001 From: Ralph Bean Date: Mon, 12 May 2014 20:25:29 +0000 Subject: [PATCH] Cast to an int, otherwise error condition is never met. --- .../files/scripts/check_fedmsg_consumer_backlog.py | 4 ++-- .../files/scripts/check_fedmsg_consumer_exceptions.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/roles/nagios_client/files/scripts/check_fedmsg_consumer_backlog.py b/roles/nagios_client/files/scripts/check_fedmsg_consumer_backlog.py index e37327ee86..75ff4333fe 100644 --- a/roles/nagios_client/files/scripts/check_fedmsg_consumer_backlog.py +++ b/roles/nagios_client/files/scripts/check_fedmsg_consumer_backlog.py @@ -9,8 +9,8 @@ import zmq try: service = sys.argv[1] check_consumer = sys.argv[2] - backlog_warning = sys.argv[3] - backlog_critical = sys.argv[4] + backlog_warning = int(sys.argv[3]) + backlog_critical = int(sys.argv[4]) fname = '/var/run/fedmsg/monitoring-%s.socket' % service if not os.path.exists(fname): print "UNKNOWN - %s does not exist" % fname diff --git a/roles/nagios_client/files/scripts/check_fedmsg_consumer_exceptions.py b/roles/nagios_client/files/scripts/check_fedmsg_consumer_exceptions.py index 6890063a21..c6ef87234a 100644 --- a/roles/nagios_client/files/scripts/check_fedmsg_consumer_exceptions.py +++ b/roles/nagios_client/files/scripts/check_fedmsg_consumer_exceptions.py @@ -9,8 +9,8 @@ import zmq try: service = sys.argv[1] check_consumer = sys.argv[2] - exceptions_warning = sys.argv[3] - exceptions_critical = sys.argv[4] + exceptions_warning = int(sys.argv[3]) + exceptions_critical = int(sys.argv[4]) fname = '/var/run/fedmsg/monitoring-%s.socket' % service if not os.path.exists(fname): print "UNKNOWN - %s does not exist" % fname @@ -25,7 +25,7 @@ try: for consumer in msg['consumers']: if consumer['name'] == check_consumer: - if consumer['exceptions'] > exceptions_critical: + if consumer['exceptions'] > exceptions_critical: print 'CRITICAL: fedmsg consumer %s exceptions value is %i' % (consumer['name'],consumer['exceptions']) sys.exit(2) elif consumer['exceptions'] > exceptions_warning: