From d80642e913eedcafee4f60557d54c4ccfc015ad9 Mon Sep 17 00:00:00 2001
From: Nils Philippsen <nils@redhat.com>
Date: Wed, 31 Mar 2021 15:08:16 +0200
Subject: [PATCH] make-people-page: Move filtering out of template

Signed-off-by: Nils Philippsen <nils@redhat.com>
---
 roles/people/files/make-people-page.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/roles/people/files/make-people-page.py b/roles/people/files/make-people-page.py
index 53916e5be0..6e52f97cdd 100644
--- a/roles/people/files/make-people-page.py
+++ b/roles/people/files/make-people-page.py
@@ -82,7 +82,6 @@ page_jinja_template = """
 
 
             {% for username, user in users %}
-                {% if (user['has_public_html'] or user['has_public_git']) %}
                 <tr>
                     <td>
                         <img class='user-avatar' src='/static/grey.jpg' alt='Avatar for {{username}}' data-src='https://seccdn.libravatar.org/avatar/{{user['openid_hash']}}?s=20&d=retro'>
@@ -107,7 +106,6 @@ page_jinja_template = """
                         </div>
                     </td>
                 </tr>
-                {% endif %}
             {% endfor %}
         </tbody>
     </table>
@@ -188,7 +186,8 @@ for hdir in homedirs:
         f"http://{user['name'].lower()}.id.fedoraproject.org/".encode("utf-8")
     ).hexdigest()
 
-    users[username] = user
+    if user["has_public_html"] or user["has_public_git"]:
+        users[username] = user
 
 page_jinja_template_obj = Template(page_jinja_template)
 page_output = page_jinja_template_obj.render(users=sorted(users.items()))