openqa/relvalconsumer: fix all other dnf loop cases to use lists

Signed-off-by: Adam Williamson <awilliam@redhat.com>

roles/openqa/server/tasks/main.yml

@@ -68,36 +68,21 @@
 # this is separate from the step below so we can easily flip it between
 # stable and testing
 - name: Install openQA packages
-  dnf: name={{ item }} state=present enablerepo="updates-testing"
+  dnf:
-  with_items:
+    name: ['openqa', 'openqa-httpd', 'openqa-plugin-fedmsg', 'openqa-plugin-fedoraupdaterestart',
-  - openqa
+           'python2-fedfind', 'python3-fedfind']
-  - openqa-httpd
+    state: present
-  - openqa-plugin-fedmsg
+    enablerepo: "updates-testing"
-  - openqa-plugin-fedoraupdaterestart
-  - python2-fedfind
-  - python3-fedfind
   tags:
   - packages
 
 - name: Install various other required packages
-  dnf: name={{ item }} state=present
+  dnf:
-  with_items:
+    name: ['libselinux-python', 'git', 'json_diff', 'libselinux-utils', 'libsemanage-python',
-  - libselinux-python
+           'nfs-utils', 'perl(Class::DBI::Pg)', 'expect', 'libguestfs-tools-c', 'libguestfs-xfs',
-  - git
+           'libvirt-daemon-config-network', 'libvirt-python3', 'python3-libguestfs',
-  - json_diff
+           'virt-install', 'withlock']
-  - libselinux-utils
+    state: present
-  - libsemanage-python
-  - nfs-utils
-  - perl(Class::DBI::Pg)
-  - perl(DateTime::Format::Pg)
-  - expect
-  - libguestfs-tools-c
-  - libguestfs-xfs
-  - libvirt-daemon-config-network
-  - libvirt-python3
-  - python3-libguestfs
-  - virt-install
-  - withlock
   tags:
   - packages
 

roles/openqa/worker/tasks/createhdds.yml

@@ -2,16 +2,10 @@
 # (none)
 
 - name: Install required packages
-  dnf: name={{ item }} state=present
+  dnf:
-  with_items:
+    name: ['libsemanage-python', 'libvirt-daemon-kvm', 'libvirt-python3', 'python3-libguestfs',
-  - libsemanage-python
+           'python3-fedfind', 'qemu-kvm', 'virt-install', 'withlock']
-  - libvirt-daemon-kvm
+    state: present
-  - libvirt-python3
-  - python3-libguestfs
-  - python3-fedfind
-  - qemu-kvm
-  - virt-install
-  - withlock
   tags:
   - packages
 

roles/openqa/worker/tasks/main.yml

@@ -16,17 +16,17 @@
 ##               installed and rngd.service enabled/started
 
 - name: Install required packages (testing)
-  dnf: name={{ item }} state=present enablerepo="updates-testing"
+  dnf:
-  with_items:
+    name: ['openqa-worker']
-  - openqa-worker
+    state: present
+    enablerepo: "updates-testing"
   tags:
   - packages
 
 - name: Install packages
-  dnf: name={{ item }} state=present
+  dnf:
-  with_items:
+    name: ['libselinux-python', 'git']
-  - libselinux-python
+    state: present
-  - git
   tags:
   - packages
 

roles/openqa/worker/tasks/tap-setup.yml

@@ -1,8 +1,7 @@
 - name: Install packages
-  dnf: name={{ item }} state=present
+  dnf:
-  with_items:
+    name: ['os-autoinst-openvswitch', 'tunctl']
-  - os-autoinst-openvswitch
+    state: present
-  - tunctl
   tags:
   - packages
 

roles/relvalconsumer/tasks/main.yml

@@ -16,29 +16,23 @@
 
 # note: kept around for when we need packages from u-t
 #- name: Install required packages (testing)
-#  dnf: name={{ item }} state=present enablerepo="updates-testing"
+#  dnf:
-#  with_items:
+#    name: ['python2-fedfind', 'python2-wikitcms']
-#  - python2-fedfind
+#    state: present
-#  - python2-wikitcms
+#    enablerepo: "updates-testing"
 #  tags:
 #  - packages
 
 - name: Install required packages
-  dnf: name={{ item }} state=present
+  dnf:
-  with_items:
+    name: ['python2-fedfind', 'python2-wikitcms', 'python2-fedmsg-consumers', 'python2-mwclient',
-  - python2-fedfind
+           'python2-setuptools', 'relval']
-  - python2-wikitcms
+    state: present
-  - python2-fedmsg-consumers
-  - python2-mwclient
-  - python-setuptools
-  - relval
   tags:
   - packages
 
 - name: Install required packages (wiki oidc auth)
-  dnf: name={{ item }} state=present enablerepo="updates"
+  dnf: name=python2-openidc-client state=present enablerepo="updates"
-  with_items:
-  - python2-openidc-client
   when: "wikitcms_token is defined"
   tags:
   - packages