From bb67432921e8aa13cf40318e5d0941c9051d9c9e Mon Sep 17 00:00:00 2001
From: Kevin Fenzi <kevin@scrye.com>
Date: Wed, 13 Dec 2023 12:03:37 -0800
Subject: [PATCH] bodhi-backend91: quote all mode paramaters

mode parameters need to be quoted so ansible can see them as strings and
convert them to the right thing in the end. Without that, they could be
ill defined or sometimes wrong.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
---
 roles/bodhi2/backend/tasks/main.yml | 34 ++++++++++++++---------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/roles/bodhi2/backend/tasks/main.yml b/roles/bodhi2/backend/tasks/main.yml
index eb467b06b6..6d5242e880 100644
--- a/roles/bodhi2/backend/tasks/main.yml
+++ b/roles/bodhi2/backend/tasks/main.yml
@@ -95,7 +95,7 @@
 # cron job that syncs packages to koji
 #
 - name: put owner-sync-pagure in place
-  template: src=owner-sync-pagure.j2 dest=/usr/local/bin/owner-sync-pagure mode=0755
+  template: src=owner-sync-pagure.j2 dest=/usr/local/bin/owner-sync-pagure mode="0755"
   tags:
   - config
   - bodhi
@@ -131,7 +131,7 @@
   copy:
     src: koji_sync_listener.py
     dest: /usr/lib/python{{ py3ver }}/site-packages/koji_sync_listener.py
-    mode: 0644
+    mode: "0644"
   when: env == "production"
   tags:
   - bodhi
@@ -160,7 +160,7 @@
 #
 
 - name: put new-updates-sync in place
-  copy: src=new-updates-sync dest=/usr/local/bin/new-updates-sync mode=0755
+  copy: src=new-updates-sync dest=/usr/local/bin/new-updates-sync mode="0755"
   when: env == "production"
   tags:
   - config
@@ -168,7 +168,7 @@
   - cron
 
 - name: put bodhi-automated-pushes.py in place
-  copy: src=bodhi-automated-pushes.py dest=/usr/local/bin/bodhi-automated-pushes.py mode=0755
+  copy: src=bodhi-automated-pushes.py dest=/usr/local/bin/bodhi-automated-pushes.py mode="0755"
   when: env == "production"
   tags:
   - config
@@ -177,14 +177,14 @@
 
 # These next two are used by quick-fedora-mirror
 - name: put update-fullfiletimelist in place
-  copy: src="{{ files }}/scripts/update-fullfiletimelist" dest=/usr/local/bin/update-fullfiletimelist mode=0755
+  copy: src="{{ files }}/scripts/update-fullfiletimelist" dest=/usr/local/bin/update-fullfiletimelist mode="0755"
   when: env == "production"
   tags:
   - config
   - bodhi
   - cron
 - name: add create-filelist script from quick-fedora-mirror
-  copy: src="{{ files }}/scripts/create-filelist" dest=/usr/local/bin/create-filelist mode=0755
+  copy: src="{{ files }}/scripts/create-filelist" dest=/usr/local/bin/create-filelist mode="0755"
   when: env == "production"
   tags:
   - config
@@ -281,7 +281,7 @@
     dest="/etc/bodhi/logging.yaml"
     owner=apache
     group=apache
-    mode=0600
+    mode="0600"
   tags:
   - config
   - bodhi
@@ -292,7 +292,7 @@
     dest: /etc/bodhi/production.ini
     owner: apache
     group: apache
-    mode: 0600
+    mode: "0600"
   tags:
   - config
   - bodhi
@@ -303,7 +303,7 @@
     dest: /etc/bodhi/celeryconfig.py
     owner: apache
     group: apache
-    mode: 0600
+    mode: "0600"
   tags:
   - config
   - bodhi
@@ -314,7 +314,7 @@
     dest: /etc/fedora-messaging/config.toml
     owner: apache
     group: apache
-    mode: 0600
+    mode: "0600"
   tags:
   - config
   - bodhi
@@ -322,7 +322,7 @@
 - name: Create /etc/pki/fedora-messaging
   file:
     dest: /etc/pki/fedora-messaging
-    mode: 0775
+    mode: "0775"
     owner: root
     group: root
     state: directory
@@ -333,7 +333,7 @@
   copy:
     src: "{{ private }}/files/rabbitmq/{{env}}/pki/ca.crt"
     dest: /etc/pki/fedora-messaging/cacert.pem
-    mode: 0644
+    mode: "0644"
     owner: apache
     group: apache
   tags:
@@ -343,7 +343,7 @@
   copy:
     src: "{{ private }}/files/rabbitmq/{{env}}/pki/issued/bodhi{{env_suffix}}.crt"
     dest: /etc/pki/fedora-messaging/bodhi-cert.pem
-    mode: 0644
+    mode: "0644"
     owner: apache
     group: apache
   tags:
@@ -353,7 +353,7 @@
   copy:
     src: "{{ private }}/files/rabbitmq/{{env}}/pki/private/bodhi{{env_suffix}}.key"
     dest: /etc/pki/fedora-messaging/bodhi-key.pem
-    mode: 0600
+    mode: "0600"
     owner: apache
     group: apache
   tags:
@@ -382,7 +382,7 @@
     path: /etc/systemd/system/fm-consumer@.service.d
     owner: root
     group: root
-    mode: 0755
+    mode: "0755"
   tags:
   - bodhi
   - config
@@ -393,7 +393,7 @@
     dest: /etc/systemd/system/fm-consumer@.service.d/local.conf
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   notify:
   - reload systemd
   tags:
@@ -406,7 +406,7 @@
     dest: /etc/systemd/system/bodhi-celery.service
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   notify:
   - reload systemd
   tags: