From 95b93897676fc161f7201568fc8b48cc22ca46cf Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Thu, 7 Nov 2024 12:03:02 -0800 Subject: [PATCH] Bodhi update policy: explicit defaults, pre-beta critpath 3 days Let's uncomment the global `min_karma` and `critpath.mandatory_days_in_testing` values to make it clearer that those are our values. At present we wind up using Bodhi's built-in defaults for these, which are the same, but it's not really clear and there's no inherent reason why we *ought* to rely on Bodhi's defaults rather than stating our own here. Also, per the update policy, critpath updates should be allowed to go stable after 3 days between u-t activation and Beta freeze, just the same as non-critpath. See https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#critpath-updates Signed-off-by: Adam Williamson --- roles/bodhi2/base/templates/production.ini.j2 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/roles/bodhi2/base/templates/production.ini.j2 b/roles/bodhi2/base/templates/production.ini.j2 index ac47dfaafa..524067fc40 100644 --- a/roles/bodhi2/base/templates/production.ini.j2 +++ b/roles/bodhi2/base/templates/production.ini.j2 @@ -544,10 +544,10 @@ critpath.jsonpath = /etc/bodhi/critpath # critpath_pkgs = # The net karma required to submit a critial path update to a pending release. -# min_karma = 2 +min_karma = 2 # Allow critpath to submit for stable after 2 weeks with no negative karma -# critpath.mandatory_days_in_testing = 14 +critpath.mandatory_days_in_testing = 14 # The minimum amount of time an update must spend in testing before # it can reach the stable repository @@ -579,7 +579,7 @@ f{{ FedoraBranchedNumber }}.pre_beta.critpath.mandatory_days_in_testing = 0 f{{ FedoraBranchedNumber }}.status = pre_beta f{{ FedoraBranchedNumber }}.pre_beta.mandatory_days_in_testing = 3 f{{ FedoraBranchedNumber }}.pre_beta.min_karma = 1 -f{{ FedoraBranchedNumber }}.pre_beta.critpath.mandatory_days_in_testing = 14 +f{{ FedoraBranchedNumber }}.pre_beta.critpath.mandatory_days_in_testing = 3 {% elif FedoraBranchedBodhi is defined and FedoraBranchedBodhi == 'postbeta' %} f{{ FedoraBranchedNumber }}.status = post_beta f{{ FedoraBranchedNumber }}.post_beta.mandatory_days_in_testing = 7