From 923368d85c9211e7ee391e36fa90d005bee43fc9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= <mgrabovs@redhat.com>
Date: Fri, 18 Jun 2021 10:46:40 +0200
Subject: [PATCH] retrace: Fix cron job definitions

* Fix line folding syntax. The previous version caused vertical
  whitespace to be included in the output which broke the crontab.
* Rename clean up job so that it doesn't contain any variables.
  Including variables in a name makes it difficult to remove or change
  the job when the variable changes.
* Code style consistency.
---
 roles/abrt/faf-post/tasks/cron.yml | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/roles/abrt/faf-post/tasks/cron.yml b/roles/abrt/faf-post/tasks/cron.yml
index a09af1c584..b3230b53fb 100644
--- a/roles/abrt/faf-post/tasks/cron.yml
+++ b/roles/abrt/faf-post/tasks/cron.yml
@@ -5,15 +5,15 @@
     cron:
       name: "backup database"
       user: faf
-      job: >
+      job: >-
         ( pg_dump --format=custom --file={{ faf_backup_dir }}/backup-$(date '+\%F').dump faf )
-          >> /var/log/faf/db_backup.log 2>&1
+        >> /var/log/faf/db_backup.log 2>&1
       special_time: daily
       state: present
 
   - name: Delete old database backups
     cron:
-      name: "delete database backups older than {{ faf_old_backup_age }} days"
+      name: "delete old database backups"
       user: faf
       job: "find {{ faf_backup_dir }} -mtime {{ faf_old_backup_age }} -type f -delete"
       special_time: daily
@@ -39,9 +39,9 @@
     cron:
       name: "cron for probable fixes for f{{ item }}"
       user: faf
-      job: >
+      job: >-
         faf mark-probably-fixed -o fedora --opsys-release {{ item }}
-          >> /var/log/faf/mark-probably-fixed-f{{ item }}.log 2>&1
+        >> /var/log/faf/mark-probably-fixed-f{{ item }}.log 2>&1
       special_time: daily
       state: present
     loop: "{{ rs_internal_fedora_vers }}"
@@ -91,6 +91,7 @@
 - name: Cron job for deleting old archives
   cron:
     name: "rotate_faf_archives"
-    special_time: "daily"
+    user: faf
     job: "find '/srv/faf/reports/archive/' -type f -name '*.tar.xz' -mtime '{{archive_age}}' -delete"
-    user: "faf"
+    special_time: daily
+    state: present