logview: minor pep8 fixups

Signed-off-by: Francois Andrieu <naolwen@gmail.com>
This commit is contained in:
Francois Andrieu 2020-07-10 06:12:04 +02:00 committed by kevin
parent 3696752d08
commit 777637f7a6

View file

@ -23,17 +23,17 @@ def date_cheat(datestr):
def parse_args(args): def parse_args(args):
usage = """ usage = """
logview [options] [-d datestr] [-p playbook] logview [options] [-d datestr] [-p playbook]
examples: examples:
logview -d yesterday -l # lists playbooks run on that date logview -d yesterday -l # lists playbooks run on that date
logview -s OK -s FAILED -d yesterday # list events from yesterday that failed or were ok logview -s OK -s FAILED -d yesterday # list events from yesterday that failed or were ok
logview -s CHANGED -d yesterday -p mirrorlist # list events that changed from the mirrorlist playbook logview -s CHANGED -d yesterday -p mirrorlist # list events that changed from the mirrorlist playbook
logview -s ANY -d yesterday -p mirrorlist # list all events from the mirrorlist playbook logview -s ANY -d yesterday -p mirrorlist # list all events from the mirrorlist playbook
""" """
parser = OptionParser(usage=usage) parser = OptionParser(usage=usage)
parser.add_option("-d", default='today', dest='datestr', help="time string of when you want logs") parser.add_option("-d", default='today', dest='datestr', help="time string of when you want logs")
@ -49,10 +49,11 @@ def parse_args(args):
opts.search_terms = search_terms opts.search_terms = search_terms
return opts, args return opts, args
def search_logs(opts, logfiles): def search_logs(opts, logfiles):
msg = '' msg = ''
for fn in sorted(logfiles): for fn in sorted(logfiles):
hostname=os.path.basename(fn).replace('.log', '') hostname = os.path.basename(fn).replace('.log', '')
timestamp = os.path.basename(os.path.dirname(fn)) timestamp = os.path.basename(os.path.dirname(fn))
for line in open(fn): for line in open(fn):
things = line.split('\t') things = line.split('\t')
@ -61,7 +62,7 @@ def search_logs(opts, logfiles):
continue continue
# See callback_plugins/logdetail.py for how these lines get created. # See callback_plugins/logdetail.py for how these lines get created.
#MSG_FORMAT="%(now)s\t%(count)s\t%(category)s\t%(name)s\t%(data)s\n" # MSG_FORMAT="%(now)s\t%(count)s\t%(category)s\t%(name)s\t%(data)s\n"
task_ts, count, category, name, data = things task_ts, count, category, name, data = things
if category in opts.search_terms or 'ANY' in opts.search_terms: if category in opts.search_terms or 'ANY' in opts.search_terms:
@ -73,8 +74,8 @@ def search_logs(opts, logfiles):
dur = '%.2f' % (float(end) - float(st)) dur = '%.2f' % (float(end) - float(st))
else: else:
dur = None dur = None
msg += '%s\t%s\t%s\t%s\t%s\t%s' % ( msg += '%s\t%s\t%s\t%s\t%s\t%s' % (
timestamp, hostname, task_ts, count, category, name) timestamp, hostname, task_ts, count, category, name)
if not opts.verbose: if not opts.verbose:
@ -84,7 +85,7 @@ def search_logs(opts, logfiles):
msg += '\t%s:%s' % (term, slurp.get(term, None)) msg += '\t%s:%s' % (term, slurp.get(term, None))
if opts.profile and dur: if opts.profile and dur:
msg += '\t%s:%s' % ('dur', dur) msg += '\t%s:%s' % ('dur', dur)
msg += '\n' msg += '\n'
else: else:
if opts.profile and dur: if opts.profile and dur:
@ -92,28 +93,25 @@ def search_logs(opts, logfiles):
msg += '\n' msg += '\n'
msg += json.dumps(slurp, indent=4) msg += json.dumps(slurp, indent=4)
msg += '\n' msg += '\n'
return msg return msg
def main(args): def main(args):
opts,args = parse_args(args) opts, args = parse_args(args)
for pb in glob.glob(os.path.join(logpath,opts.playbook)): for pb in glob.glob(os.path.join(logpath, opts.playbook)):
pb_name = os.path.basename(pb) pb_name = os.path.basename(pb)
for pb_logdir in glob.glob(os.path.join(pb, opts.datestr)): for pb_logdir in glob.glob(os.path.join(pb, opts.datestr)):
if opts.list_pb: if opts.list_pb:
print(pb_name) print(pb_name)
continue continue
logfiles = glob.glob(pb_logdir + '/*/*.log') logfiles = glob.glob(pb_logdir + '/*/*.log')
msg = search_logs(opts, logfiles) msg = search_logs(opts, logfiles)
if msg: if msg:
print(pb_name) print(pb_name)
print(msg) print(msg)
if __name__ == "__main__": if __name__ == "__main__":
sys.exit(main(sys.argv[1:])) sys.exit(main(sys.argv[1:]))