From 76d83b13a00cb7ce2e3df3e073cdaacc80710b0b Mon Sep 17 00:00:00 2001 From: Mathieu Bridon Date: Tue, 28 Oct 2014 10:07:33 +0100 Subject: [PATCH] lookaside: Remove tempfile when hash verification fails Without this, tempfiles just accumulate. --- roles/distgit/files/dist-git-upload.cgi | 1 + 1 file changed, 1 insertion(+) diff --git a/roles/distgit/files/dist-git-upload.cgi b/roles/distgit/files/dist-git-upload.cgi index 3e8cc97dcb..9e0ecd7fec 100644 --- a/roles/distgit/files/dist-git-upload.cgi +++ b/roles/distgit/files/dist-git-upload.cgi @@ -188,6 +188,7 @@ def main(): tmpfd.close() check_md5sum = m.hexdigest() if md5sum != check_md5sum: + os.unlink(tmpfile) send_error("MD5 check failed. Received %s instead of %s." % (check_md5sum, md5sum)) # wow, even the MD5SUM matches. make sure full path is valid now