Infrastructure/ansible
3
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Wiki Activity Actions

Fix name[casing] ansible-lint issues

Browse source 
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
This commit is contained in:
Ryan Lercho 2025-01-14 20:18:57 +10:00
parent 01030eaf26
commit 691adee6ee
299 changed files with 1935 additions and 1935 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tasks/aws_cloud.yml
View file

@ -4,13 +4,13 @@
---
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: check if the server is up, needs to be pre-started
- name: Check if the server is up, needs to be pre-started
local_action: shell nc -w 5 {{ inventory_hostname }} 22 < /dev/null
register: host_is_up
changed_when: false
check_mode: no
- name: birthday=on - drop the old known host entries
- name: Birthday=on - drop the old known host entries
local_action: known_hosts path={{item}}
host={{ inventory_hostname }}
state=absent
@ -18,7 +18,7 @@
- /root/.ssh/known_hosts
when: birthday is defined
- name: birthday=on - drop other known host entries
- name: Birthday=on - drop other known host entries
local_action: known_hosts path={{ item.0 }}
host={{ item.1 }}
state=absent
@ -31,7 +31,7 @@
- additional_known_hosts_cleanup is defined
- additional_known_hosts_cleanup[inventory_hostname] is defined
- name: gather the temporary ssh host key from the new instance
- name: Gather the temporary ssh host key from the new instance
local_action: command ssh-keyscan -t {{ item }} {{ inventory_hostname }}
register: hostkey
loop:
@ -39,7 +39,7 @@
- ed25519
when: birthday is defined
- name: add new ssh host key (until we can sign it)
- name: Add new ssh host key (until we can sign it)
local_action: known_hosts path={{item.0}} key="{{ item.1.stdout }}"
host={{ inventory_hostname }} state=present
with_nested:
@ -47,7 +47,7 @@
- "{{ hostkey.results }}"
when: birthday is defined
- name: find old signatures done against the other hostname
- name: Find old signatures done against the other hostname
find:
paths: /etc/ssh
file_type: file
@ -58,7 +58,7 @@
- additional_known_hosts_cleanup is defined
- additional_known_hosts_cleanup[inventory_hostname] is defined
- name: remove old signed certificates
- name: Remove old signed certificates
file:
path: "{{ item.path }}"
state: absent
@ -67,7 +67,7 @@
- found_ssh_certs is not skipped
# from https://github.com/praiskup/ansible-role-fix-root-ssh
- name: allow root ssh connections
- name: Allow root ssh connections
lineinfile:
path: /etc/cloud/cloud.cfg
regexp: '^disable_root:'
@ -77,7 +77,7 @@
become_user: root
when: birthday is defined
- name: use the same authorized_keys
- name: Use the same authorized_keys
replace:
path: /root/.ssh/authorized_keys
regexp: '.*Please login as the user.* ssh-rsa '
@ -92,7 +92,7 @@
# Next we try and gather facts. If the host doesn't have python2 this will fail.
#
- name: gather facts
- name: Gather facts
setup:
check_mode: no
ignore_errors: true
@ -102,7 +102,7 @@
# If that failed, then we use the raw module to install things
#
- name: install python3 and dnf stuff
- name: Install python3 and dnf stuff
raw: sudo dnf -y install python3-dnf python3-libselinux python3
when:
- birthday is defined

20
tasks/cloud_setup_basic.yml
View file

@ -24,12 +24,12 @@
- name: Include basessh
include_role: name=basessh
# - name: edit hostname to be instance name - prefix hostbase var if it exists
# - name: Edit hostname to be instance name - prefix hostbase var if it exists
# shell: hostname {{ hostbase }}`curl -s http://169.254.169.254/latest/meta-data/instance-id`
# tags:
# - config
- name: add ansible root key
- name: Add ansible root key
authorized_key: user=root key="{{ item }}"
with_file:
- /srv/web/infra/ansible/roles/base/files/ansible-pub-key
@ -37,7 +37,7 @@
- config
- sshkeys
- name: add root keys for sysadmin-main and other allowed users
- name: Add root keys for sysadmin-main and other allowed users
authorized_key: user=root key="{{ item }}"
with_lines:
- "/srv/web/infra/ansible/scripts/auth-keys-from-fas @sysadmin-main {{ root_auth_users }}"
@ -47,44 +47,44 @@
# https://pagure.io/fedora-infrastructure/issue/10509
ignore_errors: true
- name: enable ssh_sysadm_login sebool
- name: Enable ssh_sysadm_login sebool
seboolean: name=ssh_sysadm_login state=yes persistent=yes
ignore_errors: true
# note - kinda should be a handler - but handlers need args
- name: restorecon
- name: Restorecon
file: path=/root/.ssh setype=ssh_home_t recurse=yes
tags:
- config
- name: update all
- name: Update all
command: yum -y update creates=/etc/sysconfig/global-update-applied
register: updated
when: ansible_distribution_major_version|int < 8 and ansible_distribution == 'RedHat'
tags:
- packages
- name: update all
- name: Update all
command: dnf -y update creates=/etc/sysconfig/global-update-applied
register: updated
when: ansible_distribution_major_version|int > 7 and ansible_distribution == 'RedHat' and ansible_cmdline.ostree is not defined
tags:
- packages
- name: update all
- name: Update all
command: dnf -y update creates=/etc/sysconfig/global-update-applied
register: updated
when: ansible_distribution_major_version|int >= 29 and ansible_distribution == 'Fedora' and ansible_cmdline.ostree is not defined
tags:
- packages
- name: write out global-update-applied file if we updated
- name: Write out global-update-applied file if we updated
copy: content="updated" dest=/etc/sysconfig/global-update-applied
when: updated is defined
tags:
- packages
- name: ensure tmp.mount is not masked, logrotate start would fail
- name: Ensure tmp.mount is not masked, logrotate start would fail
systemd:
name: tmp.mount
masked: no

2
tasks/confine_ssh.yml
View file

@ -1,5 +1,5 @@
---
- name: install the confine-ssh script
- name: Install the confine-ssh script
copy: >
src={{files}}/scripts/confine-ssh.sh
dest=/usr/local/bin/confine-ssh.sh

2
tasks/happy_birthday.yml
View file

@ -1,5 +1,5 @@
---
- name: gather ssh host key from new instance
- name: Gather ssh host key from new instance
local_action: command ssh-keyscan -t rsa {{ inventory_hostname }}
ignore_errors: true
register: hostkey

2
tasks/motd.yml
View file

@ -1,5 +1,5 @@
---
- name: add motd to system
- name: Add motd to system
template: src=/srv/web/infra/hosts/motd.j2 dest=/etc/motd
tags:
- motd

4
tasks/openvpn_client.yml
View file

@ -1,6 +1,6 @@
---
# openvpn - ftw - or something
- name: install openvpn
- name: Install openvpn
package: name=openvpn state=present
tags:
- packages
@ -40,7 +40,7 @@
notify:
- restart openvpn
- name: enable openvpn service for rhel 6
- name: Enable openvpn service for rhel 6
service: name=openvpn state=started enabled=true
tags:
- service

4
tasks/openvpn_client_7.yml
View file

@ -1,6 +1,6 @@
---
# openvpn - ftw - or something
- name: install openvpn
- name: Install openvpn
package: name=openvpn state=present
tags:
- packages
@ -40,7 +40,7 @@
notify:
- restart openvpn 7
- name: enable openvpn service for rhel or fedora
- name: Enable openvpn service for rhel or fedora
service: name=openvpn@openvpn state=started enabled=true
tags:
- service

18
tasks/persistent_cloud.yml
View file

@ -2,14 +2,14 @@
---
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: check it out
- name: Check it out
local_action: shell nc -w 5 {{ inventory_hostname }} 22 < /dev/null
register: host_is_up
ignore_errors: true
changed_when: false
check_mode: no
- name: spin UP VM using nova_compute
- name: Spin UP VM using nova_compute
become: false
local_action:
module: nova_compute
@ -53,24 +53,24 @@
failed_when: false
when: volumes is defined and volume_available is defined and item.changed
- name: wait for he host to be hot
- name: Wait for he host to be hot
local_action: wait_for host={{ public_ip }} port=22 delay=1 timeout=600
when: host_is_up is failed
# SSH is up and running, however cloud-init still did not deployed ssh keypair
# we have to wait some time. 10 sec is usually enough, but not always.
- name: waiting for cloud-init
- name: Waiting for cloud-init
pause: seconds=30
when: host_is_up is failed
- name: gather ssh host key from new instance
- name: Gather ssh host key from new instance
local_action: command ssh-keyscan -t rsa {{ inventory_hostname }}
ignore_errors: true
register: hostkey
when: host_is_up is failed
- name: add new ssh host key (until we can sign it)
- name: Add new ssh host key (until we can sign it)
local_action: known_hosts path={{item}} key="{{ hostkey.stdout }}" host={{ inventory_hostname }} state=present
ignore_errors: true
with_items:
@ -81,7 +81,7 @@
# Next we try and gather facts. If the host doesn't have python2 this will fail.
#
- name: gather facts
- name: Gather facts
setup:
check_mode: no
ignore_errors: true
@ -91,13 +91,13 @@
# If that failed, then we use the raw module to install things
#
- name: install python2 and dnf stuff
- name: Install python2 and dnf stuff
raw: dnf -y install python-dnf libselinux-python
when: facts is failed
# TODO - somehow guess when keypair is finally deployed and return little bit earlier
## We need to specify user, here we trying with fedora or root
# - name: wait until ssh is available
# - name: Wait until ssh is available
# # local_action: shell false; until [ "$?" -eq "0" ]; do sleep 2; ssh -o PasswordAuthentication=no fedora@{{ public_ip }} 'echo foobar' || ssh -o PasswordAuthentication=no root@{{ public_ip }} 'echo foobar'; done
# # local_action: shell false; until [ "$?" -eq "0" ]; do sleep 2; ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o PasswordAuthentication=no fedora@{{ public_ip }} 'echo foobar'; done
# local_action: shell whoami && ssh -vvvv -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o PasswordAuthentication=no fedora@{{ public_ip }} 'echo foobar'

4
tasks/postfix_basic.yml
View file

@ -1,5 +1,5 @@
---
- name: install postfix
- name: Install postfix
package: name=postfix state=present
tags:
- postfix
@ -21,7 +21,7 @@
- postfix
- config
- name: enable postfix to start
- name: Enable postfix to start
service: name=postfix state=started enabled=true
tags:
- service

6
tasks/rdiff_backup_server.yml
View file

@ -1,6 +1,6 @@
---
# tasklist for setting up a rdiff backup server.
- name: install rdiff-backup
- name: Install rdiff-backup
package: name={{ item }} state=present
with_items:
- rdiff-backup
@ -9,12 +9,12 @@
tags:
- packages
- name: setup rdiff backup script
- name: Setup rdiff backup script
copy: src="{{ files }}/rdiff-backup/run-rdiff-backups" dest=/usr/local/bin/run-rdiff-backups mode=755
tags:
- config
- name: setup rdiff backup cron
- name: Setup rdiff backup cron
copy: src="{{ files }}/rdiff-backup/run-rdiff-backups.cron" dest=/etc/cron.d/run-rdiff-backups
tags:
- config

2
tasks/reg-server.yml
View file

@ -1,5 +1,5 @@
---
- name: install reg-server
- name: Install reg-server
package:
name: reg
tags:

2
tasks/serialgetty.yml
View file

@ -1,6 +1,6 @@
---
- name: upstart serial setup
- name: Upstart serial setup
copy: src="{{ files }}/common/ttyS0.conf" dest=/etc/init/ttyS0.conf
when: is_rhel is defined
tags:

4
tasks/swap.yml
View file

@ -78,7 +78,7 @@
- swap
notify: restart swap.swap
- name: remove zram-generator-defaults
- name: Remove zram-generator-defaults
package:
name: zram-generator-defaults
state: absent
@ -87,7 +87,7 @@
- swap.file.dropzrampackage
- swap
- name: disable zram0
- name: Disable zram0
shell: swapoff /dev/zram0
tags:
- swap

22
tasks/virt_instance_create.yml
View file

@ -4,28 +4,28 @@
---
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- name: get vm list
- name: Get vm list
delegate_to: "{{ vmhost }}"
virt: command=list_vms
register: result
check_mode: no
- name: ensure no old facts exist
- name: Ensure no old facts exist
delegate_to: localhost
file: path=/root/.ansible_facts_cache/{{ inventory_hostname }} state=absent
when: inventory_hostname not in result.list_vms
- name: ensure the lv for the guest is made
- name: Ensure the lv for the guest is made
lvol: lv={{ inventory_hostname }} vg={{ volgroup }} size={{ lvm_size }} state=present
delegate_to: "{{ vmhost }}"
when: inventory_hostname not in result.list_vms
- name: run the virt-install
- name: Run the virt-install
shell: "{{ virt_install_command }}"
delegate_to: "{{ vmhost }}"
when: inventory_hostname not in result.list_vms
- name: wait for the install to finish -> {{ inventory_hostname }}
- name: Wait for the install to finish -> {{ inventory_hostname }}
virt: command=status name={{ inventory_hostname }}
register: vmstatus
until: vmstatus.status == 'shutdown'
@ -34,36 +34,36 @@
delay: 20
when: inventory_hostname not in result.list_vms
- name: start the vm up and set it to autostart
- name: Start the vm up and set it to autostart
virt: state=running name={{ inventory_hostname }} autostart=True
delegate_to: "{{ vmhost }}"
when: inventory_hostname not in result.list_vms
- name: make sure there is no old ssh host key for the host still around
- name: Make sure there is no old ssh host key for the host still around
local_action: known_hosts path={{item}} host={{ inventory_hostname }} state=absent
ignore_errors: true
with_items:
- /root/.ssh/known_hosts
when: inventory_hostname not in result.list_vms
- name: wait for ssh on the vm to start back
- name: Wait for ssh on the vm to start back
local_action: wait_for delay=10 host={{ inventory_hostname }} port=22 state=started timeout=1200
when: inventory_hostname not in result.list_vms
- name: gather ssh host key from new instance
- name: Gather ssh host key from new instance
local_action: command ssh-keyscan -t rsa {{ inventory_hostname }}
ignore_errors: true
register: hostkey
when: inventory_hostname not in result.list_vms
- name: add new ssh host key (until we can sign it)
- name: Add new ssh host key (until we can sign it)
local_action: known_hosts path={{item}} key="{{ hostkey.stdout }}" host={{ inventory_hostname }} state=present
ignore_errors: true
with_items:
- /root/.ssh/known_hosts
when: inventory_hostname not in result.list_vms
- name: gather facts
- name: Gather facts
setup:
check_mode: no
ignore_errors: true

26
tasks/yumrepos.yml
View file

@ -8,7 +8,7 @@
- packages
- yumrepos
- name: enable repos for archived Fedora releases
- name: Enable repos for archived Fedora releases
set_fact:
archive_if_archived: >-
{{
@ -26,7 +26,7 @@
- packages
- yumrepos
- name: put rhel repos on rhel systems
- name: Put rhel repos on rhel systems
copy: src="{{ files }}/common/rhel{{ ansible_distribution_major_version|int }}.repo" dest="/etc/yum.repos.d/rhel{{ ansible_distribution_major_version|int }}.repo"
when: ansible_distribution == 'RedHat' and not inventory_hostname.startswith('ppc9') and datacenter != "aws"
tags:
@ -34,7 +34,7 @@
- packages
- yumrepos
- name: put rhel repos on rhel systems (power9)
- name: Put rhel repos on rhel systems (power9)
copy: src="{{ files }}/common/rhel{{ ansible_distribution_major_version|int }}-power9.repo" dest="/etc/yum.repos.d/rhel{{ ansible_distribution_major_version|int }}.repo"
when: ansible_distribution == 'RedHat' and inventory_hostname.startswith('ppc9') and datacenter != "aws"
tags:
@ -42,7 +42,7 @@
- packages
- yumrepos
- name: put epel repos on el systems
- name: Put epel repos on el systems
copy: src="{{ files }}/common/epel{{ ansible_distribution_major_version|int }}.repo" dest="/etc/yum.repos.d/epel{{ ansible_distribution_major_version|int }}.repo"
when: ((ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS') and use_default_epel) and datacenter != "aws"
tags:
@ -50,7 +50,7 @@
- packages
- yumrepos
- name: put epel repos on el systems (aws)
- name: Put epel repos on el systems (aws)
copy: src="{{ files }}/common/original-epel{{ ansible_distribution_major_version|int }}.repo" dest="/etc/yum.repos.d/epel{{ ansible_distribution_major_version|int }}.repo"
when: ((ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS') and use_default_epel) and datacenter == "aws"
tags:
@ -58,7 +58,7 @@
- packages
- yumrepos
- name: put epel gpg key on el systems (aws)
- name: Put epel gpg key on el systems (aws)
copy: src="{{ files }}/common/RPM-GPG-KEY-EPEL-{{ ansible_distribution_major_version|int }}" dest="/etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-{{ ansible_distribution_major_version|int }}"
when: ((ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS') and use_default_epel) and datacenter == "aws"
tags:
@ -66,7 +66,7 @@
- packages
- yumrepos
- name: epel release on el systems (aws)
- name: Epel release on el systems (aws)
package:
name: 'epel-release'
state: present
@ -76,7 +76,7 @@
- packages
- yumrepos
- name: put fedora repos on primary architecture systems
- name: Put fedora repos on primary architecture systems
template: src="{{ files }}/common/{{ item }}" dest="/etc/yum.repos.d/{{ item }}"
with_items:
- fedora.repo
@ -88,7 +88,7 @@
- packages
- yumrepos
- name: put fedora repos on secondary architecture systems
- name: Put fedora repos on secondary architecture systems
template: src="{{ files }}/common/{{ item }}-secondary" dest="/etc/yum.repos.d/{{ item }}"
with_items:
- fedora.repo
@ -100,7 +100,7 @@
- packages
- yumrepos
- name: add infrastructure tags repo - RHEL
- name: Add infrastructure tags repo - RHEL
copy: src="{{ files }}/common/rhel-infra-tags.repo" dest="/etc/yum.repos.d/infra-tags.repo"
when: ((ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS'))
tags:
@ -108,7 +108,7 @@
- packages
- yumrepos
- name: add infrastructure STAGING tags repo - RHEL
- name: Add infrastructure STAGING tags repo - RHEL
copy: src="{{ files }}/common/rhel-infra-tags-stg.repo" dest="/etc/yum.repos.d/infra-tags-stg.repo"
when: (ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS') and env in ['staging', 'pagure-staging']
tags:
@ -116,7 +116,7 @@
- packages
- yumrepos
- name: add infrastructure tags repo - Fedora
- name: Add infrastructure tags repo - Fedora
copy: src="{{ files }}/common/fedora-infra-tags.repo" dest="/etc/yum.repos.d/infra-tags.repo"
when: ansible_distribution == 'Fedora'
tags:
@ -124,7 +124,7 @@
- packages
- yumrepos
- name: add infrastructure STAGING tags repo - Fedora
- name: Add infrastructure STAGING tags repo - Fedora
copy: src="{{ files }}/common/fedora-infra-tags-stg.repo" dest="/etc/yum.repos.d/infra-tags-stg.repo"
when: ansible_distribution == 'Fedora' and env in ['staging', 'pagure-staging']
tags: