From 637e92fe11d81a6ba4443de0f5aea86af858fa5f Mon Sep 17 00:00:00 2001 From: Jeremy Cline Date: Thu, 19 Sep 2024 10:09:51 -0400 Subject: [PATCH] fedora-image-uploader: Drop unused config options for AWS images The AMI description setting wasn't actually being used. More importantly, however, is the AMI volume size is now also unused. The reason for this is that when we import the image, the default is to use the snapshot's size as the volume size, but you can optionally set it to something else. AWS pre-allocates volumes of a couple different sizes (currently 1G, 5G, 8G, and 10G). Folks building the image set the size to be 5G, but this setting (carried over from fedimg) overrode it. Dropping it lets them control the AMI size by adjusting how big the images are. Probably not optimal for upload speed, but less confusing since there are fewer configuration layers people might not be aware of. --- roles/openshift-apps/cloud-image-uploader/templates/config.toml | 2 -- 1 file changed, 2 deletions(-) diff --git a/roles/openshift-apps/cloud-image-uploader/templates/config.toml b/roles/openshift-apps/cloud-image-uploader/templates/config.toml index 216686f96f..491a6ababf 100644 --- a/roles/openshift-apps/cloud-image-uploader/templates/config.toml +++ b/roles/openshift-apps/cloud-image-uploader/templates/config.toml @@ -35,10 +35,8 @@ arguments = {} [consumer_config.aws] base_region = "us-east-1" -ami_description = "" ami_volume_dev_name = "/dev/sda1" ami_volume_type = "gp3" -ami_volume_size = 6 ami_regions = [ "af-south-1", "eu-north-1",