Planet: improve readability of deployment and buildconfig

Signed-off-by: Pedro Moura <pmoura@redhat.com>

roles/openshift-apps/planet/templates/buildconfig.yml

@@ -1,41 +1,26 @@
 apiVersion: build.openshift.io/v1
 kind: BuildConfig
 metadata:
-  annotations:
+  name: planet
-    app.openshift.io/vcs-ref: ""
-    app.openshift.io/vcs-uri: https://github.com/fedora-infra/planet
   labels:
     app: planet
-    app.kubernetes.io/component: planet
+    build: planet  
-    app.kubernetes.io/instance: planet
-    app.kubernetes.io/name: planet
-    app.kubernetes.io/part-of: planet-app
-  name: planet
 spec:
-  nodeSelector: null
-  output:
-    to:
-      kind: ImageStreamTag
-      name: planet:latest
-  postCommit: {}
-  resources: {}
   runPolicy: Serial
   source:
-    contextDir: /
+    type: Git
     git:
       uri: https://github.com/fedora-infra/planet
-    type: Git
+      ref: {{ (env == 'production')|ternary('stable', 'staging') }}
-  strategy:
+    strategy:
-    dockerStrategy:
+      type: Docker
-      dockerfilePath: Dockerfile
+    output:
-    type: Docker
+      to:
-  triggers:
+        kind: ImageStreamTag
-  - generic:
+        name: planet:latest
-      secretReference:
+    triggers:
-        name: planet-generic-webhook-secret
+    - type: ConfigChange
-    type: Generic
+    - type: ImageChange
-  - github:
+    - type: GitHub
-      secretReference:
+      github:
-        name: planet-github-webhook-secret
+        secret: "{{ planet_stg_github_secret }}"
-    type: GitHub
-  - type: ConfigChange

roles/openshift-apps/planet/templates/deployment.yml

@@ -1,17 +1,11 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
+  name: planet
   labels:
     app: planet
-    app.kubernetes.io/component: planet
-    app.kubernetes.io/instance: planet
-    app.kubernetes.io/name: planet
-    app.kubernetes.io/part-of: planet-app
-  name: planet
 spec:
-  progressDeadlineSeconds: 600
   replicas: 1
-  revisionHistoryLimit: 10
   selector:
     matchLabels:
       app: planet
@@ -36,9 +30,5 @@ spec:
       volumes:
       - name: keytab-volume
         secret:
-          secretName: planet-keytab-http   
+          secretName: planet-keytab-http
-      dnsPolicy: ClusterFirst
+          
-      restartPolicy: Always
-      schedulerName: default-scheduler
-      securityContext: {}
-      terminationGracePeriodSeconds: 30