From 35d8b77bbdef16b7e00f8f4239860babb0da26ee Mon Sep 17 00:00:00 2001 From: Jakub Kadlcik Date: Mon, 5 Aug 2019 19:16:50 +0200 Subject: [PATCH] copr: fix deprecation warning about evaluating devel as a bare variable [DEPRECATION WARNING]: evaluating devel as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. --- roles/copr/backend/tasks/main.yml | 4 ++-- roles/copr/frontend-cloud/tasks/main.yml | 6 +++--- roles/copr/keygen/tasks/main.yml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/copr/backend/tasks/main.yml b/roles/copr/backend/tasks/main.yml index 08bd32efee..49f9a371ed 100644 --- a/roles/copr/backend/tasks/main.yml +++ b/roles/copr/backend/tasks/main.yml @@ -101,7 +101,7 @@ - name: letsencrypt cert include_role: name=copr/certbot - when: devel + when: devel|bool tags: - config @@ -178,7 +178,7 @@ - name: testing fixture copy: dest="/home/copr/cloud/ec2rc.variable" content="" - when: devel + when: devel|bool - name: copy copr-be.conf template: src="copr-be.conf.j2" dest=/etc/copr/copr-be.conf owner=root group=copr mode=640 diff --git a/roles/copr/frontend-cloud/tasks/main.yml b/roles/copr/frontend-cloud/tasks/main.yml index 1ed65a922d..a3d78cd789 100644 --- a/roles/copr/frontend-cloud/tasks/main.yml +++ b/roles/copr/frontend-cloud/tasks/main.yml @@ -113,7 +113,7 @@ # development servers use Let's Encrypt - name: install letsencrypt ssl certificates for dev include_role: name=copr/certbot - when: devel + when: devel|bool tags: - config @@ -129,11 +129,11 @@ - crond - name: set dev banner for dev instance - when: devel + when: devel|bool copy: src=banner-include.html dest=/var/lib/copr/ - name: disallow robots on dev instance - when: devel + when: devel|bool copy: src=robots.txt dest=/var/www/html/ - name: rebuild indexes diff --git a/roles/copr/keygen/tasks/main.yml b/roles/copr/keygen/tasks/main.yml index 8c9f367bc8..0f1d274e98 100644 --- a/roles/copr/keygen/tasks/main.yml +++ b/roles/copr/keygen/tasks/main.yml @@ -7,7 +7,7 @@ #- name: mount up disk of copr repo (devel) #mount: name=/var/lib/copr-keygen src='UUID=9e2b4c55-9ec3-4508-af46-a40f3a5bd982' fstype=ext4 state=mounted -#when: devel +#when: devel|devel - name: install copr-keygen dnf: state=present name=copr-keygen