From 35930379f8b6df3e30b4bdef9e4a6a6aabbf25ce Mon Sep 17 00:00:00 2001 From: Kevin Fenzi Date: Wed, 3 Jun 2020 12:58:59 -0700 Subject: [PATCH] delegations: use quotes when using a variable in a delegate_to Signed-off-by: Kevin Fenzi --- playbooks/groups/oci-registry.yml | 4 ++-- roles/letsencrypt/tasks/main.yml | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/playbooks/groups/oci-registry.yml b/playbooks/groups/oci-registry.yml index b3df2291fb..2fc8ecba50 100644 --- a/playbooks/groups/oci-registry.yml +++ b/playbooks/groups/oci-registry.yml @@ -85,7 +85,7 @@ candidate_registry_osbs_username: "{{candidate_registry_osbs_stg_username}}", candidate_registry_osbs_password: "{{candidate_registry_osbs_stg_password}}", when: env == "staging", - delegate_to: compose-x86-01.{{ datacenter }}.fedoraproject.org + delegate_to: "compose-x86-01.{{ datacenter }}.fedoraproject.org" } - { role: login-registry, @@ -93,5 +93,5 @@ candidate_registry_osbs_username: "{{candidate_registry_osbs_prod_username}}", candidate_registry_osbs_password: "{{candidate_registry_osbs_prod_password}}", when: env == "production", - delegate_to: compose-x86-01.{{ datacenter }}.fedoraproject.org + delegate_to: "compose-x86-01.{{ datacenter }}.fedoraproject.org" } diff --git a/roles/letsencrypt/tasks/main.yml b/roles/letsencrypt/tasks/main.yml index cfaf92e3c8..2570deba6d 100644 --- a/roles/letsencrypt/tasks/main.yml +++ b/roles/letsencrypt/tasks/main.yml @@ -1,5 +1,5 @@ - name: Generate (or renew) the certificate - delegate_to: certgetter01.{{ datacenter }}.fedoraproject.org + delegate_to: "certgetter01.{{ datacenter }}.fedoraproject.org" command: certbot certonly --expand --keep -n --webroot --webroot-path /var/www/html/ -d {{','.join([site_name] + server_aliases)}} run_once: true register: certbot_output @@ -10,7 +10,7 @@ # Find the directory to use - name: Get the directory to use - delegate_to: certgetter01.{{ datacenter }}.fedoraproject.org + delegate_to: "certgetter01.{{ datacenter }}.fedoraproject.org" # Sometimes we get directories like site-0001, site-0002, etc. We want the latest shell: "file /etc/letsencrypt/live/{{site_name}}* | tail -1 | sed -e 's/: directory//' | tr -d '\n'" register: certbot_dir @@ -21,7 +21,7 @@ # And once we do that, we need to copy some things. - name: Obtain the certificate - delegate_to: certgetter01.{{ datacenter }}.fedoraproject.org + delegate_to: "certgetter01.{{ datacenter }}.fedoraproject.org" command: "cat {{certbot_dir.stdout}}/cert.pem" register: certbot_certificate changed_when: 'false' @@ -30,7 +30,7 @@ - letsencrypt - name: Obtain the intermediate certificate - delegate_to: certgetter01.{{ datacenter }}.fedoraproject.org + delegate_to: "certgetter01.{{ datacenter }}.fedoraproject.org" command: cat {{certbot_dir.stdout}}/chain.pem register: certbot_chain changed_when: 'false' @@ -39,7 +39,7 @@ - letsencrypt - name: Obtain the key - delegate_to: certgetter01.{{ datacenter }}.fedoraproject.org + delegate_to: "certgetter01.{{ datacenter }}.fedoraproject.org" command: cat {{certbot_dir.stdout}}/privkey.pem register: certbot_key changed_when: 'false'